mirror of
https://github.com/morluto/rea
synced 2026-10-26 06:16:17 -04:00
4aa51bfe19
* feat(process): add owned debugger shutdown lifecycle * feat(reverse): add local inspection commands * feat(gdb): add persistent debugger integration * feat(cutter): add Cutter bridge integration * test(reverse): enforce complete integration coverage * fix(process): preserve debugger shutdown ownership * fix(reverse): retain evidence across interrupted commands * fix(gdb): honor captured provider environment * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * fix(server): snapshot provider environment at creation * fix(reverse): close review gaps with complete coverage * fix(reverse): address inspection review findings * fix(gdb): bound sessions and retain cleanup ownership * fix(ci): require reverse-tools quality lane * fix(process): unref inherited debugger output pipes * fix(reverse): address remaining PR 1960 findings * fix(gdb): address remaining PR 1961 findings * fix(reverse): account for unrestricted provider execution * fix(process): retain debugger ownership until safe shutdown * fix(process): preserve replacement debugger sessions * fix(reverse): preserve admission and output provenance * fix(process): retain exited debugger until output settles * fix(mcp): bound provider admission and debugger cleanup * fix(reverse): preserve failure provenance and classify E2BIG * fix(gdb): preserve startup cleanup and detach safety * fix(process): retain debugger ownership after detach failure * fix(reverse): preserve mutation and failure provenance * fix(gdb): address debugger review findings * fix(reverse): rebind sessions after external mutation * fix(process): cap debugger output after exit * fix(gdb): protect one-shot detach verification * feat(debugger): add reverse tool coverage gate * test(debugger): cover integrated failure paths * fix(gdb): bound and preserve session observations * fix(gdb): address review regressions * style: format merged integration files * fix(reverse): preserve session and output evidence * refactor(gdb): share repeated test and partial result setup * fix(gdb): invalidate TTY proof for Python aliases * fix(reverse): retain failure output byte counts * test(process): synchronize late debugger output * fix(gdb): invalidate TTY proof for wrapped commands * fix(gdb): recognize wit command abbreviation * test(reverse): wait for cancelled descendant readiness * test(reverse): bound descendant cancellation cleanup * style(reverse): format integration tests and adapters * style: format reverse engineering integration files * test(reverse): remove duplicate environment harness * test(gdb): share session startup assertions * fix(gdb): invalidate output proof for command abbreviations * test(reverse): share composition edge case scenarios * fix(ci): recognize verification and mutation tool entries * test(rizin): cover successful fake inferior detach * test(cli): align full output failure envelope * test(cli): isolate reverse command lifecycle service * test(process): share debugger output fixture setup * fix(binary): preserve high-bit Windows signature bytes * style(binary): format Windows signature parser * test(mcp): preserve call coverage in unchanged comparison * fix(ci): include reverse tools Vitest configs in lint cache * fix(mcp): preserve target content on delivery errors * ci: align duplication ceiling with expanded suite * test(reverse): allow signal admission mutants * fix(reverse): bound retained cleanup failures to process owners * fix(test): replace drifting mutation ranges with owned selectors * fix(reverse): admit persistent commands and retain cleanup ownership * fix(cutter): recover timed-out commands from exact receipts * fix(cutter): reject unsupported bridge request kinds * fix(ci): repair client format and shared verification fixtures * fix(native): preserve debugger cleanup ownership and bridge authentication * test(native): retain diagnostics without perfect coverage requirements * chore(licenses): refresh locked dependency inventory and notices * fix(test): exclude transient command locks from mutation sandboxes * fix(gdb): admit only platforms with safe detach verification * fix(cutter): retain bounded completion receipts until acknowledgement * fix(cutter): acknowledge commands rejected before UI dispatch * test(reverse): fail cancellation checks before fixture teardown * test(gdb): clean up the retained broken-stdin fixture owner * docs(test): clarify focused provider verification scope * fix(rizin): retain close cleanup failures * fix(gdb): wait for inferior stop and bound MI buffering * fix(cutter): retain failed receipt acknowledgements * fix(rizin): return retained session identity on rebind failure * fix(gdb): preserve startup cancellation and lossy status * fix(rizin): retain launch provenance and assemble frames once * fix(cutter): recover receipts across callers and bound discovery * docs: describe debugger evidence and bridge recovery * fix(process): keep cleanup incomplete while writers remain Stopping a debugger no longer reports success when inherited output streams stay open, so BinarySession cannot reopen a binary a child is still changing. Concurrent Cutter cleanup retries share one receipt acknowledgement instead of treating a consumed receipt as failure. * fix(debuggers): recover cleanup with captured process identities * fix(analysis): retire sessions after unrestricted commands * fix(cli): preserve completed evidence after cleanup recovery * fix(cutter): bound frame collection and coalesce cleanup * fix(windows): resolve selected provider paths absolutely * fix(gdb): report decoding loss in failed startup evidence * fix(rizin): scope decoding loss to collected command frames * test(mcp): cover snapshot retirement in reverse tools CI --------- Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com> Co-authored-by: REA Maintainers <noreply@github.com> Co-authored-by: OpenAI Codex <codex@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
146 lines
4.4 KiB
TypeScript
146 lines
4.4 KiB
TypeScript
import { chmod, mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
|
|
import { afterEach, expect, it } from "vitest";
|
|
|
|
import { GdbSessionManager } from "../../../src/gdb/GdbSessionManager.js";
|
|
|
|
let directory: string | undefined;
|
|
const managers: GdbSessionManager[] = [];
|
|
|
|
afterEach(async () => {
|
|
await Promise.all(
|
|
managers
|
|
.splice(0)
|
|
.map((manager) => manager.closeAll().catch(() => undefined)),
|
|
);
|
|
if (directory !== undefined)
|
|
await rm(directory, { recursive: true, force: true });
|
|
directory = undefined;
|
|
});
|
|
|
|
it("bounds active and queued GDB commands, including cancelled placeholders", async () => {
|
|
directory = await mkdtemp(join(tmpdir(), "rea-gdb-command-queue-limit-"));
|
|
const provider = join(directory, "fake-gdb-queue.mjs");
|
|
const activePath = join(directory, "active-command");
|
|
const releasePath = join(directory, "release-command");
|
|
await writeFile(
|
|
provider,
|
|
`#!${process.execPath}
|
|
import { access, writeFile } from "node:fs/promises";
|
|
process.stdout.write("(gdb)\\n");
|
|
let input = "";
|
|
let firstConsoleCommand = true;
|
|
process.stdin.setEncoding("utf8");
|
|
process.stdin.on("data", async (chunk) => {
|
|
input += chunk;
|
|
for (;;) {
|
|
const boundary = input.indexOf("\\n");
|
|
if (boundary < 0) break;
|
|
const line = input.slice(0, boundary); input = input.slice(boundary + 1);
|
|
const match = /^(\\d+)/.exec(line);
|
|
if (!match) continue;
|
|
if (line.includes("-interpreter-exec console") && firstConsoleCommand) {
|
|
firstConsoleCommand = false;
|
|
await writeFile(${JSON.stringify(activePath)}, "active");
|
|
for (;;) {
|
|
try { await access(${JSON.stringify(releasePath)}); break; }
|
|
catch { await new Promise((resolve) => setTimeout(resolve, 10)); }
|
|
}
|
|
}
|
|
process.stdout.write(match[1] + "^done\\n");
|
|
}
|
|
});
|
|
`,
|
|
);
|
|
await chmod(provider, 0o700);
|
|
const manager = new GdbSessionManager({
|
|
platform: "linux",
|
|
environment: { REA_GDB_COMMAND: provider },
|
|
});
|
|
managers.push(manager);
|
|
const started = await manager.start();
|
|
expect(started.ok).toBe(true);
|
|
if (!started.ok) return;
|
|
|
|
const active = manager.execute(started.value.session_id, "hold");
|
|
let activeSeen = false;
|
|
for (let attempt = 0; attempt < 100 && !activeSeen; attempt += 1) {
|
|
try {
|
|
await readFile(activePath, "utf8");
|
|
activeSeen = true;
|
|
} catch {
|
|
await new Promise((resolve) => setTimeout(resolve, 10));
|
|
}
|
|
}
|
|
expect(activeSeen).toBe(true);
|
|
|
|
const controllers = Array.from({ length: 15 }, () => new AbortController());
|
|
const queued = controllers.map((controller, index) =>
|
|
manager.execute(
|
|
started.value.session_id,
|
|
`queued-${index}`,
|
|
controller.signal,
|
|
),
|
|
);
|
|
const safetyRelease = setTimeout(() => {
|
|
void writeFile(releasePath, "safety release");
|
|
}, 250);
|
|
const overflow = await manager.execute(started.value.session_id, "overflow");
|
|
clearTimeout(safetyRelease);
|
|
expect(overflow).toMatchObject({
|
|
ok: false,
|
|
error: {
|
|
_tag: "AnalysisResourceConstraintError",
|
|
operation: "gdb_console",
|
|
resource: "transport",
|
|
reportedLimits: {
|
|
max_pending_commands: 16,
|
|
active_or_queued_commands: 16,
|
|
},
|
|
},
|
|
});
|
|
|
|
for (const controller of controllers) controller.abort();
|
|
const cancelled = await Promise.all(queued);
|
|
expect(cancelled).toHaveLength(15);
|
|
expect(
|
|
cancelled.every(
|
|
(result) => !result.ok && result.error._tag === "AnalysisCancelledError",
|
|
),
|
|
).toBe(true);
|
|
const cancellationSafetyRelease = setTimeout(() => {
|
|
void writeFile(releasePath, "safety release after cancellation");
|
|
}, 250);
|
|
try {
|
|
await expect(
|
|
manager.execute(
|
|
started.value.session_id,
|
|
"cannot-bypass-cancelled-placeholders",
|
|
),
|
|
).resolves.toMatchObject({
|
|
ok: false,
|
|
error: {
|
|
_tag: "AnalysisResourceConstraintError",
|
|
reportedLimits: { active_or_queued_commands: 16 },
|
|
},
|
|
});
|
|
} finally {
|
|
clearTimeout(cancellationSafetyRelease);
|
|
}
|
|
await writeFile(releasePath, "release");
|
|
expect((await active).ok).toBe(true);
|
|
const admittedAfterDrain = await manager.execute(
|
|
started.value.session_id,
|
|
"admitted-after-drain",
|
|
);
|
|
expect(admittedAfterDrain.ok).toBe(true);
|
|
await expect(
|
|
manager.execute(started.value.session_id, "after-drain"),
|
|
).resolves.toMatchObject({
|
|
ok: true,
|
|
value: { result: { completion_status: "complete" } },
|
|
});
|
|
});
|