From 0c01a997ac3e21227ac092248c4d20e06e422017 Mon Sep 17 00:00:00 2001
From: Nick Matantsev <nick.matantsev@gmail.com>
Date: Thu, 25 Dec 2025 19:06:19 -0500
Subject: [PATCH] Avoid referencing found MIDI device name

---
 packages/midi/midi.mjs | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/packages/midi/midi.mjs b/packages/midi/midi.mjs
index 49a87ac1f..eb6ca12ef 100644
--- a/packages/midi/midi.mjs
+++ b/packages/midi/midi.mjs
@@ -483,6 +483,8 @@ class MidiInput {
    * @param {string | number} input MIDI device name or index defaulting to 0
    */
   constructor(input) {
+    this.stateKey = typeof input === 'string' ? input : undefined;
+
     const device = getDevice(input, WebMidi.inputs);
     if (!device) {
       throw new Error(
@@ -490,8 +492,6 @@ class MidiInput {
       );
     }
 
-    this.name = device.name;
-
     this._refs = {};
     this._refsByChan = {};
 
@@ -540,7 +540,13 @@ class MidiInput {
   }
 
   _loadState(chan) {
-    const initialDataRaw = localStorage.getItem(`strudel-midin-${this.name}-chan${chan !== undefined ? chan : 'all'}`);
+    if (!this.stateKey) {
+      return {};
+    }
+
+    const initialDataRaw = localStorage.getItem(
+      `strudel-midin-${this.stateKey}-chan${chan !== undefined ? chan : 'all'}`,
+    );
     if (!initialDataRaw) {
       return {};
     }
@@ -549,7 +555,7 @@ class MidiInput {
       return JSON.parse(initialDataRaw);
     } catch (err) {
       console.warn(
-        `Failed to parse MIDI state from localStorage for input "${this.name}" and channel "${chan}"`,
+        `Failed to parse MIDI state from localStorage for input "${this.stateKey}" and channel "${chan}"`,
         initialDataRaw,
         err,
       );
@@ -558,9 +564,16 @@ class MidiInput {
   }
 
   _saveState(chan, cc, value) {
+    if (!this.stateKey) {
+      return;
+    }
+
     const state = this._loadState(chan);
     state[cc] = value;
-    localStorage.setItem(`strudel-midin-${this.name}-chan${chan !== undefined ? chan : 'all'}`, JSON.stringify(state));
+    localStorage.setItem(
+      `strudel-midin-${this.stateKey}-chan${chan !== undefined ? chan : 'all'}`,
+      JSON.stringify(state),
+    );
   }
 
   _sendAllStates(output) {