From 51f0bab1f84922474354d4b289a12bdd0aeb1dd5 Mon Sep 17 00:00:00 2001
From: "Jade (Rose) Rowland" <jaderowlanddev@gmail.com>
Date: Sat, 26 Jul 2025 12:54:59 -0400
Subject: [PATCH] duckarray

---
 packages/core/controls.mjs         |  2 +-
 packages/superdough/superdough.mjs | 22 +++++++++++++---------
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/packages/core/controls.mjs b/packages/core/controls.mjs
index 631896e94..741b66488 100644
--- a/packages/core/controls.mjs
+++ b/packages/core/controls.mjs
@@ -535,7 +535,7 @@ export const { tremoloshape } = registerControl('tremoloshape', 'tremshape');
  * stack( n(run(8)).scale("c:minor").s("sawtooth").delay(.7).orbit(2), s("bd:4!4").beat("0,4,8,11,14",16).duckorbit(2).duckattack(0.2).duckdepth(1))
  *
  */
-export const { duck } = registerControl(['duckorbit', 'duckattack', 'duckdepth'], 'duck');
+export const { duck } = registerControl('duckorbit', 'duck');
 
 /**
  *  the amount of ducking applied to target orbit
diff --git a/packages/superdough/superdough.mjs b/packages/superdough/superdough.mjs
index a98f55f3e..011326c6a 100644
--- a/packages/superdough/superdough.mjs
+++ b/packages/superdough/superdough.mjs
@@ -419,16 +419,20 @@ function setOrbit(audioContext, orbit, channels) {
     connectToDestination(orbits[orbit].gain, channels);
   }
 }
-function duckOrbit(target, t, attacktime = 0.1, duckdepth = 1) {
-  if (orbits[target] == null) {
-    errorLogger(new Error('duck target orbit does not exist'), 'superdough');
-  }
+function duckOrbit(targetOrbit, t, attacktime = 0.1, duckdepth = 1) {
+  const targetArr = [targetOrbit].flat();
 
-  orbits[target].gain.gain.cancelAndHoldAtTime(t);
-  const currVal = orbits[target].gain.gain.value;
-  orbits[target].gain.gain.setValueAtTime(currVal, t);
-  orbits[target].gain.gain.linearRampToValueAtTime(clamp(1 - duckdepth, 0.01, currVal), t + 0.002);
-  orbits[target].gain.gain.exponentialRampToValueAtTime(1, t + Math.max(0.002, attacktime));
+  targetArr.forEach((target) => {
+    if (orbits[target] == null) {
+      errorLogger(new Error(`duck target orbit ${target} does not exist`), 'superdough');
+      return;
+    }
+    orbits[target].gain.gain.cancelAndHoldAtTime(t);
+    const currVal = orbits[target].gain.gain.value;
+    orbits[target].gain.gain.setValueAtTime(currVal, t);
+    orbits[target].gain.gain.linearRampToValueAtTime(clamp(1 - Math.pow(duckdepth, 0.5), 0.01, currVal), t + 0.002);
+    orbits[target].gain.gain.exponentialRampToValueAtTime(1, t + Math.max(0.002, attacktime));
+  });
 }
 
 let hasChanged = (now, before) => now !== undefined && now !== before;