mirror/strudel
1
0
Fork 0
mirror of https://codeberg.org/uzu/strudel synced 2026-09-06 07:05:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

draw straight line when no analyser is defined yet

Browse Source 
+ add todo for memory leak
This commit is contained in:
Felix Roos
2024-03-16 03:12:00 +01:00
parent dd78dc9606
commit cdc200e1da
2 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/widgets/canvas.mjs
+6
View File
@@ -25,5 +25,11 @@ registerWidget('twist', (id, options = {}, pat) => {
registerWidget('osci', (id, options = {}, pat) => {
options = { width: 500, height: 60, pos: 0.5, scale: 1, ...options };
const ctx = getCanvasWidget(id, options).getContext('2d');
// TODO: find way to clear previous analysers to avoid memory leak
// .scope passes id to Pattern.analyze, which is picked up by superdough
// .. which calls getAnalyserById(analyze), creating a new analyzer (+buffer) for that key
// the id here is the col number where the osci function ends (as passed by the transpiler)
// effectively, this means for each evaluation of .osci on a unique col, a new analyser will be created
// the problem is that the old ones will never get deleted.. this might pile up some memory
return pat.scope({ ...options, ctx, id });
});