Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
This commit is contained in:
LagoLunatic
2025-12-23 18:53:10 -05:00
committed by GitHub
parent 6ef13c620a
commit 877889c510
887 changed files with 1174 additions and 1727 deletions
+8 -8
View File
@@ -351,21 +351,21 @@ void daHorse_c::coHitCallbackCowHit(fopAc_ac_c* i_hitActor) {
static void daHorse_coHitCallbackBoarJump(fopAc_ac_c* i_coActorA, dCcD_GObjInf* i_coObjInfA,
fopAc_ac_c* i_coActorB, dCcD_GObjInf* i_coObjInfB) {
(void)i_coObjInfA;
(void)i_coObjInfB;
UNUSED(i_coObjInfA);
UNUSED(i_coObjInfB);
((daHorse_c*)i_coActorA)->coHitCallbackBoarJump(i_coActorB);
}
static void daHorse_coHitCallbackCowHit(fopAc_ac_c* i_coActorA, dCcD_GObjInf* i_coObjInfA,
fopAc_ac_c* i_coActorB, dCcD_GObjInf* i_coObjInfB) {
(void)i_coObjInfA;
(void)i_coObjInfB;
UNUSED(i_coObjInfA);
UNUSED(i_coObjInfB);
((daHorse_c*)i_coActorA)->coHitCallbackCowHit(i_coActorB);
}
static void daHorse_coHitCallbackAll(fopAc_ac_c* i_coActorA, dCcD_GObjInf* i_coObjInfA,
fopAc_ac_c* i_coActorB, dCcD_GObjInf* i_coObjInfB) {
(void)i_coObjInfA;
UNUSED(i_coObjInfA);
daHorse_c* a_this = (daHorse_c*)i_coActorA;
a_this->coHitCallbackBoarJump(i_coActorB);
@@ -2159,7 +2159,7 @@ void daHorse_c::setMatrix() {
var_f30 = 0.5f + ((0.5f * speedF) / m_lashMaxSpeedF);
}
var_r29 = 4.0f * var_f30 * ((500.0f / (f32)field_0x16c2) * (f32)(s16)(field_0x16e8 - shape_angle.y));
var_r29 = 4.0f * var_f30 * ((500.0f / (f32)field_0x16c2) * (s16)(field_0x16e8 - shape_angle.y));
var_r27 = -var_r29;
}
@@ -4218,7 +4218,7 @@ void daHorse_c::searchSceneChangeArea(fopAc_ac_c* i_scnChg) {
}
static void* daHorse_searchSceneChangeArea(fopAc_ac_c* i_actor, void* i_data) {
(void)i_data;
UNUSED(i_data);
dComIfGp_getHorseActor()->searchSceneChangeArea(i_actor);
return NULL;
}
@@ -4546,7 +4546,7 @@ static actor_method_class l_daHorse_Method = {
(process_method_func)daHorse_Draw,
};
extern actor_process_profile_definition g_profile_HORSE = {
actor_process_profile_definition g_profile_HORSE = {
fpcLy_CURRENT_e, // mLayerID
4, // mListID
fpcPi_CURRENT_e, // mListPrio