Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
This commit is contained in:
LagoLunatic
2025-12-23 18:53:10 -05:00
committed by GitHub
parent 6ef13c620a
commit 877889c510
887 changed files with 1174 additions and 1727 deletions
+1 -4
View File
@@ -1383,12 +1383,9 @@ void dMenu_Fmap_c::portal_demo5_init() {
void dMenu_Fmap_c::portal_demo5_move() {
mpStick->checkTrigger();
// fakematch: the call to the fake inline function dMeter2Info_isTouchKeyCheck_alt
// should actually call dMeter2Info_isTouchKeyCheck, but for some reason the generated asm
// is different from every other call to dMeter2Info_isTouchKeyCheck
if (dMw_B_TRIGGER() || dMw_Z_TRIGGER() || dMw_START_TRIGGER() || dMw_UP_TRIGGER()
|| dMw_DOWN_TRIGGER() || dMw_LEFT_TRIGGER() || dMw_RIGHT_TRIGGER()
|| dMeter2Info_isTouchKeyCheck_alt(0xc))
|| dMeter2Info_isTouchKeyCheck(0xc))
{
dMsgObject_setTalkHeap(mpTalkHeap);
fopMsgM_messageSet(2015, 1000);