Use consistent s32/u32 (#2964)

* cleanup long usage

* fix regression

include/JSystem/JAudio2/JASCalc.h

@@ -36,7 +36,7 @@ struct JASCalc {
     }
 
     f32 fake1();
-    f32 fake2(long x);
+    f32 fake2(s32 x);
     f32 fake3();
 
     static const s16 CUTOFF_TO_IIR_TABLE[128][4];

include/JSystem/JAudio2/JASCallback.h

@@ -3,7 +3,7 @@
 
 #include "dolphin/types.h"
 
-typedef long JASCallback(void*);
+typedef s32 JASCallback(void*);
 
 /**
  * @ingroup jsystem-jaudio

include/JSystem/JAudio2/JASProbe.h

@@ -16,7 +16,7 @@ struct JASProbe {
     static JASProbe* sProbeTable[16];
 
     /* 0x000 */ char const* mName;
-	/* 0x004 */ long mStartTime;
+	/* 0x004 */ s32 mStartTime;
 	/* 0x008 */ f32 _08;
 	/* 0x00C */ f32 _0C;
 	/* 0x010 */ f32 _10;

include/JSystem/JAudio2/JASWaveArcLoader.h

@@ -58,7 +58,7 @@ struct JASWaveArc : JASDisposer {
     struct loadToAramCallbackParams {
         // not official struct name
         /* 0x0 */ JASWaveArc* mWavArc;
-        /* 0x4 */ long mEntryNum;
+        /* 0x4 */ s32 mEntryNum;
         /* 0x8 */ u32 mBase;
         /* 0xC */ u32 _c;
     };

include/JSystem/JGadget/define.h

@@ -15,14 +15,14 @@ public:
     JGadget_outMessage(MessageFunc fn, const char* file, int line);
     ~JGadget_outMessage();
 
-    JGadget_outMessage& operator<<(int param_1) { return *this << (signed long)param_1; }
+    JGadget_outMessage& operator<<(int param_1) { return *this << (s32)param_1; }
     JGadget_outMessage& operator<<(u16);
-    JGadget_outMessage& operator<<(unsigned int);
+    JGadget_outMessage& operator<<(uint);
     JGadget_outMessage& operator<<(u8 param_1) { return *this << (char)param_1; }
     JGadget_outMessage& operator<<(const char* str);
     JGadget_outMessage& operator<<(char);
-    JGadget_outMessage& operator<<(signed long);
-    JGadget_outMessage& operator<<(unsigned long);
+    JGadget_outMessage& operator<<(s32);
+    JGadget_outMessage& operator<<(u32);
     JGadget_outMessage& operator<<(const void*);
 
 private:

include/JSystem/JGadget/linklist.h

@@ -128,8 +128,8 @@ struct TLinkList : TNodeLinkList {
 
         iterator& operator=(const iterator& rhs) {
             //TODO: Probably fakematch? Not sure what's going on here exactly
-            (TIterator<std::bidirectional_iterator_tag, T, long, T*, T&>&)*this =
-                (const TIterator<std::bidirectional_iterator_tag, T, long, T*, T&>&)rhs;
+            (TIterator<std::bidirectional_iterator_tag, T, s32, T*, T&>&)*this =
+                (const TIterator<std::bidirectional_iterator_tag, T, s32, T*, T&>&)rhs;
             this->node = rhs.node;
             return *this;
         }

include/JSystem/JUtility/JUTException.h

@@ -152,7 +152,7 @@ STATIC_ASSERT(sizeof(JUTException) == 0xA4);
 */
 struct JUTWarn {
     JUTWarn& operator<<(const char*) { return *this; }
-    JUTWarn& operator<<(long) { return *this; }
+    JUTWarn& operator<<(s32) { return *this; }
 };
 
 #endif /* JUTEXCEPTION_H */

include/SSystem/SComponent/c_lib.h

@@ -9,8 +9,8 @@ inline bool cLib_IsZero(f32 value) {
     return fabsf(value) < 8e-11f;
 }
 
-void cLib_memCpy(void* dst, const void* src, unsigned long size);
-void cLib_memSet(void* ptr, int value, unsigned long size);
+void cLib_memCpy(void* dst, const void* src, u32 size);
+void cLib_memSet(void* ptr, int value, u32 size);
 
 f32 cLib_addCalc(f32* o_value, f32 target, f32 scale, f32 maxStep, f32 minStep);
 void cLib_addCalc2(f32* o_value, f32 target, f32 scale, f32 maxStep);

include/d/d_msg_object.h

@@ -411,7 +411,7 @@ inline void dMsgObject_setShopWaitTimer(u8 timer) {
     dMsgObject_c::setShopWaitTimer(timer);
 }
 
-inline void dMsgObject_changeFlowGroup(long flow) {
+inline void dMsgObject_changeFlowGroup(s32 flow) {
     dMsgObject_getMsgObjectClass()->changeFlowGroup(flow);
 }