Fix spurious differences when using ninja diff (#2294)

* Fix spurious differences when using ninja diff

* Fix some clangd errors/warnings
This commit is contained in:
LagoLunatic
2025-01-27 01:01:05 -05:00
committed by GitHub
parent 5644936254
commit bf4053fefa
48 changed files with 296 additions and 140 deletions
-6
View File
@@ -25,12 +25,6 @@ public:
/* 80192F10 */ dBrightCheck_c(JKRArchive*);
/* 80192F98 */ virtual ~dBrightCheck_c();
// TODO: probably fake, probably going to break some other function
// need to figure out this weird vtable padding issue
virtual void dummy() = 0;
virtual void dummy2() = 0;
virtual void dummy3() = 0;
/* 80193030 */ void screenSet();
/* 801934D0 */ void _move();
/* 80193508 */ void modeWait();
-6
View File
@@ -32,12 +32,6 @@ public:
/* 801924A0 */ virtual ~dFile_info_c();
// fake? needed to get vtable size correct
#ifdef DFILE_INFO_C_DUMMY_VIRTUAL
virtual void dummy() = 0;
virtual void dummy2() = 0;
#endif
void setBasePane(J2DPane* pane) { mFileInfo.mBasePane = pane; }
CPaneMgrAlpha* getDatBase() { return mDatBase; }
CPaneMgrAlpha* getNoDatBase() { return mNoDatBase; }
-6
View File
@@ -38,12 +38,6 @@ public:
/* 80191C18 */ virtual ~dFile_warning_c();
// fake? needed to get vtable size correct
#ifdef DFILE_WARNING_C_DUMMY_VIRTUAL
virtual void dummy() = 0;
virtual void dummy2() = 0;
#endif
u8 getStatus() { return mStatus; }
void draw() { _draw(); }
-5
View File
@@ -43,11 +43,6 @@ public:
/* 801AFBF4 */ virtual void draw();
/* 801AED64 */ virtual ~dMenu_Calibration_c();
// this is just a hack to get .data section to match
// not sure how to fix it without this atm
virtual void unk0() = 0;
virtual void unk1() = 0;
/* 0x004 */ JKRExpHeap* mpHeap;
/* 0x008 */ JKRArchive* mpArchive;
/* 0x00C */ J2DScreen* mpCalibrationMainScrn;