Address code review comments

This commit is contained in:
Dylan Ascencio
2023-10-04 01:47:05 -04:00
parent e336d5e8fd
commit 315c2cfbf0
4 changed files with 14 additions and 22 deletions
+3 -3
View File
@@ -129,8 +129,8 @@ public:
Mtx33** getBumpMtxPtrPtr(u32 idx) const { return mpBumpMtxArr[1][idx]; }
Mtx33* getBumpMtxPtr(u32 idx) const { return mpBumpMtxArr[1][idx][mCurrentViewNo]; }
void setBaseScale(const Vec& scale) { mBaseScale = scale; }
void setUserArea(void* area) { mUserArea = area; }
void* getUserArea() const { return mUserArea; }
void setUserArea(u32 area) { mUserArea = area; }
u32 getUserArea() const { return mUserArea; }
Vec* getBaseScale() { return &mBaseScale; }
void setVisibilityManager(J3DVisibilityManager* manager) { mpVisibilityManager = manager; }
@@ -138,7 +138,7 @@ public:
/* 0x008 */ u32 mFlags;
/* 0x00C */ u32 mDiffFlag;
/* 0x010 */ J3DCalcCallBack mCalcCallBack;
/* 0x014 */ void* mUserArea;
/* 0x014 */ u32 mUserArea;
/* 0x018 */ Vec mBaseScale;
/* 0x024 */ Mtx mBaseTransformMtx;
/* 0x054 */ Mtx mInternalView;
+1 -1
View File
@@ -112,7 +112,7 @@ public:
virtual void checkCutCharge() const;
virtual void getBokoFlamePos(cXyz*);
virtual void checkTactWait() const;
virtual void setTactZev(unsigned int, int, const char*);
virtual void setTactZev(unsigned int, int, char*);
virtual void onDekuSpReturnFlg(u8);
virtual void checkComboCutTurn() const;
virtual f32 getBaseAnimeFrameRate() = 0;
-6
View File
@@ -135,12 +135,6 @@ public:
bool checkCommandDemoAccrpt() { return mCommand == 2; }
bool checkCommandCatch() { return mCommand == 6; }
//void suspendProc(void* actor) {
// if (field_0x10 != NULL) {
// field_0x14(actor);
// }
//}
/* 0x04 */ u16 mCommand;
/* 0x06 */ u16 mCondition;
/* 0x08 */ s16 mEventId;