d_a_obj_rcloud (#849)

* d_a_obj_rcloud

* Refactor daObjRcloud_c and update resource usage

Renamed enum values and return types in daObjRcloud_c for clarity and consistency. Updated resource indices to use named constants from res_bvkumo.h. Replaced magic numbers and variable names for improved readability. Removed an obsolete comment in J3DTexture.h.

* Rename variable o_phase to phase in _create method

Refactored the variable name from o_phase to phase in the daObjRcloud_c::_create() method for clarity and consistency.

* Set configure.py to matching.
This commit is contained in:
Kristopher Early
2025-08-14 21:26:54 +01:00
committed by GitHub
parent 2eaf012e4f
commit 396599cd7a
4 changed files with 205 additions and 32 deletions
+1 -2
View File
@@ -74,8 +74,7 @@ public:
void setViewMtx(const Mtx viewMtx) { MTXCopy(viewMtx, mViewMtx); }
void setTranslationX(f32 translationX){ mTexMtxInfo.mSRT.mTranslationX = translationX; } // Fakematch
// TODO
void getTextureSRT() {}
J3DTextureSRTInfo& getTextureSRT() { return mTexMtxInfo.mSRT;}
private:
/* 0x00 */ J3DTexMtxInfo mTexMtxInfo;
+17 -10
View File
@@ -2,16 +2,24 @@
#define D_A_OBJ_RCLOUD_H
#include "f_op/f_op_actor.h"
#include "d/d_a_obj.h"
#include "m_Do/m_Do_ext.h"
#include "SSystem/SComponent/c_phase.h"
class daObjRcloud_c : public fopAc_ac_c {
public:
void param_get_arg() const {}
typedef void (daObjRcloud_c::*ProcFunc)();
enum Param_e {
PRM_ARG_W = 1,
PRM_ARG_S = 0,
};
int param_get_arg() const { return daObj::PrmAbstract(this, PRM_ARG_W, PRM_ARG_S); }
void init_mtx();
void solidHeapCB(fopAc_ac_c*);
void create_heap();
static BOOL solidHeapCB(fopAc_ac_c*);
bool create_heap();
cPhs_State _create();
bool _delete();
void wait_act_proc();
@@ -23,15 +31,14 @@ public:
bool _draw();
public:
/* 0x290 */ request_of_phase_process_class mPhsBVkumo;
/* 0x290 */ request_of_phase_process_class mPhase;
/* 0x298 */ J3DModel* mpModel;
/* 0x29C */ mDoExt_btkAnm mBtkAnm;
/* 0x2B0 */ u8 m2B0[0x2BC - 0x2B0];
/* 0x2B0 */ ProcFunc mCurrentActProc;
/* 0x2BC */ int m2BC;
/* 0x2C0 */ int m2C0;
/* 0x2C4 */ u8 m2C4;
/* 0x2C0 */ int mDemoNameIndex;
/* 0x2C4 */ u8 mResourceLoadedFlag;
/* 0x2C5 */ u8 m2C5[0x2C8 - 0x2C5];
/* 0x2C8 */ f32 m2C8;
/* 0x2C8 */ f32 mCloudAnimProgress;
};
#endif /* D_A_OBJ_RCLOUD_H */