Improve compiler compatibility (#743)

* fix returns

* use standard C headers

* struct/class mismatch

* explicit this in template

* switch variable scope

* C standard compliance

* & l-value

src/JSystem/J2DGraph/J2DTextBox.cpp

@@ -9,7 +9,7 @@
 #include "JSystem/JUtility/JUTResource.h"
 #include "JSystem/J2DGraph/J2DPrint.h"
 #include "dolphin/gx/GXTransform.h"
-#include "__va_arg.h"
+#include "stdarg.h"
 
 /* 802D51D8-802D5268       .text __ct__10J2DTextBoxFPCcPCc */
 J2DTextBox::J2DTextBox(const char* font, const char* str) : mpFont(NULL), mStringPtr(NULL) {

src/JSystem/JAudio/dspproc.c

@@ -4,9 +4,10 @@
 //
 
 #include "JSystem/JAudio/dspproc.h"
-#include "JSystem/JAudio/JASDSPInterface.h"
 #include "JSystem/JAudio/dsptask.h"
 
+u16 DSP_CreateMap2(u32 param_1);
+
 /* 8028E600-8028E648       .text DSPReleaseHalt2__FUl */
 void DSPReleaseHalt2(u32 msg) {
     u32 msgs[2];
@@ -26,7 +27,7 @@ void DSPReleaseHalt() {
 static volatile BOOL flag;
 
 /* 8028E6A0-8028E6AC       .text setup_callback__FUs */
-void setup_callback(u16) {
+void setup_callback(u16 param_1) {
     flag = 0;
 }
 
@@ -40,7 +41,7 @@ void DsetupTable(u32 param_1, u32 param_2, u32 param_3, u32 param_4, u32 param_5
     table[4] = param_5;
     flag = 1;
     DSPSendCommands2(table,5,setup_callback);
-    while (true) {
+    while (TRUE) {
         if (flag == 0) {
             return;
         }
@@ -66,7 +67,7 @@ void DsyncFrame(u32 param_1, u32 param_2, u32 param_3) {
 static volatile BOOL d_waitflag;
 
 /* 8028E7E0-8028E7EC       .text dummy_callback__FUs */
-void dummy_callback(u16) {
+void dummy_callback(u16 param_1) {
     d_waitflag = 0;
 }
 

src/JSystem/JAudio/dsptask.c

@@ -10,7 +10,7 @@
 #include "global.h"
 
 /* 8028E860-8028E898       .text DspHandShake__FPv */
-void DspHandShake(void*) {
+void DspHandShake(void* param_1) {
     while (DSPCheckMailFromDSP() == 0) {}
     DSPReadMailFromDSP();
     DSPCheckMailFromDSP();

src/JSystem/JMessage/processor.cpp

@@ -54,7 +54,7 @@ void TProcessor::pushCurrent(const char* v) {
 }
 
 /* 8029EEA4-8029EEC8       .text popCurrent__Q28JMessage10TProcessorFv */
-const char* TProcessor::popCurrent() {
+void TProcessor::popCurrent() {
     setCurrent_(mStack.top());
     mStack.pop();
 }

src/JSystem/JStudio/JStudio/functionvalue.cpp

@@ -8,7 +8,7 @@
 #include "JSystem/JGadget/linklist.h"
 #include "dolphin/types.h"
 #include "math.h"
-#include "arith.h"
+#include "stdlib.h"
 
 namespace JStudio {