From 67e6c789e1101213362bece6d426710d1f48b05c Mon Sep 17 00:00:00 2001 From: Briggs Baltzell Date: Sun, 8 Feb 2026 18:58:51 -0600 Subject: [PATCH] Refactor `dMCloth_c::plot` to improve naming consistency for loop variables and pointer arithmetic. --- src/d/d_menu_cloth.cpp | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/d/d_menu_cloth.cpp b/src/d/d_menu_cloth.cpp index 6a705de53..c2fed4eb4 100644 --- a/src/d/d_menu_cloth.cpp +++ b/src/d/d_menu_cloth.cpp @@ -127,24 +127,24 @@ void dMCloth_c::cloth_init() { /* Nonmatching */ cXyz* pNrm = getNrm(); - for (int i = 0; i < INNER_SIZE; i++) { - s16 xAngle = -(i * 3500); - for (int j = 0; j < INNER_SIZE; j++) { - cXyz* pPos = &getPos()[i * INNER_SIZE + j]; - pPos->x = cM_ssin(j * 3276.8f) * 954.9299f + -1500.0f + j * 10.0f * cM_ssin(xAngle); - pPos->y = i * 300.0f + -1500.0f; - pPos->z = (1.0f - cM_scos(j * 3276.8f)) * 716.1974f - 3400.0f + j * -5.0f * cM_scos(xAngle); + for (int y = 0; y < INNER_SIZE; y++) { + s16 yAngle = -(y * 3500); + for (int x = 0; x < INNER_SIZE; x++) { + cXyz* pPos = &getPos()[x + y * INNER_SIZE]; + pPos->x = cM_ssin(x * 3276.8f) * 954.9299f + -1500.0f + x * 10.0f * cM_ssin(yAngle); + pPos->y = y * 300.0f + -1500.0f; + pPos->z = (1.0f - cM_scos(x * 3276.8f)) * 716.1974f + -3400.0f + x * -5.0f * cM_scos(yAngle); - cXyz* pOff = &getOffsetVec()[i * INNER_SIZE + j]; - pOff->x = cM_scos(j * 3276.8f - 1000.0f) * -320.0f; + cXyz* pOff = &getOffsetVec()[x + y * INNER_SIZE]; + pOff->x = cM_scos(x * 3276.8f - 1000.0f) * -320.0f; pOff->y = 0.0f; - pOff->z = cM_ssin(j * 3276.8f - 1000.0f) * -270.0f; + pOff->z = cM_ssin(x * 3276.8f - 1000.0f) * -270.0f; } } - for (int i = 0; i < INNER_SIZE; i++) { - for (int j = 0; j < INNER_SIZE; j++) { - setNrmVtx(pNrm, j, i); + for (int y = 0; y < INNER_SIZE; y++) { + for (int x = 0; x < INNER_SIZE; x++) { + setNrmVtx(pNrm, x, y); pNrm++; } }