Move extern forward decls from cpps to headers

This commit is contained in:
LagoLunatic
2026-04-01 19:38:51 -04:00
parent 36c9a1e4b4
commit 765f88e4f3
35 changed files with 73 additions and 79 deletions
+1 -2
View File
@@ -5,6 +5,7 @@
#include "d/dolzel.h" // IWYU pragma: keep
#include "d/actor/d_a_agb.h"
#include "d/d_msg.h"
#include "d/res/res_agb.h"
#include "JSystem/JKernel/JKRHeap.h"
#include "JSystem/JUtility/JUTAssert.h"
@@ -384,8 +385,6 @@ int daAgb_c::uploadPortCheckWait() {
return 1;
}
extern JKRHeap* dMsg_getAgbWorkArea();
/* 800CFB68-800CFC94 .text uploadSelect__7daAgb_cFv */
int daAgb_c::uploadSelect() {
if (l_msgCtrl.execute() == fopMsgStts_MSG_DISPLAYED_e) {
+1 -11
View File
@@ -13,6 +13,7 @@
#include "d/d_priority.h"
#include "d/res/res_pspl.h"
#include "m_Do/m_Do_controller_pad.h"
#include "d/d_auction_screen.h"
struct NpcDatStruct {
/* 0x00 */ f32 field_0x00;
@@ -187,17 +188,6 @@ static daAuction_c::ProcFunc_t moveProc[] = {
&daAuction_c::executeStart,
};
extern void dAuction_screen_delete();
extern void dAuction_screen_slotShow();
extern void dAuction_screen_slotHide();
extern void dAuction_screen_gaugeHide();
extern void dAuction_screen_gaugeShow();
extern void dAuction_screen_gaugeUp();
extern void dAuction_screen_gaugeDown();
extern void dAuction_screen_talkStart();
extern void dAuction_screen_talkEnd();
extern fpc_ProcID dAuction_screen_create();
/* 000000EC-000002FC .text __ct__11daAuction_cFv */
daAuction_c::daAuction_c() {
for (int i = 0; i < 8; i++) {
-2
View File
@@ -9,8 +9,6 @@
#include "d/d_priority.h"
#include "d/res/res_hi.h"
extern dCcD_SrcCyl dNpc_cyl_src;
class daNpc_Hi1_HIO_c : public mDoHIO_entry_c{
public:
struct hio_prm_c {
-2
View File
@@ -92,8 +92,6 @@ static BOOL nodeCallBack_Km(J3DNode* i_node, int i_calcTiming) {
return TRUE;
}
extern dCcD_SrcCyl dNpc_cyl_src;
/* 0000032C-0000043C .text createInit__11daNpc_Km1_cFv */
bool daNpc_Km1_c::createInit() {
mEventCut.setActorInfo2("Km1", this);
-1
View File
@@ -282,7 +282,6 @@ bool daNpc_Ls1_c::init_LS1_4() {
return init_LS1_1();
}
extern dCcD_SrcCyl dNpc_cyl_src;
/* 00000A60-00000C6C .text createInit__11daNpc_Ls1_cFv */
bool daNpc_Ls1_c::createInit() {
for (int i = 0; i < ARRAY_SSIZE(mEventIDTbl); i++) {
-2
View File
@@ -20,8 +20,6 @@
#include "f_op/f_op_actor_mng.h"
#include "m_Do/m_Do_lib.h"
extern dCcD_SrcCyl dNpc_cyl_src;
static char* l_npc_staff_id[] = {
"Uo1",
"Uo2",
-3
View File
@@ -19,11 +19,8 @@
#include "d/d_picture_box.h"
#include "d/actor/d_a_tag_photo.h"
extern dCcD_SrcCyl dNpc_cyl_src;
const char daNpcPhoto_c::m_arcname[] = "Auc";
static const char* l_arcname_tbl[] = {
"Po"
};
-2
View File
@@ -16,8 +16,6 @@
#include "d/d_a_obj.h"
#include "d/d_snap.h"
extern dCcD_SrcCyl dNpc_cyl_src;
static const char* l_arcname_tbl[] = {
"Ro",
"Ro",
-1
View File
@@ -1015,7 +1015,6 @@ static BOOL daNpc_Rsh1_checkRotenItemGet(int i_itemNo) {
return roten_item_get_check;
}
extern Vec Item_set_pos_data_rshop_0[];
/* 000023A8-00002568 .text createShopList__12daNpc_Rsh1_cFv */
void daNpc_Rsh1_c::createShopList() {
csXyz temp(0, home.angle.y, 0);
-1
View File
@@ -978,7 +978,6 @@ void daNpc_Tc_c::getArg() {
mType = TYPE_NORMAL;
}
extern dCcD_SrcCyl dNpc_cyl_src;
/* 00001C98-0000202C .text createInit__10daNpc_Tc_cFv */
void daNpc_Tc_c::createInit() {
#if VERSION > VERSION_DEMO
-3
View File
@@ -17,9 +17,6 @@
#include "d/res/res_zl.h"
#include "d/d_snap.h"
extern dCcD_SrcCyl dNpc_cyl_src;
class daNpc_Zl1_HIO_c : public mDoHIO_entry_c{
public:
struct hio_prm_c {
-2
View File
@@ -36,8 +36,6 @@ public:
/* 0x16 */ s16 field_0x16;
};
extern dScnPly_reg_HIO_c g_regHIO;
const char daObjTpost_c::m_arc_name[] = "Toripost";
const daObjTpost_c__letter_data daObjTpost_c::m_letter[] = {
-2
View File
@@ -66,8 +66,6 @@ s8 pos_around[8][2] = {
{-1, 1}, {-1, 0},
};
extern void dKy_usonami_set(f32 param_0);
/* 8015B0A4-8015B0FC .text Pos2Index__25daSea_WaterHeightInfo_MngFfPf */
int daSea_WaterHeightInfo_Mng::Pos2Index(f32 v, f32* dst) {
f32 f = 450000.0f;
+1 -2
View File
@@ -5,6 +5,7 @@
#include "d/dolzel_rel.h" // IWYU pragma: keep
#include "d/actor/d_a_tbox.h"
#include "d/d_npc.h"
#include "d/res/res_dalways.h"
#include "JSystem/JUtility/JUTAssert.h"
#include "d/d_bg_s_acch.h"
@@ -31,8 +32,6 @@
#define FUNC_TYPE_EXTRA_SAVE_INFO 7
#define FUNC_TYPE_EXTRA_SAVE_INFO_SPAWN 8
extern dCcD_SrcCyl dNpc_cyl_src;
static daTbox_HIO_c l_HIO;
static daTbox_c::modelInfo l_modelInfo[] = {