Commit Graph

40 Commits

Author SHA1 Message Date
Anthony Rossi 7bf6761243 D_a_npc_ba1 100% matching (#1144)
* Ba1 matched 100%

* last fixes

* Proper interaction with actor_fa

* Not matching 100% on JP

* Matching on JPN

* Forgot to update the configure file ...

* 100% matching

* Applied review suggestions

---------

Co-authored-by: Anthony Rossi <anthony.rossi@pm.me>
2026-08-08 15:01:29 -04:00
WilliamArnett 11f4940d74 d_a_npc_p1 100% Matching (#1098)
* 99% match

* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.

* Equivalent. Weak func ordering.

* 7% text

* 28% text

* 41% text

* 65% text

* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.

* Equivalent. Weak func ordering.

* 82% text

* Equivalent. A lot of work is needed to name variables and clean up functions. Weak function ordering is wrong.

* Cleaned some functions, named several variables, and began documenting dialog tree.

* Naming a couple more variables

* 21% text

* change out getMySubstanceP for getMyIntegerP inline

* 100% text

* Refactor to use JUT_ASSERT macro

* #181: d_a_tag_attention matching; TODO: implement chk_inside and dComIfGp_att_Look2RequestF

* #181: continue working on d_a_tag_attention, matching almost complete

* #181: revert naming class member (not certain enough)

* #181: preliminary changes to resolve #784 comments regarding usage of debug maps

* #181: commit suggestion by @WilliamArnett, fixing regalloc error

Co-authored-by: WilliamArnett <149556961+WilliamArnett@users.noreply.github.com>

* #181: fix missing curly bracket

* #181: resolve #784 comments with the kind help of @WilliamArnett;
 move `daTagAttention::Act_c::chk_inside` to header file; split `plyrToObjVec` definition to match assembly;
 remove temp variable, use values directly and swap operands;
 implement `Look2RequestF` in `include/d/d_attention.h`;
 remove non-matching use of temp variable `iVar1` and replace `current.pos` with uninitialized variable in `daTagAttention::Act_c::_execute`

* Update fork to match upstream

* some changes

* 73% text

* 100% Matching minus kaji_anm

* Delete debug/m2cdecomp

* revert unnecessary file changes

* remove d_a_npc_p2_cut.inc

* Match kaji_anm

* swap declaration order of l_msg and l_msgId

* Naming many fields

* Implement GetKajiID inline

* Enum and variable names

* Remove virtual genMessage function

* Implement @LagoLunatic 's suggested changes

* Revert array changes in d_camera.h (@LagoLunatic suggested change)

* Whitespace

* Rename dSnap enum

---------

Co-authored-by: Skelp <skelp@pm.me>
Co-authored-by: Skelp <59535863+Skelp@users.noreply.github.com>
2026-08-03 01:40:12 -04:00
LagoLunatic 0fdc3a3f3b Cleanup/documentation for various photo-related code 2026-07-19 15:54:06 -04:00
Zeclos d3d65a4d8c d_a_npc_mk matching (#1115)
* matching

* cleanup

* d_a_npc_tt matching outside of _create and rodata

* matching

* all symbols matching order wrong fake inline usage

* matching

* cleanup, naming of some fields and enums

* undo changes
2026-07-16 17:23:52 -04:00
Mattias Blum 6812d925ff d_a_npc_mt 100% for GZLE01 (#1102)
* d_a_npc_mt 100% for GZLE01

* implemented dPb_erasePicture and added some relevant inlines

* fixed existing references to mSelectPicture

* PR changes made
2026-07-05 13:49:57 -04:00
Zeclos a7a5b5d636 D_a_npc_tt (#1099)
* matching

* cleanup

* d_a_npc_tt matching outside of _create and rodata

* matching

* cleanup
2026-07-05 13:11:40 -04:00
LagoLunatic bc3b08eb4f Fix d_a_kb demo version diffs, and match a couple retail funcs 2026-06-26 19:04:31 -04:00
123456789758 ce8aa593df d_a_tn - 99% matching (#994)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2026-05-28 13:59:57 -04:00
123456789758 a70388d63f d_a_mo2 - 100% matching (#939)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2026-05-28 13:46:38 -04:00
Zeclos 56f9e016e3 D_a_npc_ho matching (#1008)
* matching

* cleanup

* tiny bit more cleanup
2026-05-17 23:33:22 -04:00
123456789758 38742c337f d_a_st - 100% matching (#1004)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2026-05-17 17:08:26 -04:00
123456789758 de122df401 d_a_bgn & d_a_bgn2 - 99% matching, d_a_bgn3 - 100% matching (#894)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2026-05-13 17:57:14 -04:00
LagoLunatic 578d45153f DSNAP enum cleanup 2026-05-10 13:11:56 -04:00
Zeclos 800f53fc2a D_a_npc_hr matching (#973)
* progress push

* matching

* documentation and cleanup

* feedback from pr review
2026-05-06 13:33:33 -04:00
Zeclos dcf4862387 D_a_npc_tc matching for retail (#930)
* progress

* code matching non-demo

* cleanup for d_a_npc_tc and d_a_obj_smplbg
2026-03-04 13:25:59 -05:00
maimai0254 6980cbaa21 d_a_bdk (#888)
* d_a_bdk - 98%

* C-style

* maybe 100%

* Resolve protected access violation

* Set configure.py to matching
2025-09-17 10:56:12 -04:00
123456789758 17d677a5ad d_a_bmd - 98% matching (#876)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2025-09-14 13:36:19 -04:00
123456789758 5fdcda6661 d_a_bwd - 98% matching (#892)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2025-09-14 13:17:50 -04:00
LagoLunatic fbb4ae9935 d_snap OK for demo 2025-08-29 19:37:12 -04:00
123456789758 52d3e87e7d d_a_btd - 99% matching (#872)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2025-08-29 17:04:11 -04:00
SuperDude88 4adfd27155 daNpc_Cb1_c Almost OK (#822)
* daNpc_Cb1_c Almost OK

Down to regswaps/minor instruction issues

* Oops

That inline was fake

* Some Cleanup

- Fill in more inlines
- Reorganize daNpc_Cb1_c inlines
- Use inlines more
- Some naming and typing consistency

* Naming, Consistency Tweaks

- TRUE/FALSE macros for all cases of BOOL, use int -> BOOL sometimes
- Rename HIO to be consistent with other NPCs
- Animation enum

* Some HIO Names

* Clarity Tweaks

- NULL in more asserts
- Squared constants
2025-07-29 21:04:42 -04:00
Ammar Askar 5c391aa7ad Fully match d_a_npc_bmsw and mark equivalent (#789)
* Match up d_a_npc_bmsw to 98%

* Remove old nonmatching comments

* Match MailCreateInit by using a static cast

* Match Throw and daNpc_Bmsw_getGameEndMsg

* Match CreateInit using demo for ref

* Fix inline for dComIfG_TimerStart

* Match shiwake_game_action

* Match getNextNo

* Mark Equivalent
2025-06-14 17:14:12 -04:00
LagoLunatic e24cbed367 Demo work (#786)
* Demo work

* Fix PAL

* Fix d_door weak func order and link it

* Fix d_door for demo

* JKernel OK on demo + misc

* tag_attention 100% on demo

* More demo work and fix some retail fakematches
2025-06-04 16:50:49 -04:00
Ammar Askar 4bf91cbfea Start matching up d_a_bst (#775)
* Start matching up d_a_bst

* Commit more progress on d_a_bst

* Match up more functions

* Match up stay function

* Remove some questionable names

* Match fly and some attack functions

* Match collider data

* Address feedback from review

* Fix no-op actor calls and match some functions better
2025-06-03 01:12:48 -04:00
123456789758 7eb543eb50 d_a_npc_fa1 - 99% matching (#780)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
2025-06-01 17:49:10 -04:00
Mattias Blum 95f230eb15 d_a_ks 100% (#746)
* initial progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* symbol cleanup

* more progress

* more progress

* d_a_ks 100%

* more symbol cleanup

* likely real-match for `useHeapInit`

* removed `csXyz` type from class member

* changed int to BOOL for `HEAVY_IN`

* documented matching issue

* PR changes
2025-05-09 15:18:16 -04:00
LagoLunatic 309158e274 J3DModel inlines cleanup, procBottleSwing_init match, etc 2025-04-10 19:30:51 -04:00
LagoLunatic 2def735282 Add fpc_ProcID type and use it for all process IDs
See https://github.com/zeldaret/tp/pull/2173
2024-07-12 21:14:13 -04:00
SuperDude88 17a7656450 Bit of Figurine Work (#665)
* Bit of Figurine Work

Not super complete, was just poking around to figure a few things out

* Fix Build

I really need to stop having this every single time
2024-07-09 20:52:54 -07:00
SuperDude88 899ae98e7d daObj_Roten_c OK, daNpcRoten_c Almost Matching (#618)
* Roten Work

- daNpcRoten_c almost matching
- daObj_Roten_c OK

I don't think these are actually related but they had the same name so I put them together

* Minor Cleanup
2024-04-24 14:28:38 -04:00
LagoLunatic ead0213a87 fix everything in d_a_npc_bs1 2024-04-02 18:40:08 -04:00
LagoLunatic c7cd6b25b2 d_a_bk 2024-03-24 15:22:02 -04:00
LagoLunatic 0dd3f6e47c Standardize process ID type to be uint 2024-03-11 19:03:47 -04:00
LagoLunatic 433fe7c486 d_a_npc_btsw2 100%, weak order not matching 2024-01-19 15:33:38 -05:00
LagoLunatic 3eae006254 d_snap OK 2024-01-06 18:48:24 -05:00
LagoLunatic b27458c909 d_snap mostly done 2024-01-06 15:16:49 -05:00
Jcw87 3e007c7ea9 Make some more TUs compile 2023-12-15 00:01:49 -08:00
Jasper St. Pierre d7ff28a6f7 dKyr_sun_move progress 2023-10-25 01:02:42 -07:00
LagoLunatic 7824fb54c0 d_a_am 50% 2023-10-03 04:14:14 -04:00
TakaRikka f1d8c41c38 work on d_s_play (#31)
* work on d_s_play

* some fixes
2023-09-14 12:45:49 -07:00