From e469b9f6ac96e2f67f14e7db9dcc2de56a6d7a55 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 6 Jun 2025 09:46:16 -0400 Subject: [PATCH 01/16] spelling: octet Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/lzf_d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lzf_d.c b/src/lzf_d.c index ff32be892..b936771d2 100644 --- a/src/lzf_d.c +++ b/src/lzf_d.c @@ -160,7 +160,7 @@ lzf_decompress (const void *const in_data, size_t in_len, } else { - /* overlapping, use octte by octte copying */ + /* overlapping, use octet by octet copying */ do *op++ = *ref++; while (--len); From 96b9d6fea8dea4fe90d42011df79382667decfc0 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Jun 2025 18:43:05 -0400 Subject: [PATCH 02/16] spelling: oom Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- tests/unit/functions.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/functions.tcl b/tests/unit/functions.tcl index 2cb2f599e..ac80de068 100644 --- a/tests/unit/functions.tcl +++ b/tests/unit/functions.tcl @@ -985,7 +985,7 @@ start_server {tags {"scripting"}} { r config set maxmemory 0 } {OK} {needs:config-maxmemory} - test {FUNCTION - verify allow-omm allows running any command} { + test {FUNCTION - verify allow-oom allows running any command} { r FUNCTION load replace {#!lua name=f1 server.register_function{ function_name='f1', From 14ed8598fff0f89f0002da9c4023d84efcaaeab1 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 6 Jun 2025 09:46:42 -0400 Subject: [PATCH 03/16] spelling: oops Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server.c b/src/server.c index 5176d3244..5f2b06631 100644 --- a/src/server.c +++ b/src/server.c @@ -4672,7 +4672,7 @@ int finishShutdown(void) { rsiptr = rdbPopulateSaveInfo(&rsi); /* Keep the page cache since it's likely to restart soon */ if (rdbSave(REPLICA_REQ_NONE, server.rdb_filename, rsiptr, RDBFLAGS_KEEP_CACHE) != C_OK) { - /* Ooops.. error saving! The best we can do is to continue + /* Oops.. error saving! The best we can do is to continue * operating. Note that if there was a background saving process, * in the next cron() the server will be notified that the background * saving aborted, handling special stuff like replicas pending for From 53244d4399bec43ed63f8057082b8190211767ee Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 4 Jun 2025 11:56:47 -0400 Subject: [PATCH 04/16] spelling: out-of-date Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- valkey.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/valkey.conf b/valkey.conf index d4b545007..40dec5c6d 100644 --- a/valkey.conf +++ b/valkey.conf @@ -664,7 +664,7 @@ dir ./ # is still in progress, the replica can act in two different ways: # # 1) if replica-serve-stale-data is set to 'yes' (the default) the replica will -# still reply to client requests, possibly with out of date data, or the +# still reply to client requests, possibly with out-of-date data, or the # data set may just be empty if this is the first synchronization. # # 2) If replica-serve-stale-data is set to 'no' the replica will reply with error From 55019e425473625f59b8c15253e6695ccc573094 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Jun 2025 18:56:13 -0400 Subject: [PATCH 05/16] spelling: outbound Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/cluster_legacy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cluster_legacy.c b/src/cluster_legacy.c index 2aa0bad0c..4c20cf321 100644 --- a/src/cluster_legacy.c +++ b/src/cluster_legacy.c @@ -5397,7 +5397,7 @@ void clusterCron(void) { di = dictGetSafeIterator(server.cluster->nodes); while ((de = dictNext(di)) != NULL) { clusterNode *node = dictGetVal(de); - /* We free the inbound or outboud link to the node if the link has an + /* We free the inbound or outbound link to the node if the link has an * oversized message send queue and immediately try reconnecting. */ clusterNodeCronFreeLinkOnBufferLimitReached(node); /* The protocol is that function(s) below return non-zero if the node was From 105997a9199c018bb30b22ea7b33cf6fd725b1e7 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Jun 2025 15:07:45 -0400 Subject: [PATCH 06/16] spelling: partial Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- tests/unit/type/stream.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/type/stream.tcl b/tests/unit/type/stream.tcl index 0c56dcd32..a52829fc3 100644 --- a/tests/unit/type/stream.tcl +++ b/tests/unit/type/stream.tcl @@ -1012,7 +1012,7 @@ start_server {tags {"stream"}} { assert_equal [dict get $reply max-deleted-entry-id] "2-0" } - test {XADD with artial ID with maximal seq} { + test {XADD with partial ID with maximal seq} { r DEL x r XADD x 1-18446744073709551615 f1 v1 assert_error {*The ID specified in XADD is equal or smaller*} {r XADD x 1-* f2 v2} From 19b04a888322c26718f3d1fe80f1485258e1c78a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Jun 2025 19:08:13 -0400 Subject: [PATCH 07/16] spelling: policy Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/functions.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/functions.c b/src/functions.c index 71a1b0070..fb4714432 100644 --- a/src/functions.c +++ b/src/functions.c @@ -729,7 +729,7 @@ void functionRestoreCommand(client *c) { return; } - restorePolicy restore_replicy = restorePolicy_Append; /* default policy: APPEND */ + restorePolicy restore_policy = restorePolicy_Append; /* default policy: APPEND */ sds data = c->argv[2]->ptr; size_t data_len = sdslen(data); rio payload; @@ -738,11 +738,11 @@ void functionRestoreCommand(client *c) { if (c->argc == 4) { const char *restore_policy_str = c->argv[3]->ptr; if (!strcasecmp(restore_policy_str, "append")) { - restore_replicy = restorePolicy_Append; + restore_policy = restorePolicy_Append; } else if (!strcasecmp(restore_policy_str, "replace")) { - restore_replicy = restorePolicy_Replace; + restore_policy = restorePolicy_Replace; } else if (!strcasecmp(restore_policy_str, "flush")) { - restore_replicy = restorePolicy_Flush; + restore_policy = restorePolicy_Flush; } else { addReplyError(c, "Wrong restore policy given, value should be either FLUSH, APPEND or REPLACE."); return; @@ -781,11 +781,11 @@ void functionRestoreCommand(client *c) { } } - if (restore_replicy == restorePolicy_Flush) { + if (restore_policy == restorePolicy_Flush) { functionsLibCtxSwapWithCurrent(functions_lib_ctx, server.lazyfree_lazy_user_flush); functions_lib_ctx = NULL; /* avoid releasing the f_ctx in the end */ } else { - if (libraryJoin(curr_functions_lib_ctx, functions_lib_ctx, restore_replicy == restorePolicy_Replace, &err) != + if (libraryJoin(curr_functions_lib_ctx, functions_lib_ctx, restore_policy == restorePolicy_Replace, &err) != C_OK) { goto load_error; } From 952beb8ebefbfc134eeb1d6c0b882c5fc0dc2e23 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Jun 2025 18:57:54 -0400 Subject: [PATCH 08/16] spelling: polygon Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/geohash_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/geohash_helper.c b/src/geohash_helper.c index caa1c3811..8a9996b82 100644 --- a/src/geohash_helper.c +++ b/src/geohash_helper.c @@ -349,7 +349,7 @@ int geohashGetDistanceIfInRectangle(double width_m, * The Polygon's centroid's lon lat coordinates are `centroidLon` and `centroidLat`. * The algorithm is based on PNPOLY - Point Inclusion in Polygon Test by W. Randolph Franklin (WRF). * See: https://wrfranklin.org/Research/Short_Notes/pnpoly.html - * Returns 1 if inside the polyon and returns 0 otherwise. */ + * Returns 1 if inside the polygon and returns 0 otherwise. */ int geohashGetDistanceIfInPolygon(double centroidLon, double centroidLat, double *point, double (*vertices)[2], int num_vertices, double *distance) { int i, j; int inside = 0; From f17be0113ed17759004c777ae67cf88746f48ac2 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Jun 2025 18:58:12 -0400 Subject: [PATCH 09/16] spelling: preamble Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/valkey-check-aof.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/valkey-check-aof.c b/src/valkey-check-aof.c index a6e4b97c6..5839bcb34 100644 --- a/src/valkey-check-aof.c +++ b/src/valkey-check-aof.c @@ -477,10 +477,10 @@ void checkMultiPartAof(char *dirpath, char *manifest_filepath, int fix) { sds aof_filename = am->base_aof_info->file_name; sds aof_filepath = makePath(dirpath, aof_filename); last_file = ++aof_num == total_num; - int aof_preable = fileIsRDB(aof_filepath); + int aof_preamble = fileIsRDB(aof_filepath); - printf("Start to check BASE AOF (%s format).\n", aof_preable ? "RDB" : "RESP"); - ret = checkSingleAof(aof_filename, aof_filepath, last_file, fix, aof_preable); + printf("Start to check BASE AOF (%s format).\n", aof_preamble ? "RDB" : "RESP"); + ret = checkSingleAof(aof_filename, aof_filepath, last_file, fix, aof_preamble); printAofStyle(ret, aof_filename, (char *)"BASE AOF"); sdsfree(aof_filepath); } From 945610fc0751fef67d56cd5c35f5004e7bdc3d3b Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 4 Jun 2025 11:52:32 -0400 Subject: [PATCH 10/16] spelling: preexisting Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/cluster_legacy.c | 2 +- src/quicklist.c | 2 +- src/rax.c | 2 +- src/rio.c | 4 ++-- src/t_stream.c | 2 +- tests/unit/type/stream-cgroups.tcl | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/cluster_legacy.c b/src/cluster_legacy.c index 4c20cf321..fd965896a 100644 --- a/src/cluster_legacy.c +++ b/src/cluster_legacy.c @@ -827,7 +827,7 @@ fmterr: * of the POSIX filesystem semantics, so that if the server is stopped * or crashes during the write, we'll end with either the old file or the * new one. Since we have the full payload to write available we can use - * a single write to write the whole file. If the pre-existing file was + * a single write to write the whole file. If the preexisting file was * bigger we pad our payload with newlines that are anyway ignored and truncate * the file afterward. */ int clusterSaveConfig(int do_fsync) { diff --git a/src/quicklist.c b/src/quicklist.c index f5e09aee0..e5e5b68d2 100644 --- a/src/quicklist.c +++ b/src/quicklist.c @@ -1468,7 +1468,7 @@ void quicklistRotate(quicklist *quicklist) { /* If quicklist has only one node, the head listpack is also the * tail listpack and PushHead() could have reallocated our single listpack, - * which would make our pre-existing 'p' unusable. */ + * which would make our preexisting 'p' unusable. */ if (quicklist->len == 1) { p = lpSeek(quicklist->tail->entry, -1); } diff --git a/src/rax.c b/src/rax.c index dc22cc589..6691fe4ec 100644 --- a/src/rax.c +++ b/src/rax.c @@ -335,7 +335,7 @@ raxNode *raxAddChild(raxNode *n, unsigned char c, raxNode **childptr, raxNode ** /* Move the pointers to the left of the insertion position as well. Often * we don't need to do anything if there was already some padding to use. In * that case the final destination of the pointers will be the same, however - * in our example there was no pre-existing padding, so we added one byte + * in our example there was no preexisting padding, so we added one byte * plus three bytes of padding. After the next memmove() things will look * like that: * diff --git a/src/rio.c b/src/rio.c index b0142672c..b7c352059 100644 --- a/src/rio.c +++ b/src/rio.c @@ -335,10 +335,10 @@ static size_t rioFdWrite(rio *r, const void *buf, size_t len) { /* For small writes, we rather keep the data in user-space buffer, and flush * it only when it grows. however for larger writes, we prefer to flush - * any pre-existing buffer, and write the new one directly without reallocs + * any preexisting buffer, and write the new one directly without reallocs * and memory copying. */ if (len > PROTO_IOBUF_LEN) { - /* First, flush any pre-existing buffered data. */ + /* First, flush any preexisting buffered data. */ if (sdslen(r->io.fd.buf)) { if (rioFdWrite(r, NULL, 0) == 0) return 0; } diff --git a/src/t_stream.c b/src/t_stream.c index 0777913f4..3580ec514 100644 --- a/src/t_stream.c +++ b/src/t_stream.c @@ -3238,7 +3238,7 @@ void xclaimCommand(client *c) { * by the caller is satisfied by this entry. * * Note that the nack could be created by FORCE, in this - * case there was no pre-existing entry and minidle should + * case there was no preexisting entry and minidle should * be ignored, but in that case nack->consumer is NULL. */ if (nack->consumer && minidle) { mstime_t this_idle = now - nack->delivery_time; diff --git a/tests/unit/type/stream-cgroups.tcl b/tests/unit/type/stream-cgroups.tcl index fe61d5de6..047defecf 100644 --- a/tests/unit/type/stream-cgroups.tcl +++ b/tests/unit/type/stream-cgroups.tcl @@ -47,7 +47,7 @@ start_server { r XADD mystream * a 1 r XADD mystream * b 2 # XREADGROUP should return only the new elements "a 1" "b 1" - # and not the element "foo bar" which was pre existing in the + # and not the element "foo bar" which was preexisting in the # stream (see previous test) set reply [ r XREADGROUP GROUP mygroup consumer-1 STREAMS mystream ">" From b11ca9018b49ff5e852c2f5c64dc3ea755f70ee7 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Jun 2025 18:58:23 -0400 Subject: [PATCH 11/16] spelling: previously Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/module.c b/src/module.c index 3569ae821..99c02f219 100644 --- a/src/module.c +++ b/src/module.c @@ -8187,7 +8187,7 @@ ValkeyModuleBlockedClient *VM_BlockClientOnAuth(ValkeyModuleCtx *ctx, return bc; } -/* Get the private data that was previusely set on a blocked client */ +/* Get the private data that was previously set on a blocked client */ void *VM_BlockClientGetPrivateData(ValkeyModuleBlockedClient *blocked_client) { return blocked_client->privdata; } From c54858a3374c1b937abb6ad1f1f76bd92162ccc7 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 4 Jun 2025 20:43:26 -0400 Subject: [PATCH 12/16] spelling: problem Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- tests/instances.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/instances.tcl b/tests/instances.tcl index 4bd68c453..3e1062fc2 100644 --- a/tests/instances.tcl +++ b/tests/instances.tcl @@ -166,7 +166,7 @@ proc spawn_instance {type base_port count {conf {}} {base_conf_file ""}} { if {[server_is_up $::host $port 100] == 0} { set logfile [file join $dirname log.txt] puts [exec tail $logfile] - abort_sentinel_test "Problems starting $type #$j: ping timeout, maybe server start failed, check $logfile" + abort_sentinel_test "Problem starting $type #$j: ping timeout, maybe server start failed, check $logfile" } # Push the instance into the right list From b94bbd2ab766aae5e47d699ee84fc6dc4f40f3f9 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 6 Jun 2025 07:20:35 -0400 Subject: [PATCH 13/16] spelling: reachable Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- tests/cluster/cluster.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cluster/cluster.tcl b/tests/cluster/cluster.tcl index 783465875..7527b453e 100644 --- a/tests/cluster/cluster.tcl +++ b/tests/cluster/cluster.tcl @@ -159,7 +159,7 @@ proc cluster_create_with_continuous_slots {masters slaves} { } -# Set the cluster node-timeout to all the reachalbe nodes. +# Set the cluster node-timeout to all the reachable nodes. proc set_cluster_node_timeout {to} { foreach_valkey_id id { catch {R $id CONFIG SET cluster-node-timeout $to} From d24bb8379dbe989f2905d55818c6d2057cd8b127 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 6 Jun 2025 07:22:00 -0400 Subject: [PATCH 14/16] spelling: redirection Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- tests/unit/tracking.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/tracking.tcl b/tests/unit/tracking.tcl index ec9368b4f..c1bc6c87f 100644 --- a/tests/unit/tracking.tcl +++ b/tests/unit/tracking.tcl @@ -237,7 +237,7 @@ start_server {tags {"tracking network logreqres:skip"}} { assert_equal "PONG" [r ping] } - test {RESP3 Client gets tracking-redir-broken push message after cached key changed when rediretion client is terminated} { + test {RESP3 Client gets tracking-redir-broken push message after cached key changed when redirection client is terminated} { # make sure r is working resp 3 r HELLO 3 r CLIENT TRACKING on REDIRECT $redir_id From 745e8502e2dd665b48b9d2abb604f625c0057afe Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Jun 2025 19:00:40 -0400 Subject: [PATCH 15/16] spelling: rehashing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/unit/test_rax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/unit/test_rax.c b/src/unit/test_rax.c index b4e5a0e8f..754240200 100644 --- a/src/unit/test_rax.c +++ b/src/unit/test_rax.c @@ -47,7 +47,7 @@ long long _ustime(void); /* From test_crc64combine.c */ * used in order to test the radix tree implementation against something that * will always "tell the truth" :-) */ -/* This is huge but we want it fast enough without reahshing needed. */ +/* This is huge but we want it fast enough without rehashing needed. */ #define HT_TABLE_SIZE 100000 typedef struct htNode { uint64_t keylen; From 79f2ab98f3f79229fcac0f8b2e7ef139ccbfdb84 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Jun 2025 19:02:55 -0400 Subject: [PATCH 16/16] spelling: remaining Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/commands/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/commands/README.md b/src/commands/README.md index 27bcef50a..6b1027b90 100644 --- a/src/commands/README.md +++ b/src/commands/README.md @@ -185,7 +185,7 @@ Each element in this array is an object with the following keys: command line. The first key is the argument after the keyword. * `{"unknown": null}`: Finding the keys of this command is too complicated to explain. -* `"find_keys"`: How to find the remainnig keys of this key spec. It's an object +* `"find_keys"`: How to find the remaining keys of this key spec. It's an object on one of these forms: * `{"range": {"lastkey": LAST, "step": STEP, "limit": LIMIT}}`: A range of keys. * LAST: If LAST is positive, it's the index of the last key relative to the