mirror
/
valkey
mirror of https://github.com/valkey-io/valkey
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Test Fix] flaky benchmark test for warmup (#2890) 

Fixes: https://github.com/valkey-io/valkey/issues/2859
Increased the warmup to 2 sec so we can verify that it runs more number
of commands than the actual benchmark.

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
This commit is contained in:
Roshan Khatri 2025-12-02 12:40:20 -08:00 committed by GitHub
parent 1b5f245eae
commit 2e8fba49a2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/integration/valkey-benchmark.tcl
View File

@ -248,13 +248,13 @@ tags {"benchmark network external:skip logreqres:skip"} {
test {benchmark: warmup applies to all tests in multi-test run} {
set start_time [clock clicks -millisec]
set cmd [valkeybenchmark $master_host $master_port "-r 5 --warmup 1 -n 50 -t set,get,incr"]
set cmd [valkeybenchmark $master_host $master_port "-r 5 --warmup 2 -n 50 -t set,get,incr"]
set output [common_bench_setup $cmd]
set end_time [clock clicks -millisec]
# Verify total duration includes warmup for all 3 tests (at least 3 seconds)
# Verify total duration includes warmup for all 3 tests (at least 6 seconds)
set elapsed [expr {($end_time - $start_time)/1000.0}]
assert {$elapsed >= 3}
assert {$elapsed >= 6}
# Verify all tests ran - with warmup, we expect more than 50 calls per command
# since warmup commands are also counted in server stats