mirror
/
valkey
mirror of https://github.com/valkey-io/valkey
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove the EXAT and PXAT from some HFE notifications tests (#2831) 

As we can see, we expected to get hexpired, but we got hexpire instead,
this means tht the expiration time has expired during execution.
```
*** [err]: HGETEX EXAT keyspace notifications for active expiry in tests/unit/hashexpire.tcl
Expected 'pmessage __keyevent@* __keyevent@9__:hexpired myhash' to match 'pmessage __keyevent@* __keyevent@*:hexpire myhash'
```

We should remove the EXAT and PXAT from these fixtures. And we indeed
have
the dedicated tests that verify that we get 'expired' when EX,PX are set
to 0
or EXAT,PXAT are in the past.

Signed-off-by: Binbin <binloveplay1314@qq.com>
This commit is contained in:
Binbin 2025-11-12 20:32:13 +08:00 committed by GitHub
parent 1b0b5c0cfd
commit 7ffe4dcec4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit/hashexpire.tcl
View File

@ -2993,7 +2993,7 @@ start_server {tags {"hashexpire external:skip"}} {
}
##### HGETEX Active Expiry Keyspace Notifications #####
foreach command {EX PX EXAT PXAT} {
foreach command {EX PX} {
test "HGETEX $command keyspace notifications for active expiry" {
r FLUSHALL
set initial_expired [info_field [r info stats] expired_fields]
@ -3014,7 +3014,7 @@ start_server {tags {"hashexpire external:skip"}} {
$rd close
}
}
test "HGETEX keyspace notification when key deleted with active expiry" {
r FLUSHALL
set initial_expired [info_field [r info stats] expired_fields]
@ -3115,7 +3115,7 @@ start_server {tags {"hashexpire external:skip"}} {
}
##### HSETEX Active Expiry Keyspace Notifications #####
foreach command {EX PX EXAT PXAT} {
foreach command {EX PX} {
test "HSETEX $command - keyspace notifications fired on field expiry" {
r FLUSHALL
set initial_expired [info_field [r info stats] expired_fields]