mirror
/
valkey
mirror of https://github.com/valkey-io/valkey
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

deflake "Hash field TTL and active expiry propagates correctly" (#2856) 

Fix a little miss in "Hash field TTL and active expiry propagates
correctly through chain replication" test in `hashexpire.tcl`.
The test did not wait for the initial sync of the chained replica and thus  made the test flakey

Signed-off-by: Arad Zilberstein <aradz@amazon.com>
This commit is contained in:
aradz44 2025-11-19 11:33:55 +02:00 committed by GitHub
parent 3c3a1966ec
commit e19ceb7a6d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit/hashexpire.tcl
View File

@ -4042,7 +4042,7 @@ start_server {tags {"hashexpire external:skip"}} {
test {Hash field TTL and active expiry propagates correctly through chain replication} { test {Hash field TTL and active expiry propagates correctly through chain replication} {
$replica replicaof $primary_host $primary_port $replica replicaof $primary_host $primary_port
# Wait for R2 to connect to R1 # Wait for R1 to connect to Primary
wait_for_condition 100 100 { wait_for_condition 100 100 {
[info_field [$replica info replication] master_link_status] eq "up" [info_field [$replica info replication] master_link_status] eq "up"
} else { } else {
@ -4052,7 +4052,7 @@ start_server {tags {"hashexpire external:skip"}} {
$replica_2 replicaof $replica_host $replica_port $replica_2 replicaof $replica_host $replica_port
# Wait for R2 to connect to R1 # Wait for R2 to connect to R1
wait_for_condition 100 100 { wait_for_condition 100 100 {
[info_field [$replica info replication] master_link_status] eq "up" [info_field [$replica_2 info replication] master_link_status] eq "up"
} else { } else {
fail "Second replica <-> First replica connection not established" fail "Second replica <-> First replica connection not established"
} }