mirror
/
valkey
mirror of https://github.com/valkey-io/valkey
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix cluster test module to pass null terminated node-id to SendClusterMessage (#2484) 

Fix https://github.com/valkey-io/valkey/issues/2438

Modified `DingReceiver` function in `tests/modules/cluster.c` by adding
null-termination logic for cross-version compatibility

---------

Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
This commit is contained in:
Hanxi Zhang 2025-08-15 11:40:34 -07:00 committed by GitHub
parent e7bb2354da
commit f36cc20836
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/modules/cluster.c
View File

@ -1,4 +1,5 @@
#include "valkeymodule.h"
#include <string.h>
#define UNUSED(x) (void)(x)
@ -48,7 +49,11 @@ int PingallCommand(ValkeyModuleCtx *ctx, ValkeyModuleString **argv, int argc) {
void DingReceiver(ValkeyModuleCtx *ctx, const char *sender_id, uint8_t type, const unsigned char *payload, uint32_t len) {
ValkeyModule_Log(ctx, "notice", "DING (type %d) RECEIVED from %.*s: '%.*s'", type, VALKEYMODULE_NODE_ID_LEN, sender_id, (int)len, payload);
ValkeyModule_SendClusterMessage(ctx, sender_id, MSGTYPE_DONG, "Message Received!", 17);
/* Ensure sender_id is null-terminated for cross-version compatibility */
char null_terminated_sender_id[VALKEYMODULE_NODE_ID_LEN + 1];
memcpy(null_terminated_sender_id, sender_id, VALKEYMODULE_NODE_ID_LEN);
null_terminated_sender_id[VALKEYMODULE_NODE_ID_LEN] = '\0';
ValkeyModule_SendClusterMessage(ctx, null_terminated_sender_id, MSGTYPE_DONG, "Message Received!", 17);
}
void DongReceiver(ValkeyModuleCtx *ctx, const char *sender_id, uint8_t type, const unsigned char *payload, uint32_t len) {