Commit Graph

17 Commits

Author SHA1 Message Date
PikalaxALT 634df27635 Merge branch 'master' into build_more_roms 2018-06-03 11:04:06 -04:00
Rangi 20ac549a91 Copy pokecrystal's conventions for this data, including:
- Tabs for indentation, spaces for alignment
- Consistent comments and formatting for menu header data (incomplete here, until the related code is disassembled)
- The second two menus do not "take priority"; they're all just a count + that many items + ending -1
2018-06-03 10:55:41 -04:00
mid-kid ec704bfa38 Fix main menu items position 2018-06-03 14:40:54 +02:00
TeganGibby c9274c2e55 comments to explain duplicates 2018-06-02 21:34:06 -07:00
TeganGibby fd33b64f69 added detail on main menu functions 2018-06-02 21:04:31 -07:00
TeganGibby 0ce725cb1c additional documentation
Compared to retail Gold disassembly
2018-06-02 20:46:45 -07:00
PikalaxALT 8787aac995 Merge branch 'master' into build_more_roms 2018-06-02 22:57:52 -04:00
Tauwasser e51ea1412c engine: begin disassembling overworld code
Right now it's only code that calls the start and debug menus
as well as the select button.

Signed-off-by: Tauwasser <Tauwasser@tauwasser.eu>
2018-06-03 04:51:38 +02:00
Tauwasser b0cb7a159d gfx: re-organize some graphics and disassemble gfx load code
All graphics were split so that proper labels could be placed.
Font was not split, because that was nicely handled using the
charmap constants.

If proper lengths should also be handled using automatic calculation
using labels, some graphics would need further splitting up
in order to place labels.s

Signed-off-by: Tauwasser <Tauwasser@tauwasser.eu>
2018-06-03 04:21:48 +02:00
PikalaxALT 04883f4bf9 Merge branch 'master' into build_more_roms 2018-06-02 21:26:20 -04:00
PikalaxALT 956d010d59 Make the repository build all four ROMs 2018-06-02 20:16:37 -04:00
Rangi c8e9901947 Code conventions:
- Lowercase hex literals
- Lowercase rgbasm keywords (rept, endr)
- Use decimal literals by default, binary when bits are meaningful; hex indicates that it needs further review, e.g. to define a constant
- Tabs, not spaces
- Newline at end of file (rgbds sometimes complains otherwise)
- Doc comments underneath function names
2018-06-01 13:24:42 -04:00
Rangi 26646f96ea Some landmark name routines 2018-06-01 01:08:22 -04:00
pfero cd9191b074 Clean up Makefile
This makefile can now figure graphics dependencies on its own, creates
dependency files for each compilation unit and compiles everything
separately.

This is a proposal. Please try it out, read the Makefile to see if you
get what I'm trying to do, and propose any improvements you want.
2018-05-30 22:53:59 +02:00
Rangi 2f65c68550 Small temporary SECTION headers go in main.asm, so the individual files won't all need fixing later 2018-05-29 19:06:23 -04:00
ISSOtm e6c75f2d84 Fix disassembling mistakes 2018-05-29 16:43:04 +02:00
ISSOtm 39a6615bcb Disassemble a lil' bit 2018-05-28 14:02:22 +02:00