pret/pokegold
1
0
Fork 0
mirror of https://github.com/pret/pokegold.git synced 2026-10-01 06:20:34 -04:00
Code Issues Packages Projects Releases Wiki Activity
1,025 Commits 2 Branches 0 Tags
master
Commit Graph

181 Commits

Author SHA1 Message Date
Rangi d2c9e2d74f Use features of RGBDS 1.0.0 (#138) 2025-11-12 15:44:00 -05:00
Rangi42 b03ba1a549 Update hardware.inc to 5.1.0 2025-06-30 12:47:34 -04:00
Rangi f57be98873 Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#130) 2025-06-23 09:11:35 -04:00
Rangi42 4be4d4708e Define constants for wBillsPCPokemonList entries 2025-05-31 15:17:06 -04:00
Rangi42 a7fb4e069e Sync further with pokecrystal 2025-03-15 01:03:21 -04:00
Rangi42 bd94c01a44 Verify the trade dialog pointer table length 2025-03-15 00:49:22 -04:00
Rangi42 2571edf37b Avoid using EQUS when EQU or MACRO will do 2025-03-14 21:38:49 -04:00
Rangi 3affb23969 Don't pass redundant label names to table_width and list_start (#126) 2024-12-27 12:35:41 -05:00
Sylvie 201d12d44e Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F (#123) 2024-11-30 17:25:26 -05:00
Rangi42 3257bc1924 Add documentation for HideHeadbuttTree 2024-11-28 22:03:14 -05:00
Sylvie 7ebc4324db Identify more bit flags (#120) 2024-11-28 14:50:00 -05:00
Rangi42 b1e3ef3b45 Update mislabeled sweet_scent.asm subroutine 2024-10-17 17:20:57 -04:00
Rangi42 fe8254c900 Rename dt and dd to bigdt and bigdd 
This makes their big-endianness obvious and matches `dw`
 2024-10-17 14:56:47 -04:00
Sylvie 98d728262f Identify various "????"s (#116) 2024-06-11 20:54:43 -04:00
Rangi42 1675a00a42 Use constants for VBlank handlers 2024-05-22 21:02:56 -04:00
SnorlaxMonster 144133d98e Rename MON_ID to MON_OT_ID (pret/pokecrystal#1114) 
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2024-04-27 12:21:32 -05:00
xCrystal 257d56018d Address PR suggestions (#1078) 2024-01-30 00:42:08 +01:00
xCrystal df10c9ea1a Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-30 00:41:51 +01:00
xCrystal 59642837e9 more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-30 00:41:00 +01:00
xCrystal f035cd599c Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-30 00:35:14 +01:00
xCrystal 10d38669b0 In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-30 00:31:05 +01:00
xCrystal aac0d97362 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
 2024-01-30 00:27:27 +01:00
xCrystal c0812ca008 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
 2024-01-30 00:26:13 +01:00
vulcandth 70f883dc86 Sync sprite and battle anim consts/labels (pret/pokecrystal#1055) 
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
 2023-09-17 14:48:08 -05:00
Idain 63d552f6e5 Replace magic numbers with TILE_WIDTH (pret/pokecrystal#1056) 
* Replace magic numbers with TILE_WIDTH

* Address more instances
 2023-07-27 10:51:54 -05:00
Idain be7c950f05 Use NO_INPUT instead of magic number (pret/pokecrystal#1051) 
This is for the Virtual Console builds, where it disables the print functions of Unown and Mail.
 2023-05-28 09:17:03 -05:00
Idain c9a8d2f5cf Replace hardcoded wMonType constants (#1011) 2022-09-28 19:52:27 -05:00
Rangi bdb6ae85e0 Rename the object_struct field labels and constants (#105) 2022-09-12 09:15:49 -04:00
Rangi 0bccfa1cd1 Use for loops to generate box pointer tables 2022-09-10 13:58:48 -04:00
vulcandth 9c9744ea78 Document surfing on top of NPCs 2022-08-31 18:25:26 -05:00
vulcandth 7da3a68695 Add Bug comment for fishing/surfing on NPCs 2022-08-31 00:47:05 -05:00
Rangi 902445d353 Refer to "Rival", not "Silver" (#103) 
See https://github.com/pret/pokecrystal/pull/983
 2022-08-10 21:24:58 -04:00
Rangi d4362cad05 Fix some whitespace 2022-08-07 00:38:04 -04:00
Rangi 2d7f97e52f Define scene constants alongside scene_scripts (#101) 
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
 2022-07-29 17:43:12 -04:00
Colton G. Rushton 99fd84eba6 wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#99) 2022-07-09 17:18:21 -04:00
vulcandth 4c95a9a708 Clean up bugs commented in the source code (#89) 
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-07-09 16:12:32 -05:00
vulcandth 357a90f08f Remove redundant comments referencing labels (#85) 2022-06-06 17:34:51 -04:00
vulcandth 464c67ee73 RGBDS syntax updates (#78) 
New MACRO and DEF syntax
 2022-06-06 17:25:39 -04:00
vulcandth 2bab8a2946 Improved Virtual Console patch identifiers (#79) 2022-06-06 17:22:43 -04:00
vulcandth 3d58fb9556 Build the Virtual Console patches with make gold_vc and make silver_vc (#74) 2022-03-14 17:03:15 -04:00
Rangi b74d56462c Clear however many bytes are needed for wFruitTreeFlags 2022-02-14 17:28:05 -05:00
Rangi 697093f787 Identify some overworld movement data 2021-12-22 21:38:24 -05:00
Rangi 14a21880a0 Use ~X instead of $ff ^ X 2021-11-23 20:50:17 -05:00
Rangi 3eda24dc47 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:07 -04:00
TheFakeMateo a9dd70cc35 Fix incorrectly swapped constants in Players PC 2021-06-08 22:43:52 -06:00
Rangi 40dbe0df04 Use rgbds 0.5.0 2021-04-20 21:17:09 -04:00
Rangi aa3a3224c6 Use numeric constants in text strings with "{d:interpolation}" 2021-03-21 18:14:36 -04:00
Rangi 381a4b443b Assert the sBox1-14 tables have NUM_BOXES entries 2021-03-21 17:47:50 -04:00
Rangi afd42efb60 Consistent labels for each nickname in RAM 2021-03-17 16:38:30 -04:00
Rangi d1167570cc Assert some more table widths 2021-03-17 11:37:55 -04:00