Narishma-gb
62388c7204
Update some URLs, add a few constants ( #152 )
2026-09-29 10:55:54 -04:00
Rangi
d2c9e2d74f
Use features of RGBDS 1.0.0 ( #138 )
2025-11-12 15:44:00 -05:00
Rangi42
33df401392
Identify JOYP_SGB_MLT_REQ constant
2025-08-11 16:36:33 -04:00
Rangi42
a17b2c580e
Update hardware.inc to 5.3.0 and use its new constants
2025-08-11 15:56:17 -04:00
Rangi
f57be98873
Replace hardware_constants.asm with the community-standard hardware.inc 5.0 ( #130 )
2025-06-23 09:11:35 -04:00
Rangi42
81a1dc3e18
Use SIZEOF/STARTOF from RGBDS 0.7.0
2025-03-15 00:39:08 -04:00
Rangi42
44226aa43d
Add assert to note _CGB_Diploma also loads PartyMenuOBPals
2025-03-14 21:31:52 -04:00
Rangi
3affb23969
Don't pass redundant label names to table_width and list_start ( #126 )
2024-12-27 12:35:41 -05:00
xCrystal
c0812ca008
Improve some innacurate function names, labels, and comments ( #1078 )
...
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371 ]
2024-01-30 00:26:13 +01:00
Idain
859b45abcf
Improve use of palette macro and use PAL_* constants ( pret/pokecrystal#1087 )
...
* Improve use of palette macro and use PAL_* constants
* Use proper constant for battle stats (#1088 )
* Add suggestions about function names and variables
* Add colors macro
---------
Co-authored-by: vulcandth <vulcandth@gmail.com >
2023-11-17 18:27:43 +00:00
vulcandth
70f883dc86
Sync sprite and battle anim consts/labels ( pret/pokecrystal#1055 )
...
* Sync sprite and battle anim consts/labels
* Add `; 00` comments
* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
2023-09-17 14:48:08 -05:00
Idain
63d552f6e5
Replace magic numbers with TILE_WIDTH ( pret/pokecrystal#1056 )
...
* Replace magic numbers with TILE_WIDTH
* Address more instances
2023-07-27 10:51:54 -05:00
Rangi
16d88ae356
Revise constants in CheckShininess
2022-10-12 21:41:07 -04:00
Rangi
659e083376
Move non-Pokémon graphics out of gfx/icons
2022-08-17 17:45:28 -04:00
Colton G. Rushton
99fd84eba6
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM ( #99 )
2022-07-09 17:18:21 -04:00
Rangi
09672ef3d6
Split "gfx anims" into "pic anims" and "sprite anims"
2022-07-04 01:11:41 -04:00
vulcandth
464c67ee73
RGBDS syntax updates ( #78 )
...
New MACRO and DEF syntax
2022-06-06 17:25:39 -04:00
vulcandth
2bab8a2946
Improved Virtual Console patch identifiers ( #79 )
2022-06-06 17:22:43 -04:00
vulcandth
3d58fb9556
Build the Virtual Console patches with make gold_vc and make silver_vc ( #74 )
2022-03-14 17:03:15 -04:00
Rangi
14a21880a0
Use ~X instead of $ff ^ X
2021-11-23 20:50:17 -05:00
Rangi
05130829f9
Add assertions to some more tables
2021-10-24 18:28:38 -04:00
Rangi
24eafe25aa
Add assert PokemonPicPointers == UnownPicPointers in GetFrontpic
2021-10-06 17:44:37 -04:00
Rangi
c91db56f42
Identify more palettes in CBG layouts
2021-07-19 18:59:11 -04:00
Rangi
3eda24dc47
Standardize capitalization of ".Jumptable"
2021-06-19 19:52:07 -04:00
Rangi
2bc8cf5fc1
Revise some constant definitions
2021-03-16 18:08:25 -04:00
Rangi
5454e1e0de
Verify data table sizes with table_width and assert_table_length macros
...
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants.
2021-03-05 16:10:25 -05:00
Rangi
51aa06097f
Rename GetFarHalfword to GetFarWord
2021-01-09 15:16:20 -05:00
Rangi
ed133f5c9a
Remove "Buffer" suffix from two HRAM labels
2020-12-23 16:54:26 -05:00
Rangi
bc8636d688
Replace $0 with 0 for "ld l, a / ld h, 0" idiom
2020-11-09 15:20:35 -05:00
Rangi
dbcab434fb
Rename "dummy game" to "memory game"
2020-11-08 19:32:52 -05:00
Rangi
c9bf53310f
Identify an unused intro sprite animation from pokegold-spaceworld
2020-11-02 09:30:29 -05:00
Rangi
eecff60284
UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims
2020-10-30 17:32:04 -04:00
Rangi
542f02c181
Extract more RGB data to .pal files
2020-10-30 16:12:20 -04:00
Rangi
6063bd1dfb
Identify wSpriteAnimDict key constants
2020-10-30 15:38:56 -04:00
Rangi
3737ca4017
Sync Mystery Gift labels with pokecrystal
2020-10-30 10:45:33 -04:00
Rangi
b47bfbd813
Identify more WRAM labels, and start a <X>_DummyFunction label convention
2020-10-28 14:39:52 -04:00
Rangi
676f2f12e3
Use more assertions to ensure correct code and data
2020-10-26 22:24:47 -04:00
Rangi
46f6cc4d41
Comment, remove, or revise many unreferenced labels
2020-10-26 20:30:09 -04:00
Rangi
26ddba8cfd
Identify some more labels, mostly WRAM
2020-10-23 16:04:03 -04:00
Rangi
07f670f956
Identify more sprite graphics and map object labels, and have consistent anonymous jumptable labels
2020-10-22 10:54:45 -04:00
Rangi
10151dd4eb
Identify some more unnamed labels
2020-10-05 20:09:52 -04:00
Rangi
8871f4b611
Identify more unnamed labels
2020-10-05 16:15:47 -04:00
Rangi
3745ba9f9e
Identify more unnamed labels
2020-10-04 22:34:55 -04:00
Rangi
e128fbeadb
Identify some more unnamed labels
2020-10-04 20:10:31 -04:00
Rangi
8443840f97
Identify SGB blk/pal packets
2020-10-04 18:32:28 -04:00
mid-kid
aa04a13578
GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE
...
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
2020-08-27 15:17:53 +02:00
mid-kid
0a1eb668d0
Fix some constants surrounding sprite animations
...
Also commented the use of the field surrounding the struct
initialization functions.
SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4
BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 14:51:59 +02:00
mid-kid
a7c294371c
Port splash screen documentation changes from Crystal
...
Since the splash screen is wildly different, a lot of the docs don't
really apply here.
2020-08-27 14:40:18 +02:00
mid-kid
a51c15a7ef
Remove a verifiably false comment
...
wSpriteAnimCount starts at 0, keeps incrementing and never decrements.
When it reaches $ff, the next value is 1.
Its purpose is unknown, as this value is used nowhere else.
2020-08-05 17:34:49 +02:00
mid-kid
f1075b1a9d
d is the multiplier for Sprites_Sine
2020-08-05 17:34:39 +02:00