72 Commits

Author SHA1 Message Date
Narishma-gb a0dad0957a Update link.asm and WRAM link transfer related symbols (#141) 2026-08-06 17:08:46 -04:00
mid-kid 09d2148d6d Use separate constants for wChosenCableClubRoom (#144)
These numbers aren't related to the LINK_ values at all, it's just a
coincidence.

Changing these is an easy way for games to force incompatibility with
the original game.
2026-02-08 13:47:25 -05:00
Rangi d2c9e2d74f Use features of RGBDS 1.0.0 (#138) 2025-11-12 15:44:00 -05:00
Rangi42 a17b2c580e Update hardware.inc to 5.3.0 and use its new constants 2025-08-11 15:56:17 -04:00
Rangi42 b03ba1a549 Update hardware.inc to 5.1.0 2025-06-30 12:47:34 -04:00
Rangi f57be98873 Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#130) 2025-06-23 09:11:35 -04:00
Sylvie 7ebc4324db Identify more bit flags (#120) 2024-11-28 14:50:00 -05:00
Sylvie 98d728262f Identify various "????"s (#116) 2024-06-11 20:54:43 -04:00
Rangi42 1675a00a42 Use constants for VBlank handlers 2024-05-22 21:02:56 -04:00
Idain a62dfe8548 Add more assert cases in the codebase (pret/pokecrystal#1115)
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
2024-04-27 12:23:02 -05:00
xCrystal 10d38669b0 In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-30 00:31:05 +01:00
xCrystal c0812ca008 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-30 00:26:13 +01:00
SnorlaxMonster 7266ac4bdc Correct macro for default Mystery Gift item (pret/pokecrystal#1084)
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
2023-11-17 18:19:26 +00:00
mid-kid d8512cd864 Use time capsule label for time capsule copies 2023-04-19 19:11:32 +02:00
mid-kid d04f895040 Use more appropriate labels for link operations 2023-04-19 19:11:26 +02:00
mid-kid 4cd953c1e5 Define SERIAL_PATCH_PREAMBLE_LENGTH
Crystal: 86cc644b970eecfb616b858ad8b697f9a09f57eb
2023-04-19 19:11:15 +02:00
mid-kid 5801a30424 Label wOTLinkBattleRNData 2023-04-19 19:09:40 +02:00
mid-kid 7050425c82 Document link patch lists a little bit better
Crystal: c8738a3aaecacd1ceec96bc6ccd80592f44de0fc
2023-04-19 19:09:25 +02:00
mid-kid 4d20b8420c Make wMysteryGift*GameVersion constants consistent
Crystal: c244ec5a15981b890afa2d2ddef1fc77a226766c
2023-04-19 19:08:30 +02:00
mid-kid bbc7261da2 IsMailEuropean → ParseMailLanguage (and give it constants)
Crystal: c012a77e83b2a2efa7ade90b18a5a10d57900327
2023-04-19 19:06:48 +02:00
Rangi 42ba9bbbe1 Require rgbds 0.6.0 2022-10-02 21:52:02 -04:00
vulcandth 1e1dbf842b VC ExchangeBytes Aliases
Co-Authored-By: aaaaaa123456789 <aaaaaa123456789@acidch.at>
2022-06-21 11:16:20 +02:00
vulcandth 464c67ee73 RGBDS syntax updates (#78)
New MACRO and DEF syntax
2022-06-06 17:25:39 -04:00
vulcandth 2bab8a2946 Improved Virtual Console patch identifiers (#79) 2022-06-06 17:22:43 -04:00
vulcandth 1ee3020657 Add hSerialConnectionStatus vc_asserts (#77) 2022-04-17 12:35:38 -04:00
vulcandth 3d58fb9556 Build the Virtual Console patches with make gold_vc and make silver_vc (#74) 2022-03-14 17:03:15 -04:00
Rangi 14a21880a0 Use ~X instead of $ff ^ X 2021-11-23 20:50:17 -05:00
Rangi afd42efb60 Consistent labels for each nickname in RAM 2021-03-17 16:38:30 -04:00
Rangi abfe4f96ee Identify scrolling menu lists in WRAM 2021-03-08 09:45:51 -05:00
Rangi bb88e045d1 Identify link sync buffers, separate from link action bytes 2021-02-22 12:39:49 -05:00
Rangi 524f57703f Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
2020-12-23 16:46:49 -05:00
Rangi 348c5caea7 Identify link.asm WRAM labels based on ax6's research notes <https://pastebin.com/NTxjzKGQ> 2020-12-08 21:24:45 -05:00
Rangi dd73b278b5 Resolve some "???" comments 2020-11-17 10:56:28 -05:00
Rangi bc8636d688 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:35 -05:00
Rangi 5c143ed970 Identify more uses of wBuffer1-6 2020-11-03 19:52:59 -05:00
Rangi 980153ac47 Group some link.asm code into "paragraphs" 2020-11-02 19:32:12 -05:00
Rangi 7be1223fc1 Identify wLinkBattleRNPreamble 2020-11-01 13:42:08 -05:00
Rangi a75527df25 Make some labels more consistent 2020-11-01 12:36:53 -05:00
Rangi 3737ca4017 Sync Mystery Gift labels with pokecrystal 2020-10-30 10:45:33 -04:00
Rangi 15ad69e0c6 Define SERIAL_LINK_BYTE_TIMEOUT 2020-10-29 16:43:35 -04:00
Rangi ffdde1fa00 Name an unused link engine WRAM byte 2020-10-29 15:14:45 -04:00
Rangi 7062ce2ffa Identify the remaining uses of another WRAM union 2020-10-29 14:45:52 -04:00
Rangi b47bfbd813 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:39:52 -04:00
Rangi 599046c892 Identify remaining Mystery Gift labels and constants
Source: https://projectpokemon.org/home/forums/topic/43930-mystery-gift-reverse-engineering-of-ir-protocol/
2020-10-27 23:08:46 -04:00
Rangi 46f6cc4d41 Comment, remove, or revise many unreferenced labels 2020-10-26 20:30:09 -04:00
Rangi 26ddba8cfd Identify some more labels, mostly WRAM 2020-10-23 16:04:03 -04:00
Elliot 3c8bf3c01d Name symbols in link.asm (#63)
Identify remaining link.asm labels
2020-10-23 13:37:12 -04:00
Rangi 0b6b706ffc Identify some more labels (a few link-related) 2020-10-22 00:53:59 -04:00
Rangi e128fbeadb Identify some more unnamed labels 2020-10-04 20:10:31 -04:00
mid-kid c44da8221f Document weird code involving link trades of mew and celebi
This piece of code is frankly rather confusing, as it seemingly doesn't
serve much of a purpose. Documenting it here for future reference.
2020-08-19 15:59:49 +02:00