25 Commits

Author SHA1 Message Date
Rangi cc9f0b55ba Define tileset animations with a tileframe macro, and move them to data/tileset_anims.asm 2026-06-07 01:31:59 -04:00
Rangi f57be98873 Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#130) 2025-06-23 09:11:35 -04:00
Sylvie 7ebc4324db Identify more bit flags (#120) 2024-11-28 14:50:00 -05:00
xCrystal 257d56018d Address PR suggestions (#1078) 2024-01-30 00:42:08 +01:00
xCrystal c0812ca008 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-30 00:26:13 +01:00
Idain 859b45abcf Improve use of palette macro and use PAL_* constants (pret/pokecrystal#1087)
* Improve use of palette macro and use PAL_* constants

* Use proper constant for battle stats (#1088)

* Add suggestions about function names and variables

* Add colors macro

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-17 18:27:43 +00:00
Rangi c133efea5f Add more comments to tileset palette animation functions 2021-05-30 23:32:07 -04:00
Rangi b299b8954f Consistent comments in the tileset animation engine 2021-03-23 20:57:44 -04:00
Rangi 5454e1e0de Verify data table sizes with table_width and assert_table_length macros
It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants.
2021-03-05 16:10:25 -05:00
Rangi 9483cf47dd Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:24 -04:00
Rangi 46f6cc4d41 Comment, remove, or revise many unreferenced labels 2020-10-26 20:30:09 -04:00
Rangi d2ffdbf7ea Update battle anim bg function comments, and identify more unnamed labels 2020-10-06 18:09:25 -04:00
Rangi 2b003eca72 Identify some time-related data 2020-08-11 14:13:04 -04:00
Rangi e6f7543292 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:40 -04:00
Rangi 993f87a852 Harmonize engine/{phone, pokedex, pokegear, printer, rtc, tilesets} with pokecrystal
To do: engine/{menus, movie, overworld, pokemon}
2020-06-17 11:28:47 -04:00
entrpntr e28325211c Fix file permissions. 2020-06-05 16:42:33 -04:00
libjet 2d45f5d172 Add engine/tilesets/timeofday_pals.asm 2020-05-30 17:10:33 +01:00
entrpntr 14f6ddbe3c Finish disassembling banks 7 and 8. 2020-05-25 17:04:16 -04:00
entrpntr af78271eb3 Palette map updates. 2020-05-25 16:58:29 -04:00
entrpntr bfddbf6b11 Add engine/events/npc_trade.asm. 2020-05-22 23:52:45 -04:00
entrpntr bca9680f9a Add engine/tilesets/tileset_anims.asm. 2020-05-22 22:58:36 -04:00
entrpntr 3e40a1ecd0 Simple cleanups in constants/data/macros and banks 1-4. 2020-05-12 13:31:27 -04:00
entrpntr 71f217cfa0 Finish disassembling bank $05. 2020-04-12 17:31:25 -04:00
entrpntr ca12e16b29 Disassemble load_pics.asm and move_mon_wo_mail.asm in bank $14. 2020-03-25 15:10:21 -04:00
entrpntr e67786a7a2 Cleanup of files for banks $02 and $03 for main.asm. 2020-03-17 16:20:00 -04:00