110 Commits

Author SHA1 Message Date
Narishma-gb 423ea57be7 Fix unused script in MahoganyTown.asm, add some {d:CONSTANT} patterns 2026-06-08 13:32:48 -04:00
Narishma-gb 6d3139ce90 Rename EVENT_LAKE_OF_RAGE_ELIXIR_ON_STANDBY to match the ETHER prize 2026-06-08 13:32:48 -04:00
Rangi 4c62e03c8e Fix the GoldenrodUndergroundSwitchRoomEntrances door-switch macros 2026-06-07 01:26:10 -04:00
Rangi42 ffe649f856 Rename Bill's brother to Bill's older sister 2024-10-17 17:27:13 -04:00
Damien Doury 0929c2a320 Fix wrong text labels in VermilionPort.asm
The text label said "Monday" when it actually displayed "Wednesday".
2024-01-30 12:08:13 +00:00
xCrystal 59642837e9 more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-30 00:41:00 +01:00
xCrystal c0812ca008 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-30 00:26:13 +01:00
SnorlaxMonster a4aa97213d Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (pret/pokecrystal#1058)
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
2023-07-27 10:53:25 -05:00
vulcandth 3edd4eb48d Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (pret/pokecrystal#1053) 2023-06-01 12:54:49 +00:00
Rangi be34ff7c09 Dance Theatre -> Dance Theater 2022-09-23 22:17:03 -04:00
Rangi 902445d353 Refer to "Rival", not "Silver" (#103)
See https://github.com/pret/pokecrystal/pull/983
2022-08-10 21:24:58 -04:00
vulcandth 6726e4c4c9 Rename scene and callback labels (#102)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-09 18:04:16 -04:00
Rangi d4362cad05 Fix some whitespace 2022-08-07 00:38:04 -04:00
Rangi 2d7f97e52f Define scene constants alongside scene_scripts (#101)
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:12 -04:00
vulcandth 4c95a9a708 Clean up bugs commented in the source code (#89)
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-07-09 16:12:32 -05:00
vulcandth 464c67ee73 RGBDS syntax updates (#78)
New MACRO and DEF syntax
2022-06-06 17:25:39 -04:00
vulcandth 6ac6de58f5 Prune trailing whitespace (#81) 2022-05-06 13:09:52 -04:00
FrenchOrange 7d17d3ce8f Miscellaneous tweaks (#72) 2022-03-07 20:48:59 -05:00
Rangi d850eb831b Don't require a boolean trainer flag for givepoke 2022-01-10 21:16:32 -05:00
Rangi 01c0b36a91 Fix spacing between event scripts 2021-10-05 21:11:51 -04:00
Rangi 587c2e176e Use constants in the UnusedEnteiScript 2021-10-05 21:05:59 -04:00
Rangi 4fd14d6bbd Rename prioritysjump to sdefer 2021-06-08 20:38:56 -04:00
Rangi aa3a3224c6 Use numeric constants in text strings with "{d:interpolation}" 2021-03-21 18:14:36 -04:00
Rangi d1167570cc Assert some more table widths 2021-03-17 11:37:55 -04:00
Rangi 48e6bed93a Sync some files with pokecrystal 2021-03-11 17:43:16 -05:00
Rangi b56c1b6351 More syncing with pokecrystal 2020-11-03 10:12:54 -05:00
Rangi 9483cf47dd Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:24 -04:00
Rangi 46f6cc4d41 Comment, remove, or revise many unreferenced labels 2020-10-26 20:30:09 -04:00
Elliot 3c8bf3c01d Name symbols in link.asm (#63)
Identify remaining link.asm labels
2020-10-23 13:37:12 -04:00
Rangi c65b0fcd44 Identify unused Route 40 movement data 2020-10-21 16:09:42 -04:00
Rangi 6e91829b82 Consistent (x, y) coordinates for ugdoor macro 2020-10-21 15:39:42 -04:00
Rangi 054e6088f9 Identify some more unnamed labels 2020-10-05 12:02:48 -04:00
Rangi 734524ad42 Identify movement labels in map scripts 2020-10-04 18:15:31 -04:00
Rangi 12e12dff81 Use EGG_LEVEL for Togepi egg 2020-09-27 12:31:38 -04:00
Rangi d24f1c7114 Use def_* macros for automatic map event counts 2020-07-26 16:29:43 -04:00
Rangi a7360edd39 SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE 2020-07-17 13:01:36 -04:00
Rangi 9a48c7ba6b return → endcallback, reloadandreturn → reloadend 2020-07-17 08:37:33 -04:00
Rangi 3aba8710fa Use pokepret account for committing to symbols branch 2020-06-22 17:25:31 -04:00
Rangi 6595505831 Identify some more labels 2020-06-22 16:29:53 -04:00
Rangi 9dee89fae3 Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:29 -04:00
Rangi 815d22201a Identify some more Unknown labels 2020-06-20 18:52:20 -04:00
entrpntr 9d0c8dbf8e Rename labels to stop cheating the unnamed.py script. 2020-06-19 07:35:14 -04:00
Rangi 437c7404e9 Merge branch 'master' of https://github.com/pret/pokegold 2020-06-16 14:33:05 -04:00
Rangi fda549a27a [in progress] Harmonize more constant and data files with pokecrystal 2020-06-16 14:32:48 -04:00
entrpntr 93747a4839 Map script cleanups. 2020-06-16 13:52:20 -04:00
Rangi 03e93e5a70 WiseTriosRoom -> EcruteakTinTowerBackEntrance 2020-06-15 17:32:11 -04:00
Rangi dac20d6dd2 SPRITE_BUENA -> SPRITE_BEAUTY 2020-06-15 17:12:24 -04:00
entrpntr e9b6a2fc62 Miscellaneous cleanups. 2020-06-15 14:08:24 -04:00
Rangi 54bbefeed1 Treat std scripts like specials and predefs (ported from pokecrystal) 2020-06-15 13:25:56 -04:00
Rangi 9f01e33a04 Port miscellaneous recent updates from pokecrystal 2020-06-15 13:12:56 -04:00