Commit Graph

382 Commits

Author SHA1 Message Date
Rangi 7062ce2ffa Identify the remaining uses of another WRAM union 2020-10-29 14:45:52 -04:00
Rangi b47bfbd813 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:39:52 -04:00
Rangi 9483cf47dd Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:24 -04:00
Rangi 599046c892 Identify remaining Mystery Gift labels and constants
Source: https://projectpokemon.org/home/forums/topic/43930-mystery-gift-reverse-engineering-of-ir-protocol/
2020-10-27 23:08:46 -04:00
Rangi 6e142eb5b3 Create data/collision/ for tile collision-related data 2020-10-27 10:00:51 -04:00
Rangi 676f2f12e3 Use more assertions to ensure correct code and data 2020-10-26 22:24:47 -04:00
Rangi 46f6cc4d41 Comment, remove, or revise many unreferenced labels 2020-10-26 20:30:09 -04:00
Rangi 26ddba8cfd Identify some more labels, mostly WRAM 2020-10-23 16:04:03 -04:00
Elliot 3c8bf3c01d Name symbols in link.asm (#63)
Identify remaining link.asm labels
2020-10-23 13:37:12 -04:00
Rangi d234a5ee3d Identify remaining debug color picker labels 2020-10-23 12:38:00 -04:00
Rangi b4d362e45c Identify remaining intro labels 2020-10-23 10:02:05 -04:00
Rangi 2d51993b09 Identify remaining map object labels 2020-10-22 21:30:11 -04:00
Rangi 0d681c25b9 Identify some more map object labels and constants 2020-10-22 17:41:42 -04:00
Rangi 20fbb729f5 Identify a few more labels and data 2020-10-22 12:55:48 -04:00
Rangi 07f670f956 Identify more sprite graphics and map object labels, and have consistent anonymous jumptable labels 2020-10-22 10:54:45 -04:00
Rangi 0b6b706ffc Identify some more labels (a few link-related) 2020-10-22 00:53:59 -04:00
Rangi 0ac39546c6 Identify remaining two battle anim BG effect functions 2020-10-21 22:51:16 -04:00
Rangi 2127643f8d Identify remaining battle AI labels 2020-10-21 21:34:10 -04:00
Rangi a325de7630 Identify SwitchItemsInBag labels
Thanks to FIQ for having done so in Polished Crystal
2020-10-21 15:39:19 -04:00
Rangi 2a4ef330e0 Battle transition spin quadrants are like pokered's half circles 2020-10-19 20:27:10 -04:00
Rangi 361540a63b Identify some values as relative struct offsets in MoveScreenLoop 2020-10-14 18:32:36 -04:00
Rangi d2ffdbf7ea Update battle anim bg function comments, and identify more unnamed labels 2020-10-06 18:09:25 -04:00
Rangi 5838d479a2 Identify battle bg effects functions and constants 2020-10-06 16:18:05 -04:00
Rangi 8b766163e3 Identify some unnamed labels 2020-10-06 13:49:55 -04:00
Rangi 10151dd4eb Identify some more unnamed labels 2020-10-05 20:09:52 -04:00
Rangi 8871f4b611 Identify more unnamed labels 2020-10-05 16:15:47 -04:00
Rangi 054e6088f9 Identify some more unnamed labels 2020-10-05 12:02:48 -04:00
Rangi 3745ba9f9e Identify more unnamed labels 2020-10-04 22:34:55 -04:00
Rangi e128fbeadb Identify some more unnamed labels 2020-10-04 20:10:31 -04:00
Rangi 8443840f97 Identify SGB blk/pal packets 2020-10-04 18:32:28 -04:00
Rangi ec88087f30 Identify battle animation functions 2020-10-03 22:17:19 -04:00
Rangi f90f4bc62a Remove wKickCounter and wPresentPower aliases for wBattleAnimParam 2020-08-29 20:36:00 -04:00
mid-kid aa04a13578 GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
2020-08-27 15:17:53 +02:00
mid-kid 0a1eb668d0 Fix some constants surrounding sprite animations
Also commented the use of the field surrounding the struct
initialization functions.

SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4

BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 14:51:59 +02:00
mid-kid a7c294371c Port splash screen documentation changes from Crystal
Since the splash screen is wildly different, a lot of the docs don't
really apply here.
2020-08-27 14:40:18 +02:00
mid-kid 17feb556f2 Split engine/movie/intro.asm into itself and splash.asm 2020-08-27 14:15:41 +02:00
mid-kid d21975be2d Move all splash screen files to gfx/splash 2020-08-27 14:14:14 +02:00
mid-kid c44da8221f Document weird code involving link trades of mew and celebi
This piece of code is frankly rather confusing, as it seemingly doesn't
serve much of a purpose. Documenting it here for future reference.
2020-08-19 15:59:49 +02:00
Rangi 34ad9498ea Merge pull request #60 from mid-kid/master
Rub a dub dub, thanks for the grub
2020-08-18 16:35:16 -04:00
mid-kid 4ea75afd56 Add wTitleScreenSelectedOption constants 2020-08-18 22:28:22 +02:00
Rangi 2556704a43 Consistent constants for radio data table sizes (could still be better) 2020-08-13 13:47:57 -04:00
Rangi 7d8a73220c Factor out gfx/pack/pack_menu.tilemap 2020-08-12 21:02:08 -04:00
Rangi 2b003eca72 Identify some time-related data 2020-08-11 14:13:04 -04:00
mid-kid a51c15a7ef Remove a verifiably false comment
wSpriteAnimCount starts at 0, keeps incrementing and never decrements.
When it reaches $ff, the next value is 1.

Its purpose is unknown, as this value is used nowhere else.
2020-08-05 17:34:49 +02:00
mid-kid f1075b1a9d d is the multiplier for Sprites_Sine 2020-08-05 17:34:39 +02:00
mid-kid ad5c4a73a5 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:32 +02:00
mid-kid 6b2a0b2889 Document wTitleScreenSelectedOption variable 2020-08-05 16:02:23 +02:00
mid-kid 2de0ac25f4 Better label 2D menu data 2020-08-04 01:18:00 +02:00
mid-kid e0d273e3ed Prevent OaksPKMNTalk from looping forever if NUM_GRASSMON is changed
That should cause no real problems because of a range check right after
it.
2020-08-04 01:17:44 +02:00
Rangi 878e0b3b33 Identify constant in NamingScreen_IsTargetBox 2020-08-03 15:22:11 -04:00