Commit Graph

232 Commits

Author SHA1 Message Date
Rangi 3affb23969 Don't pass redundant label names to table_width and list_start (#126) 2024-12-27 12:35:41 -05:00
Jordan Moore 990f43865b Rename checkcurl to checkrollout 2024-12-25 12:05:58 +01:00
Sylvie 7ebc4324db Identify more bit flags (#120) 2024-11-28 14:50:00 -05:00
Rangi42 ffe649f856 Rename Bill's brother to Bill's older sister 2024-10-17 17:27:13 -04:00
Rangi42 fe8254c900 Rename dt and dd to bigdt and bigdd
This makes their big-endianness obvious and matches `dw`
2024-10-17 14:56:47 -04:00
Sylvie a18a8bf27e Sort Pokemon and trainer sprite palettes, with Makefile-specified exceptions (#121)
This avoids the need to define their order via indexed PNG palettes

It also avoids the need to use tools/palfix.py on custom sprites
2024-10-17 13:45:02 -04:00
Rangi42 02520526b2 Put front and back pics on a single line 2024-09-26 00:26:49 -04:00
Rangi42 10552c2e39 Consolidate the duplicate stat level data files 2024-06-12 13:14:01 -04:00
Sylvie 98d728262f Identify various "????"s (#116) 2024-06-11 20:54:43 -04:00
xCrystal df10c9ea1a Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-30 00:41:51 +01:00
xCrystal c0812ca008 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-30 00:26:13 +01:00
Rangi42 16571da5eb Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names 2024-01-01 21:58:26 -05:00
vulcandth 70f883dc86 Sync sprite and battle anim consts/labels (pret/pokecrystal#1055)
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
2023-09-17 14:48:08 -05:00
Tiddlywinks 1a5c2b0414 1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either) 2023-09-13 08:07:13 +02:00
SoupPotato 97a3786fc8 Labeled framesets and related constants (pret/pokecrystal#1063)
* Labeled Framesets and Constants Related

* Feedback Implemented with PascalCase and Constant Renames

* Fix framset.asm comment spacing

* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`

* Feedback applied and labeled 1E & B2

* Fixed SpinningBone

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-08-21 19:11:14 -05:00
vulcandth 13b703511b Use BattleAnim_Dummy in data/moves/animations.asm (pret/pokecrystal#1052) 2023-07-18 16:24:23 -05:00
vulcandth 3edd4eb48d Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (pret/pokecrystal#1053) 2023-06-01 12:54:49 +00:00
Rangi 368ab134fe Use rgbgfx -c embedded to extract palettes
Fixes #107
2022-12-27 18:35:10 -05:00
Rangi 42ba9bbbe1 Require rgbds 0.6.0 2022-10-02 21:52:02 -04:00
Rangi be34ff7c09 Dance Theatre -> Dance Theater 2022-09-23 22:17:03 -04:00
Idain 562041b4a2 TYPO: NUM_MOVE_EFECTS > NUM_MOVE_EFFECTS (#1009) 2022-09-21 22:03:43 -05:00
Rangi 902445d353 Refer to "Rival", not "Silver" (#103)
See https://github.com/pret/pokecrystal/pull/983
2022-08-10 21:24:58 -04:00
Rangi fafd95ce19 PP must be 40 or less 2022-08-10 21:20:45 -04:00
Rangi d4362cad05 Fix some whitespace 2022-08-07 00:38:04 -04:00
vulcandth 4c95a9a708 Clean up bugs commented in the source code (#89)
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-07-09 16:12:32 -05:00
Rangi f65f723ab4 spriteanimoam macro corresponds to battleanimoam 2022-07-04 01:11:41 -04:00
Rangi 09672ef3d6 Split "gfx anims" into "pic anims" and "sprite anims" 2022-07-04 01:11:41 -04:00
vulcandth 6805c678ee Rename SLP to SLP_MASK (#84)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:55 -04:00
vulcandth 464c67ee73 RGBDS syntax updates (#78)
New MACRO and DEF syntax
2022-06-06 17:25:39 -04:00
FrenchOrange 7d17d3ce8f Miscellaneous tweaks (#72) 2022-03-07 20:48:59 -05:00
Rangi ddb01660dd Use compound assignment operators 2021-11-23 20:46:40 -05:00
Rangi 5998a045fb Use -1 for terminating happiness probability data 2021-10-28 17:11:07 -04:00
Rangi 43f9f529fa Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:57:58 -04:00
Rangi 65d1e12d6a Require rgbds 0.5.1
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
2021-05-09 12:47:43 -04:00
Rangi 40dbe0df04 Use rgbds 0.5.0 2021-04-20 21:17:09 -04:00
Rangi bc59bad170 Verify uneven list sizes with list_start, li, and assert_list_length macros 2021-03-23 09:57:48 -04:00
Rangi ea59f5ee47 Miscellaneous cleanup 2021-03-22 16:41:10 -04:00
Rangi afd42efb60 Consistent labels for each nickname in RAM 2021-03-17 16:38:30 -04:00
Rangi d1167570cc Assert some more table widths 2021-03-17 11:37:55 -04:00
Rangi 2bc8cf5fc1 Revise some constant definitions 2021-03-16 18:08:25 -04:00
Rangi 0d185fbd88 Define MAPGROUP_* constants and verify MapGroup_* table sizes 2021-03-10 21:21:12 -05:00
Rangi 472051eb5e Verify wild data sizes with def_grass/water_wildmons and end_grass/water_wildmons macros 2021-03-05 16:18:43 -05:00
Rangi 5454e1e0de Verify data table sizes with table_width and assert_table_length macros
It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants.
2021-03-05 16:10:25 -05:00
Rangi edbc734b84 Fix typo 2021-02-05 12:46:34 -05:00
Rangi 4c43fa538d The 'tmhm' macro adjusts to the number of TMs/HMs 2021-01-06 10:20:29 -05:00
Rangi 524f57703f Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
2020-12-23 16:46:49 -05:00
Rangi 79d7682b03 Clarify signed magnitude in the growth_rate macro 2020-12-20 23:35:32 -05:00
Rangi 653e92d803 Use assert to ensure correct base data size 2020-11-17 16:14:41 -05:00
Rangi ca957dd503 Correct some filename comments 2020-11-17 10:59:56 -05:00
Rangi dd73b278b5 Resolve some "???" comments 2020-11-17 10:56:28 -05:00