Commit Graph

421 Commits

Author SHA1 Message Date
Rangi dc17d58170 Verify script command table sizes 2021-03-11 16:31:40 -05:00
Rangi 0d185fbd88 Define MAPGROUP_* constants and verify MapGroup_* table sizes 2021-03-10 21:21:12 -05:00
Rangi f9431c6aab Merge pull request #69 from Rangi42/tables
Verify data table sizes with table_width and assert_table_length macros
2021-03-08 07:01:30 -08:00
Rangi abfe4f96ee Identify scrolling menu lists in WRAM 2021-03-08 09:45:51 -05:00
Rangi 5454e1e0de Verify data table sizes with table_width and assert_table_length macros
It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants.
2021-03-05 16:10:25 -05:00
Rangi bb88e045d1 Identify link sync buffers, separate from link action bytes 2021-02-22 12:39:49 -05:00
Rangi 95100227ec Use PARTY_LENGTH and MAILBOX_CAPACITY constants 2021-02-10 08:50:38 -05:00
Rangi 51aa06097f Rename GetFarHalfword to GetFarWord 2021-01-09 15:16:20 -05:00
Rangi ed133f5c9a Remove "Buffer" suffix from two HRAM labels 2020-12-23 16:54:26 -05:00
Rangi 524f57703f Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
2020-12-23 16:46:49 -05:00
Rangi 348c5caea7 Identify link.asm WRAM labels based on ax6's research notes <https://pastebin.com/NTxjzKGQ> 2020-12-08 21:24:45 -05:00
Rangi 2a65aa8431 grey -> gray 2020-12-08 14:34:42 -05:00
Rangi c745dd6777 FarString -> PlaceFarString, and FarPlaceString -> BrokenPlaceFarString 2020-12-07 13:32:07 -05:00
Rangi 60e6657c63 Document AI_Smart_Conversion2 bug 2020-12-07 13:12:59 -05:00
aljohnston112 5fa0983780 Cleaned up some comments and changed a magic number to maskbits NUM_CHANNELS (#68)
Improve the audio engine's comments and replace some magic numbers with constants
2020-12-07 12:44:12 -05:00
Rangi 74abd20b77 text "<PARA>..." → text_start and para "..." 2020-12-04 22:28:25 -05:00
Rangi 84dd1b587f Use STRING_BUFFER_LENGTH for the wStringBuffers 2020-11-24 20:11:13 -05:00
Rangi ca957dd503 Correct some filename comments 2020-11-17 10:59:56 -05:00
Rangi dd73b278b5 Resolve some "???" comments 2020-11-17 10:56:28 -05:00
Rangi 8b8bf87151 Remove "XXX" comment (various "???+" still mark unclear code) 2020-11-09 16:38:01 -05:00
Rangi 6382790a1d Terser damage calculation constants 2020-11-09 16:12:17 -05:00
Rangi bc8636d688 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:35 -05:00
Rangi 6e20c30f6e Identify wBattleAnimTemp0-3 2020-11-09 15:05:26 -05:00
Rangi dbcab434fb Rename "dummy game" to "memory game" 2020-11-08 19:32:52 -05:00
Rangi 9281a44c68 Identify remaining uses of wBuffer1-6 as general-purpose HP buffers 2020-11-03 23:25:20 -05:00
Rangi 2b9c37e74f Identify some more uses of wBuffer1-6 2020-11-03 22:45:10 -05:00
Rangi 5c143ed970 Identify more uses of wBuffer1-6 2020-11-03 19:52:59 -05:00
Rangi b56c1b6351 More syncing with pokecrystal 2020-11-03 10:12:54 -05:00
Rangi 980153ac47 Group some link.asm code into "paragraphs" 2020-11-02 19:32:12 -05:00
Rangi c9bf53310f Identify an unused intro sprite animation from pokegold-spaceworld 2020-11-02 09:30:29 -05:00
Rangi 7be1223fc1 Identify wLinkBattleRNPreamble 2020-11-01 13:42:08 -05:00
Rangi a75527df25 Make some labels more consistent 2020-11-01 12:36:53 -05:00
Rangi eecff60284 UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims 2020-10-30 17:32:04 -04:00
Rangi 542f02c181 Extract more RGB data to .pal files 2020-10-30 16:12:20 -04:00
Rangi 6063bd1dfb Identify wSpriteAnimDict key constants 2020-10-30 15:38:56 -04:00
Rangi 3737ca4017 Sync Mystery Gift labels with pokecrystal 2020-10-30 10:45:33 -04:00
Rangi b89636769c Updates to more closely sync with pokecrystal 2020-10-29 23:23:44 -04:00
Rangi 15ad69e0c6 Define SERIAL_LINK_BYTE_TIMEOUT 2020-10-29 16:43:35 -04:00
Rangi ffdde1fa00 Name an unused link engine WRAM byte 2020-10-29 15:14:45 -04:00
Rangi 7062ce2ffa Identify the remaining uses of another WRAM union 2020-10-29 14:45:52 -04:00
Rangi b47bfbd813 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:39:52 -04:00
Rangi 9483cf47dd Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:24 -04:00
Rangi 599046c892 Identify remaining Mystery Gift labels and constants
Source: https://projectpokemon.org/home/forums/topic/43930-mystery-gift-reverse-engineering-of-ir-protocol/
2020-10-27 23:08:46 -04:00
Rangi 6e142eb5b3 Create data/collision/ for tile collision-related data 2020-10-27 10:00:51 -04:00
Rangi 676f2f12e3 Use more assertions to ensure correct code and data 2020-10-26 22:24:47 -04:00
Rangi 46f6cc4d41 Comment, remove, or revise many unreferenced labels 2020-10-26 20:30:09 -04:00
Rangi 26ddba8cfd Identify some more labels, mostly WRAM 2020-10-23 16:04:03 -04:00
Elliot 3c8bf3c01d Name symbols in link.asm (#63)
Identify remaining link.asm labels
2020-10-23 13:37:12 -04:00
Rangi d234a5ee3d Identify remaining debug color picker labels 2020-10-23 12:38:00 -04:00
Rangi b4d362e45c Identify remaining intro labels 2020-10-23 10:02:05 -04:00