Commit Graph

345 Commits

Author SHA1 Message Date
mid-kid c44da8221f Document weird code involving link trades of mew and celebi
This piece of code is frankly rather confusing, as it seemingly doesn't
serve much of a purpose. Documenting it here for future reference.
2020-08-19 15:59:49 +02:00
Rangi 34ad9498ea Merge pull request #60 from mid-kid/master
Rub a dub dub, thanks for the grub
2020-08-18 16:35:16 -04:00
mid-kid 4ea75afd56 Add wTitleScreenSelectedOption constants 2020-08-18 22:28:22 +02:00
Rangi 2556704a43 Consistent constants for radio data table sizes (could still be better) 2020-08-13 13:47:57 -04:00
Rangi 7d8a73220c Factor out gfx/pack/pack_menu.tilemap 2020-08-12 21:02:08 -04:00
Rangi 2b003eca72 Identify some time-related data 2020-08-11 14:13:04 -04:00
mid-kid a51c15a7ef Remove a verifiably false comment
wSpriteAnimCount starts at 0, keeps incrementing and never decrements.
When it reaches $ff, the next value is 1.

Its purpose is unknown, as this value is used nowhere else.
2020-08-05 17:34:49 +02:00
mid-kid f1075b1a9d d is the multiplier for Sprites_Sine 2020-08-05 17:34:39 +02:00
mid-kid ad5c4a73a5 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:32 +02:00
mid-kid 6b2a0b2889 Document wTitleScreenSelectedOption variable 2020-08-05 16:02:23 +02:00
mid-kid 2de0ac25f4 Better label 2D menu data 2020-08-04 01:18:00 +02:00
mid-kid e0d273e3ed Prevent OaksPKMNTalk from looping forever if NUM_GRASSMON is changed
That should cause no real problems because of a range check right after
it.
2020-08-04 01:17:44 +02:00
Rangi 878e0b3b33 Identify constant in NamingScreen_IsTargetBox 2020-08-03 15:22:11 -04:00
Rangi d24f1c7114 Use def_* macros for automatic map event counts 2020-07-26 16:29:43 -04:00
Rangi f9f438473f Move EngineFlags and SpecialsPointers into data/engine/ 2020-07-22 20:25:22 -04:00
Rangi 31287c6aaa Revert "Factor out tables into data/overworld/"
This reverts commit 3f392c2792.
2020-07-22 20:23:19 -04:00
Rangi 3f392c2792 Factor out tables into data/overworld/ 2020-07-22 15:23:02 -04:00
Rangi 53d4a649b9 Treat map setup commands like trade script commands 2020-07-22 13:37:52 -04:00
Rangi b6bb40fcaf Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1) 2020-07-21 19:45:15 -04:00
Rangi 60b0f0039d Define JOHTO_FLYPOINT like KANTO_FLYPOINT 2020-07-21 12:15:05 -04:00
Rangi 0bb3d0e472 Define NUM_FLYPOINTS 2020-07-21 11:48:46 -04:00
Rangi c6b51a8485 " " → $7f 2020-07-21 11:13:10 -04:00
Rangi 1bb30c42e5 Fix newlines 2020-07-17 16:58:56 -04:00
Rangi 4ba9501c28 Port pokered's more local system for trade animation scripts
Also factor out trade tilemaps
2020-07-17 16:53:10 -04:00
Rangi a7360edd39 SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE 2020-07-17 13:01:36 -04:00
Rangi 9a48c7ba6b return → endcallback, reloadandreturn → reloadend 2020-07-17 08:37:33 -04:00
Rangi a304573fcb Define map setup commands as macros like other script commands 2020-07-13 20:49:57 -04:00
Rangi 4eeab8973c Disassemble the final English debug ROMs 2020-07-13 10:59:22 -04:00
Rangi a19abb5045 Use const_skip and const_next macros for brevity 2020-07-09 12:15:44 -04:00
Rangi 61598ad925 Eliminate enum: use const instead, with case-by-case parallel const implementations 2020-07-09 11:27:10 -04:00
Rangi be3f9cd5dc Define SERIAL_PREAMBLE_LENGTH 2020-07-06 15:49:31 -04:00
Rangi 7324c1d11a Use MAX_NEUTRAL_DAMAGE in BattleCommand_DamageCalc
Also make .gitignore consistent with pokered
2020-07-05 15:14:07 -04:00
Rangi a33e8713bd SCGB_PARTY_MENU_HP_PALS -> SCGB_PARTY_MENU_HP_BARS, and SCGB_RAM -> SCGB_DEFAULT 2020-07-04 16:17:59 -04:00
Rangi e6f7543292 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:40 -04:00
Rangi 534863abe1 Identify more labels and constants 2020-06-29 19:35:37 -04:00
Rangi 416255bea4 Identify more unnamed labels 2020-06-29 12:25:46 -04:00
Rangi 152efaadc0 Reformat gfx/trade/game_boy.png and fix tools/gfx --preserve 2020-06-28 19:55:53 -04:00
Rangi 6595505831 Identify some more labels 2020-06-22 16:29:53 -04:00
Rangi f680408489 Comment more ROM labels as unreferenced
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:40 -04:00
Rangi 9dee89fae3 Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:29 -04:00
Rangi e0df1a6041 Remove RAM address comments 2020-06-21 12:42:33 -04:00
entrpntr 9d0c8dbf8e Rename labels to stop cheating the unnamed.py script. 2020-06-19 07:35:14 -04:00
Rangi e87159ed7b Harmonize engine/menus with pokecrystal 2020-06-18 10:11:03 -04:00
Rangi e5ee8ec7c0 Harmonize engine/overworld with pokecrystal 2020-06-17 22:11:49 -04:00
Rangi 451f529b0d Harmonize engine/{movie, pokemon} with pokecrystal
To do: engine/{menus, overworld}
2020-06-17 17:02:45 -04:00
Rangi 993f87a852 Harmonize engine/{phone, pokedex, pokegear, printer, rtc, tilesets} with pokecrystal
To do: engine/{menus, movie, overworld, pokemon}
2020-06-17 11:28:47 -04:00
Rangi f8c1754238 Harmonize engine/{gfx, items, link, math} with pokecrystal 2020-06-17 10:39:06 -04:00
Rangi 97c1f9dd27 ReplaceChrisSprite -> UpdatePlayerSprite 2020-06-16 19:37:50 -04:00
Rangi bc116a0db0 Harmonize engine/{battle, battle_anims, events, games} with pokecrystal 2020-06-16 19:32:30 -04:00
Rangi 356836b1cc Harmonize home/ with pokecrystal 2020-06-16 15:49:17 -04:00