Commit Graph

361 Commits

Author SHA1 Message Date
Rangi d2ffdbf7ea Update battle anim bg function comments, and identify more unnamed labels 2020-10-06 18:09:25 -04:00
Rangi 5838d479a2 Identify battle bg effects functions and constants 2020-10-06 16:18:05 -04:00
Rangi 8b766163e3 Identify some unnamed labels 2020-10-06 13:49:55 -04:00
Rangi 10151dd4eb Identify some more unnamed labels 2020-10-05 20:09:52 -04:00
Rangi 8871f4b611 Identify more unnamed labels 2020-10-05 16:15:47 -04:00
Rangi 054e6088f9 Identify some more unnamed labels 2020-10-05 12:02:48 -04:00
Rangi 3745ba9f9e Identify more unnamed labels 2020-10-04 22:34:55 -04:00
Rangi e128fbeadb Identify some more unnamed labels 2020-10-04 20:10:31 -04:00
Rangi 8443840f97 Identify SGB blk/pal packets 2020-10-04 18:32:28 -04:00
Rangi ec88087f30 Identify battle animation functions 2020-10-03 22:17:19 -04:00
Rangi f90f4bc62a Remove wKickCounter and wPresentPower aliases for wBattleAnimParam 2020-08-29 20:36:00 -04:00
mid-kid aa04a13578 GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
2020-08-27 15:17:53 +02:00
mid-kid 0a1eb668d0 Fix some constants surrounding sprite animations
Also commented the use of the field surrounding the struct
initialization functions.

SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4

BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 14:51:59 +02:00
mid-kid a7c294371c Port splash screen documentation changes from Crystal
Since the splash screen is wildly different, a lot of the docs don't
really apply here.
2020-08-27 14:40:18 +02:00
mid-kid 17feb556f2 Split engine/movie/intro.asm into itself and splash.asm 2020-08-27 14:15:41 +02:00
mid-kid d21975be2d Move all splash screen files to gfx/splash 2020-08-27 14:14:14 +02:00
mid-kid c44da8221f Document weird code involving link trades of mew and celebi
This piece of code is frankly rather confusing, as it seemingly doesn't
serve much of a purpose. Documenting it here for future reference.
2020-08-19 15:59:49 +02:00
Rangi 34ad9498ea Merge pull request #60 from mid-kid/master
Rub a dub dub, thanks for the grub
2020-08-18 16:35:16 -04:00
mid-kid 4ea75afd56 Add wTitleScreenSelectedOption constants 2020-08-18 22:28:22 +02:00
Rangi 2556704a43 Consistent constants for radio data table sizes (could still be better) 2020-08-13 13:47:57 -04:00
Rangi 7d8a73220c Factor out gfx/pack/pack_menu.tilemap 2020-08-12 21:02:08 -04:00
Rangi 2b003eca72 Identify some time-related data 2020-08-11 14:13:04 -04:00
mid-kid a51c15a7ef Remove a verifiably false comment
wSpriteAnimCount starts at 0, keeps incrementing and never decrements.
When it reaches $ff, the next value is 1.

Its purpose is unknown, as this value is used nowhere else.
2020-08-05 17:34:49 +02:00
mid-kid f1075b1a9d d is the multiplier for Sprites_Sine 2020-08-05 17:34:39 +02:00
mid-kid ad5c4a73a5 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:32 +02:00
mid-kid 6b2a0b2889 Document wTitleScreenSelectedOption variable 2020-08-05 16:02:23 +02:00
mid-kid 2de0ac25f4 Better label 2D menu data 2020-08-04 01:18:00 +02:00
mid-kid e0d273e3ed Prevent OaksPKMNTalk from looping forever if NUM_GRASSMON is changed
That should cause no real problems because of a range check right after
it.
2020-08-04 01:17:44 +02:00
Rangi 878e0b3b33 Identify constant in NamingScreen_IsTargetBox 2020-08-03 15:22:11 -04:00
Rangi d24f1c7114 Use def_* macros for automatic map event counts 2020-07-26 16:29:43 -04:00
Rangi f9f438473f Move EngineFlags and SpecialsPointers into data/engine/ 2020-07-22 20:25:22 -04:00
Rangi 31287c6aaa Revert "Factor out tables into data/overworld/"
This reverts commit 3f392c2792.
2020-07-22 20:23:19 -04:00
Rangi 3f392c2792 Factor out tables into data/overworld/ 2020-07-22 15:23:02 -04:00
Rangi 53d4a649b9 Treat map setup commands like trade script commands 2020-07-22 13:37:52 -04:00
Rangi b6bb40fcaf Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1) 2020-07-21 19:45:15 -04:00
Rangi 60b0f0039d Define JOHTO_FLYPOINT like KANTO_FLYPOINT 2020-07-21 12:15:05 -04:00
Rangi 0bb3d0e472 Define NUM_FLYPOINTS 2020-07-21 11:48:46 -04:00
Rangi c6b51a8485 " " → $7f 2020-07-21 11:13:10 -04:00
Rangi 1bb30c42e5 Fix newlines 2020-07-17 16:58:56 -04:00
Rangi 4ba9501c28 Port pokered's more local system for trade animation scripts
Also factor out trade tilemaps
2020-07-17 16:53:10 -04:00
Rangi a7360edd39 SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE 2020-07-17 13:01:36 -04:00
Rangi 9a48c7ba6b return → endcallback, reloadandreturn → reloadend 2020-07-17 08:37:33 -04:00
Rangi a304573fcb Define map setup commands as macros like other script commands 2020-07-13 20:49:57 -04:00
Rangi 4eeab8973c Disassemble the final English debug ROMs 2020-07-13 10:59:22 -04:00
Rangi a19abb5045 Use const_skip and const_next macros for brevity 2020-07-09 12:15:44 -04:00
Rangi 61598ad925 Eliminate enum: use const instead, with case-by-case parallel const implementations 2020-07-09 11:27:10 -04:00
Rangi be3f9cd5dc Define SERIAL_PREAMBLE_LENGTH 2020-07-06 15:49:31 -04:00
Rangi 7324c1d11a Use MAX_NEUTRAL_DAMAGE in BattleCommand_DamageCalc
Also make .gitignore consistent with pokered
2020-07-05 15:14:07 -04:00
Rangi a33e8713bd SCGB_PARTY_MENU_HP_PALS -> SCGB_PARTY_MENU_HP_BARS, and SCGB_RAM -> SCGB_DEFAULT 2020-07-04 16:17:59 -04:00
Rangi e6f7543292 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:40 -04:00