Commit Graph

489 Commits

Author SHA1 Message Date
Idain c9a8d2f5cf Replace hardcoded wMonType constants (#1011) 2022-09-28 19:52:27 -05:00
Rangi 5ae0bfb414 $f -> BATTLEACTION_FORFEIT
(thanks, Vulcandth)
2022-09-23 23:11:07 -04:00
Rangi bdb6ae85e0 Rename the object_struct field labels and constants (#105) 2022-09-12 09:15:49 -04:00
vulcandth 535e97723a Rename macros/wram.asm to macros/ram.asm (#104) 2022-09-11 01:05:06 -04:00
Rangi 0bccfa1cd1 Use for loops to generate box pointer tables 2022-09-10 13:58:48 -04:00
vulcandth 6f4209268b Use RS Group offset constants for slot_reel
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-05 12:20:03 +02:00
vulcandth 9c9744ea78 Document surfing on top of NPCs 2022-08-31 18:25:26 -05:00
vulcandth 7da3a68695 Add Bug comment for fishing/surfing on NPCs 2022-08-31 00:47:05 -05:00
Fredrik Ljungdahl 14e32d9fd3 Replace numbers with constants in PlayHitSound 2022-08-24 12:19:04 +02:00
vulcandth 6de80c7795 Fix AI_Smart_Rage comment 2022-08-21 22:45:40 -05:00
Rangi 659e083376 Move non-Pokémon graphics out of gfx/icons 2022-08-17 17:45:28 -04:00
vulcandth 2dacdbf926 Bug Doc: Options menu fails to clear joypad state on initialization 2022-08-11 23:36:33 -05:00
Rangi 902445d353 Refer to "Rival", not "Silver" (#103)
See https://github.com/pret/pokecrystal/pull/983
2022-08-10 21:24:58 -04:00
Rangi d4362cad05 Fix some whitespace 2022-08-07 00:38:04 -04:00
Rangi 22ff80f0fb Assert that there are NUM_FRAMES textbox frames 2022-08-06 12:26:09 -04:00
Rangi 2d7f97e52f Define scene constants alongside scene_scripts (#101)
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:12 -04:00
Colton G. Rushton 99fd84eba6 wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#99) 2022-07-09 17:18:21 -04:00
vulcandth 4c95a9a708 Clean up bugs commented in the source code (#89)
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-07-09 16:12:32 -05:00
Rangi 09672ef3d6 Split "gfx anims" into "pic anims" and "sprite anims" 2022-07-04 01:11:41 -04:00
vulcandth 1e1dbf842b VC ExchangeBytes Aliases
Co-Authored-By: aaaaaa123456789 <aaaaaa123456789@acidch.at>
2022-06-21 11:16:20 +02:00
Rangi a2ba900bf7 Rename search2.asm 2022-06-17 23:27:50 -04:00
vulcandth b81044d4b6 Document that farcall returns c in a for some code (#91) 2022-06-17 22:30:52 -04:00
vulcandth 6805c678ee Rename SLP to SLP_MASK (#84)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:55 -04:00
vulcandth 357a90f08f Remove redundant comments referencing labels (#85) 2022-06-06 17:34:51 -04:00
vulcandth 464c67ee73 RGBDS syntax updates (#78)
New MACRO and DEF syntax
2022-06-06 17:25:39 -04:00
vulcandth 2bab8a2946 Improved Virtual Console patch identifiers (#79) 2022-06-06 17:22:43 -04:00
vulcandth a88223d9b3 Correct Intro_UpdateTilemapAndBGMap values (#88) 2022-05-27 18:35:33 -04:00
Konrad Borowski 2b6134b436 Remove Heavy Ball never happens comment
It's not correct as Snorlax weights more than 409.6 kg.
2022-05-26 19:56:29 +00:00
vulcandth 1ee3020657 Add hSerialConnectionStatus vc_asserts (#77) 2022-04-17 12:35:38 -04:00
Rangi d0491ecb6e Use NUM_BATTLE_STATS instead of raw numbers 2022-04-08 17:11:05 -04:00
Rangi fa8e3334b3 Replace magic numbers with constants 2022-03-20 20:01:08 -04:00
vulcandth 3d58fb9556 Build the Virtual Console patches with make gold_vc and make silver_vc (#74) 2022-03-14 17:03:15 -04:00
Rangi fddd1c132b Identify some wMenuJoypad-related button constants 2022-03-09 19:42:31 -05:00
mid-kid c43b1f7194 Use constants for PartyAttr in move_effects/thief.asm 2022-02-15 18:52:44 +01:00
Rangi b74d56462c Clear however many bytes are needed for wFruitTreeFlags 2022-02-14 17:28:05 -05:00
Rangi a5d862057a Use VRAM_End in place of sScratch 2022-01-20 20:16:20 -05:00
Rangi 6149917db0 Better comments for enemy health percentage code 2022-01-10 21:25:24 -05:00
Rangi 2aba2b9ff0 Use time constants more often 2022-01-10 20:58:47 -05:00
Rangi 944d0e5303 Identify why five of six enemy mon base stats are copied 2022-01-08 14:02:54 -05:00
Rangi 697093f787 Identify some overworld movement data 2021-12-22 21:38:24 -05:00
Rangi 14a21880a0 Use ~X instead of $ff ^ X 2021-11-23 20:50:17 -05:00
Rangi 05130829f9 Add assertions to some more tables 2021-10-24 18:28:38 -04:00
Rangi 7ec200353e Add table assertions to slot machine data 2021-10-15 22:14:58 -04:00
Rangi 24eafe25aa Add assert PokemonPicPointers == UnownPicPointers in GetFrontpic 2021-10-06 17:44:37 -04:00
Rangi dc1a06ba05 and 50 percent -> and %011111111 2021-09-26 22:13:24 -04:00
Rangi 30d8a72d84 Use EFFECTIVE constant for 1.0× battle damage 2021-09-26 22:04:08 -04:00
Rangi c91db56f42 Identify more palettes in CBG layouts 2021-07-19 18:59:11 -04:00
Rangi db4817ed1b Fixing comments in BattleCommand_Teleport 2021-06-20 10:59:17 -04:00
Rangi 3eda24dc47 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:07 -04:00
TheFakeMateo a9dd70cc35 Fix incorrectly swapped constants in Players PC 2021-06-08 22:43:52 -06:00