Adds constants for the address and memory size of the VRAM data for various modes.
Redumped/named some graphics. (pika kickbacks, 1 up delivery/life digit/kyogre)
BG tilemaps (and files) to match their correct layer, rather than their sequence in the board file.
files/variables related to the pika kickback tiles.
se_ruby_bumper_hit -> se_bumper_hit (used for bumpers on both boards)
scoreOverlayActive -> cutsceneBackdropBarActive (context correction)
ballLaunchSpeed -> prevScrollYTileIx (usage has been traced)
scrollEffectY - scrollEffectYpx (defines precision scale)
shopSignFrame -> sapphireShopSignFrame (narrowing scope)
catchHoleTileVariant -> sharpedoNextTilelIx (clarity for which catch hole)
bossVulnerable -> bossNextFrameId (not just vulnerability related; general animation)
pauseScoreOverlayActive -> pauseCutsceneBackdropBarActive. (Whether or not there is a cutscene bar active when the pause button is pressed - That bar blacks out)
savedScoreOverlayActive -> savedcutsceneBackdropBarActive (as with previous entry)
gPokemonNameDisplayGfx -> gMartEvoForegroundMenuUx_Gfx (Name does end up drawn on that display, but it has a larger context than just the name)
Adds some define macro for specifying an address in the Board/Object VRAM space, indexed by the Block, Row, Col
Documents the usage of the block 2 + 6 lines of block 3, with a 'modulused crosssection of the board', and a tilemap that draws those in the correct color, for the section where the camera is. (this also explains the 'wrapping, with wrong colors' if viewing the BG layer 3.)
Adds a define macro for addressing with the 'board wrapped' memory content, so that the tile reads as its board relative position, rather than its vram memory position.
Applies macro in place of memory address, when working with the VRAM data.
Resolves#224
Adds switch consts for Collision:
BoardCollisionType, CollisionBounceBehaviorType, CollisionResolutionState
Also names some input/output params for collision functions.
Renames BoardProcess#[a/b] functions, to reflect what that phase does.
Adds enum vals for the CurrentBoardProcPairs array indexing
Adds switch consts for End of Ball Bonus phases, debug modes, Tilt Direction handling, Return location from bonus boards, demo variants
Now uses consts for the number of dex lines/characters per line.
Pin spriteGroup1_ to r4 with an explicit register variable, which lets two
of the five asm("") barriers go. The target keeps two redundant pointer
copies in its entry block (adds r4, r6, #0 and mov r5, sl); the pin is
enough to keep the first one alive, so the alias1 launder and the oamData
launder are no longer needed. The remaining three barriers protect the
spriteGroup2_ copy, which cannot also be pinned -- the target reuses r5 as
a scratch register once that alias dies, and a pin would reserve it for the
whole function. Three is a hard floor: no configuration with two or fewer
barriers matches.
Also drop the contrived independent re-derivation. spriteGroup2_ =
spriteGroup2 now matches, where it previously required
= &gMain.spriteGroups[1], so the function no longer re-derives a pointer it
already has. Declarations follow RenderPokedexSprites' house style: int i
first, function-scope oamData and spriteSet temps rather than per-branch
copies, and the group pointer as LoadSpriteSets' third argument, as
pokedex.c and field_select.c both do.
Name the sprite group indices via constants/sprite_groups.h, adding the
missing SG_HIGH_SCORE_PRESS_START_0/1. spriteGroup1 and spriteGroup2 are
the page navigation arrows, not page icons -- confirmed by their positions
at baseX 220 and 4, and matching the right/left arrows in the GBC
predecessor's high score screen.
make compare OK; RenderHighScoreSprites stays instruction-exact
(words=0, insns=477, 18-word literal pool).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Retnuhytnuob