a1a22aaf84
Use constants for wIsInBattle values ( #600 )
2026-08-27 18:15:47 -04:00
079d1cc92f
Fix some text formatting, constants, unreferenced local labels ( #596 )
2026-08-06 16:48:33 -04:00
2463685fe3
Replace magic hex numbers in AnimationSubstitute destination addresses ( #581 )
2026-05-24 09:47:30 -05:00
256e85e27b
Fix small typo in one_hit_ko.asm ( #583 )
2026-05-24 09:35:48 -05:00
3c814341c8
Relabel SFX_SILPH_SCOPE to SFX_TRAINER_APPEARED ( #580 )
2026-04-15 12:02:35 -05:00
4e22af12bc
Replace hard-coded numbers with constants in haze.asm ( #564 )
2026-01-17 16:42:12 -05:00
85b9d866c8
Align move grammar with pokecrystal ( #565 )
...
Add comments explaining the redundant move grammar categories inherited from the Japanese version.
2026-01-17 16:41:37 -05:00
0555b42dc0
Replace magic number $7 with SLP_MASK constant ( #555 )
2025-12-26 12:20:49 -05:00
d79c578abd
Specify a max item length for list_start ( #552 )
2025-12-15 15:16:40 -05:00
e9d3324bc0
Comment more unreferenced local labels ( #550 )
2025-12-15 15:14:17 -05:00
8bb03542bd
Update StatusScreen, add *_STATS_BOX constants ( #546 )
2025-12-01 13:46:28 -06:00
3a4382c605
Use more Pokemon data constants, create MOVE_NAME_LENGTH ( #543 )
2025-11-27 13:39:25 -05:00
e92d1af478
Avoid magic numbers for most CopyData calls ( #542 )
2025-11-25 16:53:29 -06:00
308189b638
Use ld_hli_a_string macro to make byte-by-byte strings more obvious ( #540 )
2025-11-23 21:19:21 -06:00
f332678625
Use more hardware and graphics constants ( #532 )
...
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 15:17:31 -05:00
5943b96cf6
Use features of RGBDS 1.0.0 ( #537 )
2025-11-12 15:44:07 -05:00
e3af20b907
Consistently use ld [hli]/ld [hld], not ldi/ldd
2025-10-05 10:53:31 -04:00
108bf2981d
Use RAMG_SRAM_ENABLE ( #530 )
2025-09-07 12:46:26 -04:00
8da7deb893
Update comment for clarity ( #529 )
...
Actually copies from battle struct to party struct to make HP and status changes to a pokemon permanent
2025-09-03 11:59:22 -04:00
4d2594cb24
Label and constant cleanup ( #528 )
...
* Label cleanup, add some constants instead of raw numbers
* Rename load/save game functions to be more explicit
2025-09-03 11:56:09 -04:00
31fc2e229d
Use <STAT>_UP1_EFFECT constants ( #522 )
2025-08-16 08:37:08 -04:00
4eaccc4a7a
Use less generic labels for party finding loops ( #514 )
2025-07-07 18:59:17 -04:00
78e44a8fb1
Use combined hardware constants
2025-06-30 13:45:24 -04:00
56c405de09
Replace hardware_constants.asm with hardware.inc ( #511 )
2025-06-30 12:47:22 -04:00
fcb61ae0e4
Distinguish single trainer pics section from Pokemon pics
2025-06-25 23:59:47 -04:00
fd043a66c2
Fix typos
2025-06-03 23:48:35 -05:00
b4bae4a5d5
Add a CANNOT_MOVE constant ( #508 )
2025-05-31 15:08:23 -04:00
e1b7b8af0a
Use constants for PP masks instead of magic numbers ( #504 )
2025-04-02 10:49:15 -04:00
43f21cc494
Fix some label typos, and add some constants instead of raw numbers ( #492 )
2025-01-30 17:26:55 -05:00
ec37f6117d
Consistently capitalize ASSERT directives ( #489 )
2025-01-28 23:31:27 -05:00
afb8990169
Miscellaneous cleanup ( #488 )
...
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com >
2025-01-28 23:31:15 -05:00
f023c68417
Use EFFECT_1E
2024-12-27 20:27:34 -05:00
cd647df3b5
Don't pass redundant label names to table_width and list_start ( #484 )
2024-12-27 12:52:24 -05:00
cd1065b7a9
Use RGBDS 0.9.0 ( #482 )
2024-12-25 21:24:21 -05:00
a59c2bbaf9
Use SERIAL_RNS_LENGTH in BattleRandom
2024-12-21 21:04:36 -05:00
67084c9d26
Remove redundant parentheses
2024-12-16 10:35:55 -05:00
ff76bba507
Use "gray", not "grey"
...
This matches the in-game text, e.g. Pewter is "A Stone Gray City"
2024-12-16 10:29:59 -05:00
f801d67f8e
Assert the relations between some move effect constants ( #478 )
2024-11-24 19:13:11 -05:00
c3f297e98b
Fix comment: Road -> Roar ( #466 )
2024-09-24 07:32:47 -05:00
8f1dcf07e5
Identify more flag bits ( #464 )
2024-09-23 23:51:44 -04:00
5a622f628d
Identify remaining uses of wd0b5 and wd11e ( #463 )
2024-09-18 21:41:58 -04:00
613d34678b
Split hSpriteIndexOrTextID into hSpriteIndex and hTextID ( #462 )
...
Also identify `wPPUpCountAndMaxPP`
2024-09-18 21:01:18 -04:00
1f6e2bf999
Use correct label in get_trainer_name.asm ( #461 )
2024-09-09 20:22:58 -04:00
77d051479b
Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem ( #457 )
2024-08-04 10:05:33 -04:00
6e3ab0a9e9
Identify wcd6d as wNameBuffer and others ( #455 )
2024-07-24 12:21:59 -04:00
8fafca714c
Identify various flag labels and bit constants ( #454 )
2024-07-16 13:02:54 -04:00
fc23e72a39
Identify some unused WRAM variables ( #453 )
2024-06-15 12:18:00 -04:00
a247120ac1
Fix a few usages of EFFECTIVE
2023-11-21 20:18:04 -06:00
d4e7a39dd8
Use some more constants in place of raw numbers
2023-11-21 20:15:30 -05:00
465b859c4c
Replace some $a with EFFECTIVE ( #399 )
2023-11-21 20:01:20 -05:00
Alieneer