209 Commits

Author SHA1 Message Date
Alieneer a1a22aaf84 Use constants for wIsInBattle values (#600) 2026-08-27 18:15:47 -04:00
Narishma-gb 079d1cc92f Fix some text formatting, constants, unreferenced local labels (#596) 2026-08-06 16:48:33 -04:00
SnorlaxMonster 85b9d866c8 Align move grammar with pokecrystal (#565)
Add comments explaining the redundant move grammar categories inherited from the Japanese version.
2026-01-17 16:41:37 -05:00
Narishma-gb e9d3324bc0 Comment more unreferenced local labels (#550) 2025-12-15 15:14:17 -05:00
Narishma-gb 3a4382c605 Use more Pokemon data constants, create MOVE_NAME_LENGTH (#543) 2025-11-27 13:39:25 -05:00
Rangi e92d1af478 Avoid magic numbers for most CopyData calls (#542) 2025-11-25 16:53:29 -06:00
Rangi 308189b638 Use ld_hli_a_string macro to make byte-by-byte strings more obvious (#540) 2025-11-23 21:19:21 -06:00
Narishma-gb f332678625 Use more hardware and graphics constants (#532)
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
  and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
  direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
  of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 15:17:31 -05:00
Rangi 5943b96cf6 Use features of RGBDS 1.0.0 (#537) 2025-11-12 15:44:07 -05:00
Rangi e3af20b907 Consistently use ld [hli]/ld [hld], not ldi/ldd 2025-10-05 10:53:31 -04:00
PokefanMarcel 108bf2981d Use RAMG_SRAM_ENABLE (#530) 2025-09-07 12:46:26 -04:00
Vortyne 8da7deb893 Update comment for clarity (#529)
Actually copies from battle struct to party struct to make HP and status changes to a pokemon permanent
2025-09-03 11:59:22 -04:00
Narishma-gb 4d2594cb24 Label and constant cleanup (#528)
* Label cleanup, add some constants instead of raw numbers

* Rename load/save game functions to be more explicit
2025-09-03 11:56:09 -04:00
Rangi42 78e44a8fb1 Use combined hardware constants 2025-06-30 13:45:24 -04:00
Rangi 56c405de09 Replace hardware_constants.asm with hardware.inc (#511) 2025-06-30 12:47:22 -04:00
Rangi42 fcb61ae0e4 Distinguish single trainer pics section from Pokemon pics 2025-06-25 23:59:47 -04:00
dannye fd043a66c2 Fix typos 2025-06-03 23:48:35 -05:00
Rangi b4bae4a5d5 Add a CANNOT_MOVE constant (#508) 2025-05-31 15:08:23 -04:00
edave64 e1b7b8af0a Use constants for PP masks instead of magic numbers (#504) 2025-04-02 10:49:15 -04:00
Rangi ec37f6117d Consistently capitalize ASSERT directives (#489) 2025-01-28 23:31:27 -05:00
Rangi afb8990169 Miscellaneous cleanup (#488)
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
2025-01-28 23:31:15 -05:00
Rangi42 f023c68417 Use EFFECT_1E 2024-12-27 20:27:34 -05:00
Rangi42 a59c2bbaf9 Use SERIAL_RNS_LENGTH in BattleRandom 2024-12-21 21:04:36 -05:00
Vortyne c3f297e98b Fix comment: Road -> Roar (#466) 2024-09-24 07:32:47 -05:00
Sylvie 8f1dcf07e5 Identify more flag bits (#464) 2024-09-23 23:51:44 -04:00
Sylvie 5a622f628d Identify remaining uses of wd0b5 and wd11e (#463) 2024-09-18 21:41:58 -04:00
Sylvie 77d051479b Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem (#457) 2024-08-04 10:05:33 -04:00
Sylvie 6e3ab0a9e9 Identify wcd6d as wNameBuffer and others (#455) 2024-07-24 12:21:59 -04:00
Sylvie 8fafca714c Identify various flag labels and bit constants (#454) 2024-07-16 13:02:54 -04:00
dannye a247120ac1 Fix a few usages of EFFECTIVE 2023-11-21 20:18:04 -06:00
Rangi42 d4e7a39dd8 Use some more constants in place of raw numbers 2023-11-21 20:15:30 -05:00
RainbowMetalPigeon 465b859c4c Replace some $a with EFFECTIVE (#399) 2023-11-21 20:01:20 -05:00
BlueZangoose 9827190aea Use MEGA_PUNCH constant in explosion animation routine (#434)
* Use MEGA_PUNCH constant in explosion animation routine

* Add AnimationType constants and assert

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-21 19:52:53 -05:00
SatoMew f46db37d50 Thoroughly document debug code (#410) 2023-07-15 18:36:59 -04:00
Vortyne 17eaf761e3 Name some unnamed animation constants (#396) 2023-03-25 23:31:59 -04:00
Rangi bbb0e7e82d Use the same music headers as pokecrystal (#382) 2022-08-11 21:23:08 -04:00
SatoMew ac7263b1ad Update comments related to Swift and Substitute checks (#380)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-11 21:22:57 -04:00
Rangi 498da6ab09 Clarify how Metronome picks a move 2022-07-26 00:01:21 -04:00
Rangi 8f81e71f19 Identify some .asm_* labels 2022-07-10 21:11:03 -04:00
Colton G. Rushton cc46b0e510 wOAMBuffer -> wShadowOAM (#370) 2022-07-09 17:18:18 -04:00
Rangi 4e96f9d232 cp MR_FUJIS_HOUSE -> cp POKEMON_TOWER_7F + 1
Fixes #362
2022-06-17 22:58:46 -04:00
vulcandth edb55e00f8 Rename SLP to SLP_MASK (#361)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:52 -04:00
vulcandth d7808d110f Improved Virtual Console patch identifiers (#357) 2022-06-06 17:22:34 -04:00
vulcandth fe8d3c51a4 Build the Virtual Console patches with make red_vc and make blue_vc (#351) 2022-03-26 16:59:36 -04:00
Rangi 09e92c554c Use ~X instead of $ff ^ X 2021-11-23 21:00:07 -05:00
Yoann Fievez f68af5c6e9 Add some constants for options (#344)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2021-11-05 19:45:09 -04:00
Yoann Fievez 8349bfd8e6 Refactorize check button pressed (#340) 2021-11-05 15:40:15 -04:00
Rangi 58d08bff43 Identify some percentage constant values 2021-11-02 19:57:08 -04:00
Amber Brault 30acb46b98 Fix typos (#334) 2021-09-26 21:57:55 -05:00
Rangi 7ee8a6509e wcf4b -> wStringBuffer 2021-08-28 17:02:20 -04:00