146 Commits

Author SHA1 Message Date
Rangi d79c578abd Specify a max item length for list_start (#552) 2025-12-15 15:16:40 -05:00
Narishma-gb e9d3324bc0 Comment more unreferenced local labels (#550) 2025-12-15 15:14:17 -05:00
Narishma-gb 8bb03542bd Update StatusScreen, add *_STATS_BOX constants (#546) 2025-12-01 13:46:28 -06:00
Narishma-gb 3a4382c605 Use more Pokemon data constants, create MOVE_NAME_LENGTH (#543) 2025-11-27 13:39:25 -05:00
Rangi e92d1af478 Avoid magic numbers for most CopyData calls (#542) 2025-11-25 16:53:29 -06:00
Narishma-gb f332678625 Use more hardware and graphics constants (#532)
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
  and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
  direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
  of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 15:17:31 -05:00
Rangi 5943b96cf6 Use features of RGBDS 1.0.0 (#537) 2025-11-12 15:44:07 -05:00
Rangi 628797baff Revise some RAM buffer constants 2025-09-26 16:55:23 -04:00
Rangi 56c405de09 Replace hardware_constants.asm with hardware.inc (#511) 2025-06-30 12:47:22 -04:00
edave64 e1b7b8af0a Use constants for PP masks instead of magic numbers (#504) 2025-04-02 10:49:15 -04:00
Rangi ec37f6117d Consistently capitalize ASSERT directives (#489) 2025-01-28 23:31:27 -05:00
Rangi afb8990169 Miscellaneous cleanup (#488)
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
2025-01-28 23:31:15 -05:00
Engezerstorung 96fc617c69 Correct wTileMapBackup declared space (#487) 2025-01-28 12:08:12 -05:00
Rangi42 67084c9d26 Remove redundant parentheses 2024-12-16 10:35:55 -05:00
Sylvie 8f1dcf07e5 Identify more flag bits (#464) 2024-09-23 23:51:44 -04:00
Sylvie 5a622f628d Identify remaining uses of wd0b5 and wd11e (#463) 2024-09-18 21:41:58 -04:00
Sylvie 613d34678b Split hSpriteIndexOrTextID into hSpriteIndex and hTextID (#462)
Also identify `wPPUpCountAndMaxPP`
2024-09-18 21:01:18 -04:00
Sylvie 77d051479b Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem (#457) 2024-08-04 10:05:33 -04:00
Sylvie 6e3ab0a9e9 Identify wcd6d as wNameBuffer and others (#455) 2024-07-24 12:21:59 -04:00
Sylvie 8fafca714c Identify various flag labels and bit constants (#454) 2024-07-16 13:02:54 -04:00
Sylvie fc23e72a39 Identify some unused WRAM variables (#453) 2024-06-15 12:18:00 -04:00
SatoMew 07cefd462f Clean up item comments (#443) 2023-12-18 18:30:37 -06:00
Rangi42 77887be251 Identify wSavedCoordIndex and its other usages 2023-11-20 18:53:23 -05:00
vulcandth 64061e2092 .calculateHPBarCoords incorrectly referenced OAM
Resolves #411

Co-Authored-By: SnDream <12762219+sndream@users.noreply.github.com>
2023-11-17 22:36:21 -06:00
vulcandth d001ced41b Add macros, constants, and labels for map scripts and text (#367)
This introduces `def_script_pointers`, `def_text_pointers`, and `object_const_def` macros, and applies them to all maps. Most other map labels have also been identified.
2023-07-13 21:27:56 -04:00
Rangi bbb0e7e82d Use the same music headers as pokecrystal (#382) 2022-08-11 21:23:08 -04:00
Chatot4444 8b19405590 Replace Hard-Coded Number With Constant (#381)
Replace a hard coded $a in CheckMapForMon with NUM_WILDMONS
2022-08-11 07:51:18 -05:00
Rangi 8f81e71f19 Identify some .asm_* labels 2022-07-10 21:11:03 -04:00
Colton G. Rushton cc46b0e510 wOAMBuffer -> wShadowOAM (#370) 2022-07-09 17:18:18 -04:00
vulcandth edb55e00f8 Rename SLP to SLP_MASK (#361)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:52 -04:00
vulcandth 6b5be9129c RGBDS syntax updates (#358)
New MACRO and DEF syntax
2022-06-06 17:25:31 -04:00
Rangi 7ee8a6509e wcf4b -> wStringBuffer 2021-08-28 17:02:20 -04:00
Rangi f9ae7b1240 More WRAM label cleanup (still needs UNIONs and renaming) 2021-05-31 16:25:16 -04:00
Rangi 8701ef4d61 Improve some RAM formatting 2021-05-31 11:46:10 -04:00
Rangi 346ce9454a Use macros for bit arrays 2021-05-23 22:09:02 -04:00
Rangi 6a31663c96 Use {interpolation} to generate sequences of RAM labels
Fixes #319
2021-04-27 15:49:59 -04:00
Rangi 95ec2cf039 Verify data table and name list sizes with assertion macros
Fixes #312
2021-03-25 16:44:41 -04:00
Rangi 95353fdefa Identify hUILayoutFlags 2021-02-13 19:48:34 -05:00
dannye 66377fca32 Fix file modes 2020-11-14 20:52:10 -06:00
Rangi 2db54ecb9b Sync more with pokeyellow 2020-11-05 13:23:57 -05:00
SatoMew 2ff7b40d82 Replace ghost Marowak's ambiguous constant 2020-09-22 18:38:29 +01:00
Rangi 8ce20e5c31 Define a constant for the ghost Marowak (hard-coded throughout the engine, like the starters) 2020-08-31 10:58:41 -04:00
Rangi bfd9f617c9 Use constants to delineate map types, and factor out more data 2020-08-31 10:23:19 -04:00
Rangi 69788c536b Add comments associating constants with data, and identify some more data 2020-07-20 12:31:35 -04:00
Rangi a49ca6ef41 Factor out MapBadgeFlags and EscapeRopeTilesets data tables 2020-07-08 10:31:44 -04:00
Rangi 4a7d1513f3 Use 'tile' and 'tiles' macros 2020-07-07 16:21:26 -04:00
Rangi 13129459f1 Sync coordinate macros with pokecrystal 2020-07-07 11:30:10 -04:00
Rangi 45ed05decf Use HIGH() and LOW() 2020-07-07 11:10:29 -04:00
Rangi 06db7ec55b callba/callab -> farcall/callfar; jpba/jpab -> farjp/jpfar 2020-07-06 21:18:22 -04:00
Rangi 772fcc7588 Specify the ldh instruction, don't turn ld into ldh 2020-07-06 19:03:05 -04:00