185 Commits

Author SHA1 Message Date
Narishma-gb 079d1cc92f Fix some text formatting, constants, unreferenced local labels (#596) 2026-08-06 16:48:33 -04:00
PokefanMarcel ee16bd72ee Relocate and use MAP_TILESET_SIZE (#586) 2026-06-08 11:50:47 -04:00
Vortyne 5e6a9433ec Update elevator.asm (#582)
change comment, it *does* in fact have a visual effect in some cases
2026-05-24 09:42:13 -05:00
PokefanMarcel e69d98af67 Use SPRITE_FACING_* constants in spinners.asm (#584) 2026-05-24 09:40:19 -05:00
Rangi 0e49aef88e Use macros to enforce "hidden object" constraints, and rename them to "hidden events" (#559) 2026-01-07 22:05:37 -05:00
Rangi fe1e76466b Use macros to enforce "missable/hide/show object" constraints, and rename them to "toggleable objects" (#557) 2026-01-07 22:05:20 -05:00
Narishma-gb e9d3324bc0 Comment more unreferenced local labels (#550) 2025-12-15 15:14:17 -05:00
Rangi e92d1af478 Avoid magic numbers for most CopyData calls (#542) 2025-11-25 16:53:29 -06:00
Narishma-gb f332678625 Use more hardware and graphics constants (#532)
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
  and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
  direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
  of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 15:17:31 -05:00
Rangi 5943b96cf6 Use features of RGBDS 1.0.0 (#537) 2025-11-12 15:44:07 -05:00
Rangi 628797baff Revise some RAM buffer constants 2025-09-26 16:55:23 -04:00
Narishma-gb 4d2594cb24 Label and constant cleanup (#528)
* Label cleanup, add some constants instead of raw numbers

* Rename load/save game functions to be more explicit
2025-09-03 11:56:09 -04:00
Rangi42 78e44a8fb1 Use combined hardware constants 2025-06-30 13:45:24 -04:00
Rangi 56c405de09 Replace hardware_constants.asm with hardware.inc (#511) 2025-06-30 12:47:22 -04:00
Vortyne d7de1595c0 Fix sprite data comment (#507)
Reduces confusion if someone edits this file since the wrong byte was commented
2025-05-09 18:47:29 -04:00
Narishma-gb 43f21cc494 Fix some label typos, and add some constants instead of raw numbers (#492) 2025-01-30 17:26:55 -05:00
Rangi ec37f6117d Consistently capitalize ASSERT directives (#489) 2025-01-28 23:31:27 -05:00
Vortyne 678d014aef FreezeEnemyTrainerSprite -> SetEnemyTrainerToStayAndFaceAnyDirection 2024-10-07 12:03:26 -04:00
Vortyne 1aa3fb24ec dbsprite is the wrong macro for WriteOAMBlock data (#472) 2024-09-29 18:54:41 -04:00
Sylvie b5d2540e7c Identify more bit flags (#465)
* Identify more bit flags

* Space
2024-09-24 09:33:33 -04:00
Sylvie 8f1dcf07e5 Identify more flag bits (#464) 2024-09-23 23:51:44 -04:00
Sylvie 613d34678b Split hSpriteIndexOrTextID into hSpriteIndex and hTextID (#462)
Also identify `wPPUpCountAndMaxPP`
2024-09-18 21:01:18 -04:00
Sylvie 77d051479b Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem (#457) 2024-08-04 10:05:33 -04:00
Sylvie 8fafca714c Identify various flag labels and bit constants (#454) 2024-07-16 13:02:54 -04:00
Sylvie fc23e72a39 Identify some unused WRAM variables (#453) 2024-06-15 12:18:00 -04:00
vulcandth 1dcc16b347 Delete a couple EOL whitespace. 2023-11-22 15:09:21 +00:00
dannye a247120ac1 Fix a few usages of EFFECTIVE 2023-11-21 20:18:04 -06:00
Rangi42 41ec74e1f0 Fix inaccurate comment in UpdateNPCSprite
Fixes #404
2023-11-21 20:36:00 -05:00
Rangi42 77887be251 Identify wSavedCoordIndex and its other usages 2023-11-20 18:53:23 -05:00
Rangi42 b066d3c9bc Add bigdw and dc data macros 2023-11-20 17:53:19 -05:00
Vortyne 7a7a6d689c Identify the unnamed HRAM variables and one WRAM label (#438) 2023-11-20 17:23:22 -05:00
Vortyne 5739aea990 Name unnamed labels in seafoam islands and pokemon mansion script files (#435)
* Update PokemonMansion1F.asm

* Name unnamed seafoam/mansion labels
2023-11-19 15:09:33 -06:00
SatoMew f46db37d50 Thoroughly document debug code (#410) 2023-07-15 18:36:59 -04:00
vulcandth d001ced41b Add macros, constants, and labels for map scripts and text (#367)
This introduces `def_script_pointers`, `def_text_pointers`, and `object_const_def` macros, and applies them to all maps. Most other map labels have also been identified.
2023-07-13 21:27:56 -04:00
Rangi 22859c4bb7 Revert PR #395 2022-09-26 15:17:26 -04:00
Vortyne 742dd00eb7 Bug: Sprites can receive the wrong movement byte (#395)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-26 14:53:16 -04:00
BlueZangoose 0f5a9eb146 Change names of move subanimations to be meaningful (#389)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-09-25 14:17:39 -04:00
Rangi c299cf1067 Use a SPRITE_SET_LENGTH constant 2022-09-24 11:39:39 -04:00
Rangi d2be79adf1 Add constants and table macros for the map sprite sets (#392)
Fixes #391
2022-09-24 11:30:29 -04:00
Rangi bbb0e7e82d Use the same music headers as pokecrystal (#382) 2022-08-11 21:23:08 -04:00
Rangi 8f81e71f19 Identify some .asm_* labels 2022-07-10 21:11:03 -04:00
Colton G. Rushton cc46b0e510 wOAMBuffer -> wShadowOAM (#370) 2022-07-09 17:18:18 -04:00
vulcandth 6b5be9129c RGBDS syntax updates (#358)
New MACRO and DEF syntax
2022-06-06 17:25:31 -04:00
Rangi c2ad19728a Reformat MoveBoulderDustFunctionPointerTable 2021-05-31 13:09:33 -04:00
Rangi dd690920c9 Use rgbds 0.5.0 features:
- FOR loops
- {interpolation}
- REDEF EQUS
- \# for all macro args
2021-04-17 19:06:56 -04:00
SatoMew 5d9957293c Delete unnecessary comment 2020-11-29 22:47:51 +00:00
SatoMew 242b2e05cf Label and document hFFD7 more accurately 2020-11-29 20:17:29 +00:00
dannye 66377fca32 Fix file modes 2020-11-14 20:52:10 -06:00
Rangi 13d4d533f7 Sync more with pokeyellow 2020-11-06 10:33:58 -05:00
Rangi bc287b9b80 Some formatting changes 2020-10-19 20:26:35 -04:00