ed0546faae
Sync contest struct field documentation from Emerald
2021-06-23 11:32:25 -04:00
d461cbcaa1
Sync more function names from Emerald
2021-06-23 11:10:02 -04:00
6e9821ca07
Split contest code
2021-06-22 15:20:21 -04:00
54cda03087
Sync more contest docs from Emerald
2021-06-21 15:04:48 -04:00
75b2298d37
Start syncing contest code documentation from Emerald
2021-06-21 10:19:41 -04:00
9ab2ab3c80
Document image_processing_effects.c
2021-06-18 16:46:53 -04:00
c5dd8f884a
Revert these symbols back to ewram.h
2021-06-18 14:36:48 -04:00
b6bdaedb77
Sync image_processing_effects from emerald, 1
2021-06-18 14:28:58 -04:00
f5a444af5d
Replace simple ewram access with battle struct, 2
2021-06-17 16:56:13 -04:00
42650e1507
document ewram macros in BattleStartClearSetData
2021-06-17 14:32:35 -04:00
acb87f3f2f
Sync BattleStruct.multiBuffer from Em/FR
2021-06-16 15:55:20 -04:00
12b9fcb31f
Fix modern debug builds
2021-06-13 20:58:11 -04:00
f725204e9d
THE BEAST IS SLAIN
2021-04-19 23:53:23 -04:00
a1138223e9
Mirror pokeemerald PR#1329 & PR#1335 to pokeruby
...
The `externalReservedData` field has been split up into `externalEventData` and `externalEventFlags`, which have their own structs. The new structs deal with interconnectivity between external games/peripherals and RS. US & JP Colosseum Bonus Discs', Colosseum and XD's, Pokémon Channel's, and PokémonBox: Ruby & Sapphire's interactions with these fields has been documented.
The `giftRibbon#` fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind.
2021-02-16 16:43:31 -05:00
c7bbd485c3
Merge pull request #818 from GriffinRichards/deadname
...
Remove deadnaming, sync BgEvent and 2 function names
2020-12-31 14:49:50 -05:00
ed3bb5b080
Remove deadnaming, sync BgEvent and 2 function names
2020-12-31 14:33:45 -05:00
8d09cdb610
Document the unused battle strings for downpour weather
2020-12-31 15:27:53 +00:00
1aab00c7b9
docs: fix simple typo, occurr -> occur
...
There is a small typo in src/scanline_effect.c.
Should read `occur` rather than `occurr`.
2020-12-19 15:59:26 +11:00
b195abfba9
Fix silly typo
2020-12-05 14:12:37 -05:00
4c7a0d8180
German Sapphire v1.1 uses the flash chip ID 0x09c2
2020-12-05 14:05:11 -05:00
d425eb0170
Merge pull request #814 from GriffinRichards/fix-superpower
...
Fix modern superpower animation bug
2020-12-05 10:45:53 -05:00
63e079726f
Fix modern superpower animation bug
2020-12-05 10:28:32 -05:00
9f14b57f55
FLAG_SPECIAL_FLAG_0 -> FLAG_HIDE_MAP_NAME_POPUP
2020-12-02 01:53:28 -03:00
65a13c9f01
Match FadeOutBody (ported from pokeemerald)
2020-11-01 23:30:12 -05:00
75cea2933f
Merge pull request #804 from kazblox/master
...
shop.c: Eliminate do {}
2020-09-13 07:11:20 -04:00
9681d71c92
shop.c: The do {} is actually a fakematch.
...
Turns out we were using the wrong macro the whole time.
2020-09-13 04:08:13 -04:00
a772ce8d70
Remove unused vars
2020-09-06 15:05:04 -04:00
4588d9ee30
Resolve GCC-10.1.0 compiler warnings
2020-09-05 09:26:08 -04:00
4d4e69bcc0
Fix agb_flash in modern ruby
2020-09-03 15:50:40 -04:00
ae4e56b93b
Fix mistakes
2020-09-01 13:37:22 -04:00
bfd7a6d66a
Make invisible a boolean
2020-09-01 12:07:39 -04:00
486c45dc79
Remove fakematch
2020-09-01 11:58:26 -04:00
463daa89a0
Match more naked functions
2020-09-01 11:30:16 -04:00
22eb0e0d33
Fix alignment in sFanfares
2020-08-31 13:31:51 -04:00
038abf80ba
Give songs meaningful english names
2020-08-29 01:47:36 -04:00
d7ec1d234b
Merge pull request #781 from GriffinRichards/constants-mapdatasize
...
Sync fieldmap data
2020-08-21 15:19:42 -04:00
5d6e7a31da
Merge pull request #788 from kazblox/master
...
Fix NONMATCHINGs and actual English Debug support
2020-08-19 01:04:35 -04:00
3d96e954c8
Review changes.
...
Fixed taya_debug_window for good.
2020-08-18 04:38:42 -04:00
30793ff41b
Fix COMMON sym references under modern gcc
2020-07-22 13:12:23 -04:00
4dc2ba23f6
Merge branch 'master' into constants-mapdatasize
2020-07-20 18:03:49 -04:00
aeeff84462
Merge pull request #780 from GriffinRichards/sync-scripts
...
Sync some scripts with pokeemerald
2020-07-20 18:02:50 -04:00
f0bf1e641c
Sync cave_hole.inc
2020-07-20 17:53:45 -04:00
f52ef63c2c
Removed need for asm("")
...
The assembly for comparing r5 is lsr r5, r1, #0x18, so having that be a bool32 makes no sense. After I set r5 to the same type as i, and moved the variables to the top to prevent the cross jump optimization, I found the asm was no longer needed!
2020-07-07 20:06:49 -04:00
7f94272bfa
Actually fix everything.
2020-06-08 21:40:08 -04:00
b5a38ca77f
Fix rev1+. Oops.
2020-06-08 05:23:43 -04:00
2ec8ae4bec
Preliminary support for English rev0 debug. Matching but still needs
...
cleaning up.
Rename DEBUG_TRANSLATE to DEBUG_FIX now that we have actual English
Debug ROMs.
Add Sapphire German "first edition" debug support, now that we have a
hash for it.
Fix an obvious nonmatching.
2020-06-08 04:12:23 -04:00
575440fb78
DrawSummaryScreenNavigationDots: cleanup, fix typos, and convert to
...
shifts for multiplication. (re: Egg -> I can concur GF extremely loved shifts.) Now matching.
2020-06-03 08:09:41 -04:00
d83e96e9fd
port SummaryScreenHandleUpDownInput, sub_809F284 and sub_80A057C from
...
pokeemerald
2020-06-03 06:52:25 -04:00
7e6d3999cf
sub_809E8F0 get.
2020-06-03 04:52:49 -04:00
82c1813048
Fix typos.
2020-06-02 06:44:29 -04:00
PikalaxALT