Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-21 13:30:49 -05:00
Code Issues Packages Projects Releases Wiki Activity

[ty] Include the specialization of a generic TypedDict as part of its display (#22174)

Browse Source 
## Summary

This is the easy bit of https://github.com/astral-sh/ty/issues/2190

## Test Plan

mdtests updated
This commit is contained in:
Alex Waygood
2025-12-24 14:39:46 +00:00
committed by GitHub
parent 81f34fbc8e
commit 3c5956e93d
4 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/ty_python_semantic/resources/mdtest/generics/pep695/aliases.md
View File

@@ -144,7 +144,7 @@ class Dict[T](TypedDict):
type DictInt = Dict[int]
# error: [non-subscriptable] "Cannot subscript non-generic type alias: `Dict` is already specialized"
# error: [non-subscriptable] "Cannot subscript non-generic type alias: `Dict[int]` is already specialized"
def _(x: DictInt[int]):
reveal_type(x) # revealed: Unknown

4
crates/ty_python_semantic/resources/mdtest/typed_dict.md
View File

@@ -1446,7 +1446,7 @@ class TaggedData(TypedDict, Generic[T]):
p1: TaggedData[int] = {"data": 42, "tag": "number"}
p2: TaggedData[str] = {"data": "Hello", "tag": "text"}
# error: [invalid-argument-type] "Invalid argument to key "data" with declared type `int` on TypedDict `TaggedData`: value of type `Literal["not a number"]`"
# error: [invalid-argument-type] "Invalid argument to key "data" with declared type `int` on TypedDict `TaggedData[int]`: value of type `Literal["not a number"]`"
p3: TaggedData[int] = {"data": "not a number", "tag": "number"}
class Items(TypedDict, Generic[T]):
@@ -1488,7 +1488,7 @@ class TaggedData[T](TypedDict):
p1: TaggedData[int] = {"data": 42, "tag": "number"}
p2: TaggedData[str] = {"data": "Hello", "tag": "text"}
# error: [invalid-argument-type] "Invalid argument to key "data" with declared type `int` on TypedDict `TaggedData`: value of type `Literal["not a number"]`"
# error: [invalid-argument-type] "Invalid argument to key "data" with declared type `int` on TypedDict `TaggedData[int]`: value of type `Literal["not a number"]`"
p3: TaggedData[int] = {"data": "not a number", "tag": "number"}
class Items[T](TypedDict):

13
crates/ty_python_semantic/src/types/display.rs
View File

@@ -980,11 +980,14 @@ impl<'db> FmtDetailed<'db> for DisplayRepresentation<'db> {
}
f.write_str("]")
}
Type::TypedDict(TypedDictType::Class(defining_class)) => defining_class
.class_literal(self.db)
.0
.display_with(self.db, self.settings.clone())
.fmt_detailed(f),
Type::TypedDict(TypedDictType::Class(defining_class)) => match defining_class {
ClassType::NonGeneric(class) => class
.display_with(self.db, self.settings.clone())
.fmt_detailed(f),
ClassType::Generic(alias) => alias
.display_with(self.db, self.settings.clone())
.fmt_detailed(f),
},
Type::TypedDict(TypedDictType::Synthesized(synthesized)) => {
f.set_invalid_type_annotation();
f.write_char('<')?;

2
crates/ty_python_semantic/src/types/typed_dict.rs
View File

@@ -556,7 +556,7 @@ impl TypedDictAssignmentKind {
/// Validates assignment of a value to a specific key on a `TypedDict`.
///
/// Returns true if the assignment is valid, or false otherwise.
#[allow(clippy::too_many_arguments)]
#[expect(clippy::too_many_arguments)]
pub(super) fn validate_typed_dict_key_assignment<'db, 'ast>(
context: &InferContext<'db, 'ast>,
typed_dict: TypedDictType<'db>,