Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Exlicitly check for just arguments as well

This commit is contained in:
Jonas Vacek 2025-10-06 20:43:42 +02:00 committed by Jonas Vacek
parent 95a8ccadfb
commit 4bf48e04fc
No known key found for this signature in database
4 changed files with 44 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crates/ruff_linter/resources/test/fixtures/flake8_django/DJ014.py vendored
View File

@ -42,4 +42,5 @@ urlpatterns_mixed = [
# Error - missing trail slash and argument should stay in message
urlpatterns_params_bad = [
path("bad/<slug:slug>", views.bad_view), # DJ014
path("<slug:slug>", views.bad_view), # DJ014
]

1
crates/ruff_linter/resources/test/fixtures/flake8_django/DJ015.py vendored
View File

@ -50,4 +50,5 @@ urlpatterns_quotes = [
# Error - leading trail slash and argument should stay in message
urlpatterns_params_bad = [
path("/bad/<slug:slug>/", views.bad_view), # DJ015
path("/<slug:slug>", views.bad_view), # DJ014
]

23
crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ014_DJ014.py.snap
View File

@ -146,7 +146,8 @@ DJ014 [*] URL route `bad/<slug:slug>` is missing a trailing slash
43 | urlpatterns_params_bad = [
44 | path("bad/<slug:slug>", views.bad_view), # DJ014
| ^^^^^^^^^^^^^^^^^
45 | ]
45 | path("<slug:slug>", views.bad_view), # DJ014
46 | ]
|
help: Add trailing slash
41 |
@ -154,4 +155,22 @@ help: Add trailing slash
43 | urlpatterns_params_bad = [
- path("bad/<slug:slug>", views.bad_view), # DJ014
44 + path("bad/<slug:slug>/", views.bad_view), # DJ014
45 | ]
45 | path("<slug:slug>", views.bad_view), # DJ014
46 | ]
DJ014 [*] URL route `<slug:slug>` is missing a trailing slash
--> DJ014.py:45:10
|
43 | urlpatterns_params_bad = [
44 | path("bad/<slug:slug>", views.bad_view), # DJ014
45 | path("<slug:slug>", views.bad_view), # DJ014
| ^^^^^^^^^^^^^
46 | ]
|
help: Add trailing slash
42 | # Error - missing trail slash and argument should stay in message
43 | urlpatterns_params_bad = [
44 | path("bad/<slug:slug>", views.bad_view), # DJ014
- path("<slug:slug>", views.bad_view), # DJ014
45 + path("<slug:slug>/", views.bad_view), # DJ014
46 | ]

23
crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ015_DJ015.py.snap
View File

@ -225,7 +225,8 @@ DJ015 [*] URL route `/bad/<slug:slug>/` has an unnecessary leading slash
51 | urlpatterns_params_bad = [
52 | path("/bad/<slug:slug>/", views.bad_view), # DJ015
| ^^^^^^^^^^^^^^^^^^^
53 | ]
53 | path("/<slug:slug>", views.bad_view), # DJ014
54 | ]
|
help: Remove leading slash
49 |
@ -233,4 +234,22 @@ help: Remove leading slash
51 | urlpatterns_params_bad = [
- path("/bad/<slug:slug>/", views.bad_view), # DJ015
52 + path("bad/<slug:slug>/", views.bad_view), # DJ015
53 | ]
53 | path("/<slug:slug>", views.bad_view), # DJ014
54 | ]
DJ015 [*] URL route `/<slug:slug>` has an unnecessary leading slash
--> DJ015.py:53:10
|
51 | urlpatterns_params_bad = [
52 | path("/bad/<slug:slug>/", views.bad_view), # DJ015
53 | path("/<slug:slug>", views.bad_view), # DJ014
| ^^^^^^^^^^^^^^
54 | ]
|
help: Remove leading slash
50 | # Error - leading trail slash and argument should stay in message
51 | urlpatterns_params_bad = [
52 | path("/bad/<slug:slug>/", views.bad_view), # DJ015
- path("/<slug:slug>", views.bad_view), # DJ014
53 + path("<slug:slug>", views.bad_view), # DJ014
54 | ]