Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ty] Redact ranking of completions from e2e LSP tests 

I think changes to this value are generally noise. It's hard to tell
what it means and it isn't especially actionable. We already have an
eval running in CI for completion ranking, so I don't think it's
terribly important to care about ranking here in e2e tests _generally_.
This commit is contained in:
Andrew Gallant 2025-12-04 12:08:10 -05:00 committed by Andrew Gallant
parent f054e7edf8
commit 6a025d1925
5 changed files with 30 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
crates/ty_server/tests/e2e/notebook.rs
View File

@ -5,6 +5,8 @@ use ty_server::ClientOptions;
use crate::{TestServer, TestServerBuilder}; use crate::{TestServer, TestServerBuilder};
static FILTERS: &[(&str, &str)] = &[(r#""sortText": "[0-9 ]+""#, r#""sortText": "[RANKING]""#)];
#[test] #[test]
fn publish_diagnostics_open() -> anyhow::Result<()> { fn publish_diagnostics_open() -> anyhow::Result<()> {
let mut server = TestServerBuilder::new()? let mut server = TestServerBuilder::new()?
@ -309,7 +311,11 @@ b: Litera
let completions = literal_completions(&mut server, &second_cell, Position::new(1, 9)); let completions = literal_completions(&mut server, &second_cell, Position::new(1, 9));
insta::with_settings!({
filters => FILTERS.iter().copied(),
}, {
assert_json_snapshot!(completions); assert_json_snapshot!(completions);
});
Ok(()) Ok(())
} }
@ -340,7 +346,11 @@ b: Litera
let completions = literal_completions(&mut server, &first_cell, Position::new(1, 9)); let completions = literal_completions(&mut server, &first_cell, Position::new(1, 9));
insta::with_settings!({
filters => FILTERS.iter().copied(),
}, {
assert_json_snapshot!(completions); assert_json_snapshot!(completions);
});
Ok(()) Ok(())
} }
@ -373,7 +383,11 @@ b: Litera
let completions = literal_completions(&mut server, &second_cell, Position::new(1, 9)); let completions = literal_completions(&mut server, &second_cell, Position::new(1, 9));
insta::with_settings!({
filters => FILTERS.iter().copied(),
}, {
assert_json_snapshot!(completions); assert_json_snapshot!(completions);
});
Ok(()) Ok(())
} }
@ -409,7 +423,11 @@ b: Litera
let completions = literal_completions(&mut server, &second_cell, Position::new(1, 9)); let completions = literal_completions(&mut server, &second_cell, Position::new(1, 9));
insta::with_settings!({
filters => FILTERS.iter().copied(),
}, {
assert_json_snapshot!(completions); assert_json_snapshot!(completions);
});
Ok(()) Ok(())
} }

4
crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import.snap
View File

@ -6,7 +6,7 @@ expression: completions
{ {
"label": "Literal (import typing)", "label": "Literal (import typing)",
"kind": 6, "kind": 6,
"sortText": " 35", "sortText": "[RANKING]",
"insertText": "Literal", "insertText": "Literal",
"additionalTextEdits": [ "additionalTextEdits": [
{ {
@ -27,7 +27,7 @@ expression: completions
{ {
"label": "LiteralString (import typing)", "label": "LiteralString (import typing)",
"kind": 6, "kind": 6,
"sortText": " 36", "sortText": "[RANKING]",
"insertText": "LiteralString", "insertText": "LiteralString",
"additionalTextEdits": [ "additionalTextEdits": [
{ {

4
crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_docstring.snap
View File

@ -6,7 +6,7 @@ expression: completions
{ {
"label": "Literal (import typing)", "label": "Literal (import typing)",
"kind": 6, "kind": 6,
"sortText": " 35", "sortText": "[RANKING]",
"insertText": "Literal", "insertText": "Literal",
"additionalTextEdits": [ "additionalTextEdits": [
{ {
@ -27,7 +27,7 @@ expression: completions
{ {
"label": "LiteralString (import typing)", "label": "LiteralString (import typing)",
"kind": 6, "kind": 6,
"sortText": " 36", "sortText": "[RANKING]",
"insertText": "LiteralString", "insertText": "LiteralString",
"additionalTextEdits": [ "additionalTextEdits": [
{ {

4
crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_from_future.snap
View File

@ -6,7 +6,7 @@ expression: completions
{ {
"label": "Literal (import typing)", "label": "Literal (import typing)",
"kind": 6, "kind": 6,
"sortText": " 35", "sortText": "[RANKING]",
"insertText": "Literal", "insertText": "Literal",
"additionalTextEdits": [ "additionalTextEdits": [
{ {
@ -27,7 +27,7 @@ expression: completions
{ {
"label": "LiteralString (import typing)", "label": "LiteralString (import typing)",
"kind": 6, "kind": 6,
"sortText": " 36", "sortText": "[RANKING]",
"insertText": "LiteralString", "insertText": "LiteralString",
"additionalTextEdits": [ "additionalTextEdits": [
{ {

4
crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_same_cell.snap
View File

@ -6,7 +6,7 @@ expression: completions
{ {
"label": "Literal (import typing)", "label": "Literal (import typing)",
"kind": 6, "kind": 6,
"sortText": " 35", "sortText": "[RANKING]",
"insertText": "Literal", "insertText": "Literal",
"additionalTextEdits": [ "additionalTextEdits": [
{ {
@ -27,7 +27,7 @@ expression: completions
{ {
"label": "LiteralString (import typing)", "label": "LiteralString (import typing)",
"kind": 6, "kind": 6,
"sortText": " 36", "sortText": "[RANKING]",
"insertText": "LiteralString", "insertText": "LiteralString",
"additionalTextEdits": [ "additionalTextEdits": [
{ {