Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Tweak code

This commit is contained in:
Tom Kuson 2023-06-06 21:49:48 +01:00
parent ad4ae49ea2
commit 89c1dc39f7
No known key found for this signature in database
GPG Key ID: E5711BE825F4B79E
2 changed files with 25 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/ruff/src/rules/pylint/rules/iteration_over_set.rs
View File

@ -38,7 +38,7 @@ impl Violation for IterationOverSet {
/// PLC0208 /// PLC0208
pub(crate) fn iteration_over_set(checker: &mut Checker, expr: &Expr) { pub(crate) fn iteration_over_set(checker: &mut Checker, expr: &Expr) {
if let Expr::Set(_) = expr { if expr.is_set_expr() {
checker checker
.diagnostics .diagnostics
.push(Diagnostic::new(IterationOverSet, expr.range())); .push(Diagnostic::new(IterationOverSet, expr.range()));

70
crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLC0208_iteration_over_set.py.snap
View File

@ -10,62 +10,44 @@ iteration_over_set.py:3:13: PLC0208 Use a sequence type instead of a `set` when
6 | print(f"I like {item}.") 6 | print(f"I like {item}.")
| |
iteration_over_set.py:6:13: PLC0208 Use a sequence type instead of a `set` when iterating over values iteration_over_set.py:6:28: PLC0208 Use a sequence type instead of a `set` when iterating over values
| |
6 | print(f"I like {item}.") 6 | print(f"I like {item}.")
7 | 7 |
8 | for item in set(("apples", "lemons", "water")): # flags set() calls 8 | numbers_list = [i for i in {1, 2, 3}] # flags sets in list comprehensions
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PLC0208 | ^^^^^^^^^ PLC0208
9 | print(f"I like {item}.") 9 |
10 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions
| |
iteration_over_set.py:9:15: PLC0208 Use a sequence type instead of a `set` when iterating over values iteration_over_set.py:8:27: PLC0208 Use a sequence type instead of a `set` when iterating over values
| |
9 | print(f"I like {item}.") 8 | numbers_list = [i for i in {1, 2, 3}] # flags sets in list comprehensions
10 | 9 |
11 | for number in {i for i in range(10)}: # flags set comprehensions 10 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions
| ^^^^^^^^^^^^^^^^^^^^^^ PLC0208 | ^^^^^^^^^ PLC0208
12 | print(number) 11 |
12 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions
| |
iteration_over_set.py:12:28: PLC0208 Use a sequence type instead of a `set` when iterating over values iteration_over_set.py:10:36: PLC0208 Use a sequence type instead of a `set` when iterating over values
| |
12 | print(number) 10 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions
11 |
12 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions
| ^^^^^^^^^ PLC0208
13 | 13 |
14 | numbers_list = [i for i in {1, 2, 3}] # flags sets in list comprehensions 14 | numbers_gen = (i for i in {1, 2, 3}) # flags sets in generator expressions
|
iteration_over_set.py:12:27: PLC0208 Use a sequence type instead of a `set` when iterating over values
|
12 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions
13 |
14 | numbers_gen = (i for i in {1, 2, 3}) # flags sets in generator expressions
| ^^^^^^^^^ PLC0208 | ^^^^^^^^^ PLC0208
15 | 15 |
16 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions 16 | # Non-errors
|
iteration_over_set.py:14:27: PLC0208 Use a sequence type instead of a `set` when iterating over values
|
14 | numbers_list = [i for i in {1, 2, 3}] # flags sets in list comprehensions
15 |
16 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions
| ^^^^^^^^^ PLC0208
17 |
18 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions
|
iteration_over_set.py:16:36: PLC0208 Use a sequence type instead of a `set` when iterating over values
|
16 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions
17 |
18 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions
| ^^^^^^^^^ PLC0208
19 |
20 | numbers_gen = (i for i in {1, 2, 3}) # flags sets in generator expressions
|
iteration_over_set.py:18:27: PLC0208 Use a sequence type instead of a `set` when iterating over values
|
18 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions
19 |
20 | numbers_gen = (i for i in {1, 2, 3}) # flags sets in generator expressions
| ^^^^^^^^^ PLC0208
21 |
22 | # Non-errors
| |