Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix lack of `not` in `PLC1901` error message (#3497)

This commit is contained in:
Grzegorz Bokota 2023-03-14 00:19:41 +01:00 committed by GitHub
parent 62ff3b62e3
commit a82fe4a139
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/ruff/src/rules/pylint/rules/compare_to_empty_string.rs
View File

@ -34,8 +34,8 @@ impl TryFrom<&Cmpop> for EmptyStringCmpop {
impl EmptyStringCmpop { impl EmptyStringCmpop {
pub fn into_unary(self) -> &'static str { pub fn into_unary(self) -> &'static str {
match self { match self {
Self::Is | Self::Eq => "", Self::Is | Self::Eq => "not ",
Self::IsNot | Self::NotEq => "not ", Self::IsNot | Self::NotEq => "",
} }
} }
} }

10
crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLC1901_compare_to_empty_string.py.snap
View File

@ -4,7 +4,7 @@ expression: diagnostics
--- ---
- kind: - kind:
name: CompareToEmptyString name: CompareToEmptyString
body: "`x is \"\"` can be simplified to `x` as an empty string is falsey" body: "`x is \"\"` can be simplified to `not x` as an empty string is falsey"
suggestion: ~ suggestion: ~
fixable: false fixable: false
location: location:
@ -17,7 +17,7 @@ expression: diagnostics
parent: ~ parent: ~
- kind: - kind:
name: CompareToEmptyString name: CompareToEmptyString
body: "`x == \"\"` can be simplified to `x` as an empty string is falsey" body: "`x == \"\"` can be simplified to `not x` as an empty string is falsey"
suggestion: ~ suggestion: ~
fixable: false fixable: false
location: location:
@ -30,7 +30,7 @@ expression: diagnostics
parent: ~ parent: ~
- kind: - kind:
name: CompareToEmptyString name: CompareToEmptyString
body: "`y is not \"\"` can be simplified to `not y` as an empty string is falsey" body: "`y is not \"\"` can be simplified to `y` as an empty string is falsey"
suggestion: ~ suggestion: ~
fixable: false fixable: false
location: location:
@ -43,7 +43,7 @@ expression: diagnostics
parent: ~ parent: ~
- kind: - kind:
name: CompareToEmptyString name: CompareToEmptyString
body: "`y != \"\"` can be simplified to `not y` as an empty string is falsey" body: "`y != \"\"` can be simplified to `y` as an empty string is falsey"
suggestion: ~ suggestion: ~
fixable: false fixable: false
location: location:
@ -56,7 +56,7 @@ expression: diagnostics
parent: ~ parent: ~
- kind: - kind:
name: CompareToEmptyString name: CompareToEmptyString
body: "`\"\" != z` can be simplified to `not z` as an empty string is falsey" body: "`\"\" != z` can be simplified to `z` as an empty string is falsey"
suggestion: ~ suggestion: ~
fixable: false fixable: false
location: location: