Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

avoid breaking when the first parameter has leading comments

This commit is contained in:
Brent Westbrook 2025-12-09 15:32:24 -05:00
parent 90f43bde84
commit b0a82983af
No known key found for this signature in database
2 changed files with 28 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
crates/ruff_python_formatter/src/other/parameters.rs
View File

@ -241,6 +241,32 @@ impl FormatNodeRule<Parameters> for FormatParameters {
let num_parameters = item.len();
if self.parentheses == ParametersParentheses::Never {
// In a lambda, format any leading comments on the first parameter outside of the
// parameters group so that the parameters don't break. For example, format this input:
//
// ```py
// (
// lambda
// * # this becomes a leading comment on *x
// x, **y:
// x
// )
// ```
//
// as:
//
// ```py
// (
// lambda
// # this becomes a leading comment on *x
// *x, **y: x
// )
// ```
if let Some(first) = item.iter().next()
&& comments.has_leading(first.as_parameter())
{
leading_node_comments(first.as_parameter()).fmt(f)?;
}
write!(f, [group(&format_inner), dangling_comments(dangling)])
} else if num_parameters == 0 {
let mut f = WithNodeLevel::new(NodeLevel::ParenthesizedExpression, f);

6
crates/ruff_python_formatter/tests/snapshots/format@expression__lambda.py.snap
View File

@ -539,15 +539,13 @@ def a():
(
lambda
# comment
*x,
**y: x
*x, **y: x
)
(
lambda
# comment 2
*x,
**y: x
*x, **y: x
)
(