mirror of https://github.com/astral-sh/ruff
03303a9edd
## Summary Prior to this change `extend_unsafe_fixes` took precedence over `extend_safe_fixes` selectors, so any conflicts were resolved in favour of `extend_unsafe_fixes`. Thanks to that ruff were conservatively assuming that if configs conlict the fix corresponding to selected rule will be treated as unsafe. After this change we take into account Specificity of the selectors. For conflicts between selectors of the same Specificity we will treat the corresponding fixes as unsafe. But if the conflicting selectors are of different specificity the more specific one will win. ## Test Plan Tests were added for the `FixSafetyTable` struct. The `check_extend_unsafe_fixes_conflict_with_extend_safe_fixes_by_specificity` integration test was added to test conflicting rules of different specificity. Fixes #8404 --------- Co-authored-by: Zanie <contact@zanie.dev> |
||
|---|---|---|
| .. | ||
| checkers | ||
| comments | ||
| cst | ||
| docstrings | ||
| fix | ||
| importer | ||
| lex | ||
| message | ||
| registry | ||
| rules | ||
| settings | ||
| snapshots | ||
| codes.rs | ||
| directives.rs | ||
| doc_lines.rs | ||
| fs.rs | ||
| lib.rs | ||
| line_width.rs | ||
| linter.rs | ||
| logging.rs | ||
| noqa.rs | ||
| packaging.rs | ||
| pyproject_toml.rs | ||
| registry.rs | ||
| renamer.rs | ||
| rule_redirects.rs | ||
| rule_selector.rs | ||
| source_kind.rs | ||
| test.rs | ||
| upstream_categories.rs | ||