mirror of
https://github.com/Druthulu/BFM-decomp
synced 2026-09-26 13:33:34 -04:00
fix(phase-28 T7): worklist --assert-partition read the wrong manifest key (silent default)
- worklist.py:194 read manifest.get("source", "ov_SC01_077") but the manifest key is
`source_overlay` -> the ", ov_SC01_077" DEFAULT always fired, so the R32 partition assertion
checked a hardcoded binary regardless of the manifest, and would print "PARTITION OK" while
validating the wrong one. Now reads source_overlay and FAILS LOUD if the key is truly absent
(refuses to guess a default — R32/R35). Still passes: 223 live stubs, 223 rows -> PARTITION OK.
- worklist.py:100 n_overlays default 134 -> 138 (defensive; the manifest always provides 138 since
the P27 disc audit, so this default is never actually hit).
NOTE on the other "134" mentions (backlog.py:22, second-oracle.md:60, build_fuel_manifest docstrings,
worklist.py:13): those are descriptive ×134-LEVERAGE prose, not functional — the actual reach is
recomputed live from the 138 sigs everywhere (reach_histogram globs .run/sig.ov_*.jsonl). Left as-is
rather than burn a phase on cosmetic docstring edits that aren't wrong (the leverage concept holds).
This commit is contained in:
+11
-2
@@ -97,7 +97,7 @@ def _table(rows, with_cum=True):
|
||||
|
||||
|
||||
def render_md(rows, total_gain, manifest, top):
|
||||
n_over = manifest.get("n_overlays", 134)
|
||||
n_over = manifest.get("n_overlays", 138) # 138 since the P27 disc audit (was 134); the manifest always provides it
|
||||
by_class = {}
|
||||
for r in rows:
|
||||
d = by_class.setdefault(r["class"], {"n": 0, "gain": 0})
|
||||
@@ -191,7 +191,16 @@ def main():
|
||||
backlog.render()
|
||||
manifest = json.load(open(os.path.join(REPO, a.manifest)))
|
||||
if getattr(a, "assert_partition", False):
|
||||
sys.exit(assert_partition(manifest, manifest.get("source", "ov_SC01_077")))
|
||||
# The manifest key is `source_overlay`, NOT `source` (Phase-28 T7). Reading `source` meant the
|
||||
# `, "ov_SC01_077"` DEFAULT always fired — so the R32 partition assertion checked a hardcoded
|
||||
# binary regardless of what the manifest was actually about, and would print "PARTITION OK"
|
||||
# while validating the wrong binary. An assertion that silently targets a default is not an
|
||||
# assertion. Fail loudly if the key is truly absent rather than guess.
|
||||
src = manifest.get("source_overlay")
|
||||
if not src:
|
||||
sys.exit("worklist --assert-partition: manifest has no `source_overlay` key — cannot "
|
||||
"know which binary to partition-check (refusing to guess a default, R32/R35).")
|
||||
sys.exit(assert_partition(manifest, src))
|
||||
bl = load_backlog_by_name()
|
||||
rows, total_gain = build_rows(manifest, bl)
|
||||
json.dump({"note": "Phase-22 ranked worklist; gain_ins = reach*nins (byte-weighted). "
|
||||
|
||||
Reference in New Issue
Block a user