mirror/BFM-decomp
1
0
Fork 0
mirror of https://github.com/Druthulu/BFM-decomp synced 2026-09-29 07:10:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(gater_lane): ledger a draft as gated only for a binary the gate actually EXAMINED

Browse Source 
The ledger write recorded every entry in `ready` as `gated:rc<N>` on ANY rc. When
the gate REFUSES to start (parallel_gate on a dirty tree, a worker missing its link
inputs) it examines nothing -- yet S69's Gate37 refused with rc=1, gated nothing,
and both of its functions were recorded as gated and silently skipped on the retry.
The phantom entries had to be cleared by hand.

"Attempted" and "never looked at" are different facts and only the first justifies
suppressing a re-gate. A binary now counts as EXAMINED when its worker banked
something, wrote per-function verdict rows, or reported a draft count -- i.e. got
far enough to have an opinion (R32). Everything else stays eligible and is named
loudly rather than dropped silently (R55).
This commit is contained in:
Drew T
2026-09-01 17:37:49 -06:00
parent da0a3e6cbf
commit 98e923fdd8
1 changed files with 27 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/gater_lane.py
+27
View File
@@ -429,8 +429,35 @@ def main():
# Ledger the ATTEMPT, not the outcome: a refused draft must not be re-gated unchanged on the
# next tick (that is the 0/23 stored-re-gate law from T1 — a fresh verdict needs a fresh fix).
#
# BUT ONLY FOR A BINARY THE GATE ACTUALLY EXAMINED (P31 S70). This block used to ledger every
# entry in `ready` on any rc. When the gate REFUSES to start — `parallel_gate` on a dirty tree,
# a worker missing its link inputs — it examines NOTHING, yet both functions of S69's Gate37
# (rc=1, nothing gated) were recorded as `gated` and silently skipped on the retry; the phantom
# entries had to be cleared by hand. "Attempted" and "never looked at" are different facts, and
# only the first justifies suppressing a re-gate. A binary counts as EXAMINED when the worker
# banked something, wrote per-function verdict rows, or reported a draft count — i.e. it got far
# enough to have an opinion about the drafts (R32: assert what you actually covered).
examined = set()
for r in results:
if r.get("error"):
continue
try:
t = json.loads((r.get("tail") or "{}").strip().splitlines()[-1])
except Exception:
t = {}
if r.get("banked") or r.get("verdicts") or t.get("drafts"):
examined.add(r.get("binary"))
skipped = [x for x in ready if x[0] not in examined]
if skipped:
print("[gater] NOT ledgering %d draft(s) across %d binary(ies) the gate never examined "
"(refused/blind) — they stay eligible for the next tick: %s"
% (len(skipped), len({x[0] for x in skipped}),
", ".join(sorted({x[0] for x in skipped}))), flush=True)
led = load_ledger()
for binary, fn, path in ready:
if binary not in examined:
continue
arm = os.path.basename(os.path.dirname(path))
led["%s:%s:%s" % (binary, fn, arm)] = "gated:rc%d" % rc
save_ledger(led)