mirror/BanjoRecomp
1
0
Fork 0
mirror of https://github.com/BanjoRecomp/BanjoRecomp synced 2026-05-24 06:50:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add higher precision vertex buffers for CPU skinned geometry. (#26)

Browse Source 
* Add higher precision vertex buffers for CPU skinned geometry.

* Change RT64 to point to the branch. Account for new change in base segment address.

* Update RT64.

* Add comment.

* Update RT64 commit after merge
This commit is contained in:
Darío
2025-12-28 04:36:19 -03:00
committed by GitHub
parent 8c105f6724
commit 8d91c1d411
3 changed files with 81 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/rt64
+1 -1
Submodule lib/rt64 updated: ad1cf390c4...3c4b2cc661
patches/graphics_patches.c
+6
View File
@@ -41,6 +41,8 @@ extern s32 sStackSelector;
extern s32 gTextureFilterPoint;
extern u32 heap_occupiedBytes;
extern void recomp_reset_skinning_stack();
// @recomp Patched to not free anything.
RECOMP_PATCH void graphicsCache_release(void) {
if (sGfxStack[0]) {
@@ -83,6 +85,10 @@ RECOMP_PATCH void game_draw(s32 arg0){
if(D_8037E8E0.unkC == 1){
getGraphicsStacks(&gfx, &mtx, &vtx);
}
// @recomp Reset the high precision position skinning stack.
recomp_reset_skinning_stack();
// @recomp Track the original values.
Mtx* mtx_start = mtx;
Vtx* vtx_start = vtx;
patches/transform_tagging.c
+74
View File
@@ -447,6 +447,66 @@ RECOMP_PATCH void func_80339124(Gfx ** gfx, Mtx ** mtx, BKGeoList *geo_list){
}while(1);
}
// @recomp Applies CPU skinning and saves the result to a higher precision vertex buffer.
#define SKINNING_POSITIONS_MAX 65536
f32 sSkinningFloats[SKINNING_POSITIONS_MAX] __attribute__((aligned(8)));
u32 sSkinningFloatCount;
void recomp_reset_skinning_stack() {
sSkinningFloatCount = 0;
}
float *recomp_apply_cpu_skinning(BKModelUnk28List *arg0, BKVertexList *arg1, AnimMtxList *mtx_list) {
if (sSkinningFloatCount + (arg1->count * 3) > SKINNING_POSITIONS_MAX) {
return NULL;
}
// Copy unmodified positions.
float *dst_pos = &sSkinningFloats[sSkinningFloatCount];
s32 i, j;
for (i = 0; i < arg1->count; i++) {
sSkinningFloats[sSkinningFloatCount++] = arg1->vtx_18[i].v.ob[0];
sSkinningFloats[sSkinningFloatCount++] = arg1->vtx_18[i].v.ob[1];
sSkinningFloats[sSkinningFloatCount++] = arg1->vtx_18[i].v.ob[2];
}
// Always align to multiples of 2.
if (sSkinningFloatCount & 0x1) {
sSkinningFloatCount++;
}
// Apply animation.
BKModelUnk28 *i_ptr = (BKModelUnk28 *)(arg0 + 1);
s32 mtx_index = -2;
f32 src_coord[3];
f32 dst_coord[3];
s32 vertex_index;
for (i = 0; i < arg0->count; i++) {
if (mtx_index != i_ptr->anim_index) {
mtx_index = i_ptr->anim_index;
mlMtxSet(animMtxList_get(mtx_list, mtx_index));
}
src_coord[0] = i_ptr->coord[0];
src_coord[1] = i_ptr->coord[1];
src_coord[2] = i_ptr->coord[2];
mlMtx_apply_vec3f(dst_coord, src_coord);
for (j = 0; j < i_ptr->vtx_count; j++) {
vertex_index = i_ptr->vtx_list[j] * 3;
dst_pos[vertex_index++] = dst_coord[0];
dst_pos[vertex_index++] = dst_coord[1];
dst_pos[vertex_index] = dst_coord[2];
}
i_ptr = (BKModelUnk28 *)((s16 *)(i_ptr + 1) + (i_ptr->vtx_count - 1));
}
return dst_pos;
}
// @recomp Patched to set an initial matrix group for the draw.
RECOMP_PATCH BKModelBin *modelRender_draw(Gfx **gfx, Mtx **mtx, f32 position[3], f32 rotation[3], f32 scale, f32*arg5, BKModelBin* model_bin){
f32 camera_focus[3];
@@ -694,8 +754,17 @@ RECOMP_PATCH BKModelBin *modelRender_draw(Gfx **gfx, Mtx **mtx, f32 position[3],
func_802ED52C(D_8038372C, modelRenderCameraPosition, scale);
}
// @recomp Use higher precision vertex buffer when the model requires CPU skinning.
bool ex_vertex_components_used = FALSE;
if(model_bin->unk28 != NULL && D_8038371C != NULL){
func_802E6BD0((u8*)modelRenderModelBin + modelRenderModelBin->unk28, modelRendervertexList, D_8038371C);
// @recomp Do the skinning again on a high precision version of the vertex buffer. Force its usage for any subsequent display lists.
f32 *skinned_pos = recomp_apply_cpu_skinning((u8 *)modelRenderModelBin + modelRenderModelBin->unk28, modelRendervertexList, D_8038371C);
if (skinned_pos != NULL) {
gEXSetVertexSegment((*gfx)++, G_EX_VERTEX_POSITION, G_EX_ENABLED, osVirtualToPhysical(skinned_pos), osVirtualToPhysical(&modelRendervertexList->vtx_18));
ex_vertex_components_used = TRUE;
}
}
mlMtxIdent();
@@ -758,6 +827,11 @@ RECOMP_PATCH BKModelBin *modelRender_draw(Gfx **gfx, Mtx **mtx, f32 position[3],
gEXPopMatrixGroup((*gfx)++, G_MTX_MODELVIEW);
}
// @recomp Clear use of high precision vertex buffers.
if (ex_vertex_components_used) {
gEXSetVertexSegment((*gfx)++, G_EX_VERTEX_POSITION, G_EX_DISABLED, 0, 0);
}
if(modelRenderCallback.post_method != NULL){
modelRenderCallback.post_method(modelRenderCallback.post_arg);
}