mirror/Shipwright
1
0
Fork 0
mirror of https://github.com/HarbourMasters/Shipwright synced 2026-10-21 10:51:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix OOB check in audio_seqplayer.c (#7387)

Browse Source
This commit is contained in:
Philip Dubé
2026-10-13 13:36:27 +00:00
committed by GitHub
parent 8ccdbb98a0
commit e65fa741db
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
soh/src/code/audio_seqplayer.c
+3 -3
View File
@@ -1186,12 +1186,12 @@ void AudioSeq_SequenceChannelProcessScript(SequenceChannel* channel) {
u16 seqId = AudioEditor_GetReplacementSeq(seqPlayer->seqId);
SequenceData sDat = ResourceMgr_LoadSeqByName(sequenceMap[seqId]);
// The game apparantely would sometimes do negative array lookups, the result of which would
// The game apparently would sometimes do negative array lookups, the result of which would
// get rejected by AudioHeap_SearchCaches, never changing the actual fontid.
if (result > sDat.numFonts)
if (result >= sDat.numFonts)
break;
fontId = sDat.fonts[(sDat.numFonts - result - 1)];
fontId = sDat.fonts[sDat.numFonts - result - 1];
}
if (AudioHeap_SearchCaches(FONT_TABLE, CACHE_EITHER, fontId)) {