mirror/Shipwright
1
0
Fork 0
mirror of https://github.com/HarbourMasters/Shipwright synced 2026-06-22 17:22:54 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix ganondorf hint (#6789)

Browse Source 
Location indexes need to be aligned, so rather than try erase them,
just avoid RC_UNKNOWN_CHECK crash by stubbing it to "an isolated place"
This commit is contained in:
Philip Dubé
2026-06-22 05:08:49 +00:00
committed by GitHub
parent 88006aee2a
commit fd696b5e52
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
soh/soh/Enhancements/randomizer/3drando/hints.cpp
+1 -3
View File
@@ -757,12 +757,10 @@ void CreateStaticItemHint(RandomizerHint hintKey, std::vector<RandomizerHintText
// RANDOTODO choose area in case there are multiple
auto ctx = Rando::Context::GetInstance();
std::vector<RandomizerCheck> locations = FindItemsAndMarkHinted(items, hintChecks);
locations.erase(
std::remove_if(locations.begin(), locations.end(), [](const auto rc) { return rc == RC_UNKNOWN_CHECK; }));
std::vector<RandomizerArea> areas;
areas.reserve(locations.size());
for (auto loc : locations) {
areas.push_back(ctx->GetItemLocation(loc)->GetRandomArea());
areas.push_back(loc == RC_UNKNOWN_CHECK ? RA_NONE : ctx->GetItemLocation(loc)->GetRandomArea());
}
ctx->AddHint(hintKey, Hint(hintKey, HINT_TYPE_AREA, hintTextKeys, locations, areas, {}, yourPocket));
}