Paul Schwabauer b6bf97e2f1 Fix ADPCM sample buffer overread in audio synthesis (#6364) ...

The sampleDataStartPad and aligned variables existed solely to satisfy
the N64 RSP DMA requirement that source addresses be 16-byte aligned.
On PC, aLoadBuffer is a plain memcpy with no such constraint.

The alignment dance caused aLoadBuffer to read up to 15 bytes before
sampleData and up to 8+ bytes past the end of the sample buffer. On
platforms with strict allocator guard pages (e.g. OpenBSD), this
triggers a SIGSEGV.

A second issue remains after removing the alignment dance: nFramesToDecode
is derived from sample counts (loopEnd), but size is not always a multiple
of frameSize. loopEnd and size are derived independently during encoding
and can disagree on the final partial frame, leaving nFramesToDecode *
frameSize exceeding the remaining bytes in the buffer.

Remove sampleDataStartPad and aligned entirely. Clamp the load to
min(nFramesToDecode * frameSize, audioFontSample->size - sampleDataOffset).
The ADPCM decoder operates on DMEM, so a partial last frame in DMEM
produces at most a negligible artifact at sound termination.

2026-03-21 18:34:18 +00:00

..

__osMalloc.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

audio_data.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

audio_effects.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

audio_heap.c

Backport 2ship streamed audio (#5457)

2025-06-27 17:15:02 -07:00

audio_init_params.c

Reapply "Set Sample Rate to 32000 hz (#4780)" (#5234) (#5508)

2025-06-19 13:34:47 -07:00

audio_load.c

Fix undefined behavior (#6089)

2026-01-10 21:31:21 +00:00

audio_playback.c

Backport 2ship streamed audio (#5457)

2025-06-27 17:15:02 -07:00

audio_seqplayer.c

Backport 2ship streamed audio (#5457)

2025-06-27 17:15:02 -07:00

audio_sound_params.c

refactor: use LUS 1.0 RC

2023-01-17 00:33:56 -05:00

audio_synthesis.c

Fix ADPCM sample buffer overread in audio synthesis (#6364)

2026-03-21 18:34:18 +00:00

audioMgr.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

code_800A9F30.c

reapply changes needed for C23 build on develop (#5467)

2025-05-17 00:41:14 -04:00

code_800BB0A0.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

code_800C3C20.c

64-bit early draft - no audio yet

2022-05-15 01:19:02 +02:00

code_800D2E30.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

code_800D31A0.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

code_800E4FE0.c

Backport 2ship streamed audio (#5457)

2025-06-27 17:15:02 -07:00

code_800E6840.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

code_800EC960.c

Enable missing music entries in audio editor (#5685)

2026-02-14 20:31:19 -07:00

code_800F7260.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

code_800F9280.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

code_800FBCE0.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

code_800FC620.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

code_800FCE80.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

code_800FD970.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

code_8006C3A0.c

Modify all (4) instances of Flags_GetRandomizerInf() returns that were u8 to s32 to avoid value overflow. (#4463)

2024-10-21 14:55:46 -07:00

code_8006C510.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

code_800430A0.c

Update Actor Flags to decomp (#4822)

2025-01-16 04:02:23 +01:00

code_801067F0.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

code_801068B0.c

Clean __osMalloc.c (#4351)

2024-11-11 17:46:25 -07:00

db_camera.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

debug_malloc.c

Clean __osMalloc.c (#4351)

2024-11-11 17:46:25 -07:00

fault_drawer.c

Nintendo switch support (#935)

2022-07-25 21:11:53 -04:00

fault.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

flg_set.c

Use PlayState instead of GlobalContext (#1927)

2022-11-06 09:24:34 +01:00

game.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

gamealloc.c

Use Macro for __FILE__ & __LINE__ when possible (#559)

2022-07-05 19:29:34 -04:00

gfxprint.c

Fix GfxPrint shadow for HD fonts and some cleanup (#4681)

2024-12-14 14:39:40 -07:00

graph.c

Ported BtnSelector from 2ship (#6158)

2026-01-18 16:01:39 +00:00

irqmgr.c

Disable BEL char by default when terminal attached (#2306)

2023-01-17 15:18:13 -05:00

jpegdecoder.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

jpegutils.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

listalloc.c

Use Macro for __FILE__ & __LINE__ when possible (#559)

2022-07-05 19:29:34 -04:00

loadfragment2.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

logseverity.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

main.c

Bring back Big Poe Count option, lost in menu refactor (#6126)

2026-01-10 17:19:19 +01:00

mempak.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

mtxuty-cvt.c

Use Macro for __FILE__ & __LINE__ when possible (#559)

2022-07-05 19:29:34 -04:00

padmgr.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

padsetup.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

padutils.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

PreRender.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

printutils.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

relocation.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

sched.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

shrink_window.c

All MenuBar enhancement CVars done. (#4064)

2024-04-26 00:31:28 +00:00

sleep.c

change OSMesg definition and fix memory corruptions

2022-06-04 10:09:50 -05:00

speed_meter.c

This should fix (all?) 60fps interpolation issues left. (#938)

2022-08-03 22:36:13 -04:00

sys_cfb.c

Fix undefined behavior (#6089)

2026-01-10 21:31:21 +00:00

sys_math3d.c

Use PlayState instead of GlobalContext (#1927)

2022-11-06 09:24:34 +01:00

sys_math_atan.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

sys_math.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

sys_matrix.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

sys_ucode.c

update lus includes for new LUS file structure (#5820)

2025-10-09 16:50:51 -07:00

system_malloc.c

Clean __osMalloc.c (#4351)

2024-11-11 17:46:25 -07:00

title_setup.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

TwoHeadArena.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

ucode_disas.c

Use Macro for __FILE__ & __LINE__ when possible (#559)

2022-07-05 19:29:34 -04:00

z_actor.c

Enemy rando cleanup (#6327)

2026-03-17 04:53:33 +00:00

z_bg_item.c

Rename code_80043480.c from decomp (#4731)

2024-12-20 18:26:42 -05:00

z_bgcheck.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_camera_data.inc

fix endianess issue with camera setting data (#3950)

2024-02-20 08:38:10 -06:00

z_camera.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_cheap_proc.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_collision_btltbls.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

z_collision_check.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_common_data.c

CVar Macro Cleanup (#4062)

2024-04-21 10:25:06 -05:00

z_construct.c

Decomp import: rename timer-related functions and variables (#5896)

2026-01-08 18:56:01 +00:00

z_debug_display.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_debug.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_demo.c

Fix song of storms cutscene (#6310)

2026-02-28 23:51:13 +00:00

z_DLF.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_draw.c

Port Scrolling Texture Interpolation over from 2Ship (#6224)

2026-02-26 13:36:55 +00:00

z_eff_blure.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_eff_shield_particle.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_eff_spark.c

[docs] Pull upstream updates: SetupDL (#2048)

2022-11-30 00:29:36 +01:00

z_eff_ss_dead.c

Use PlayState instead of GlobalContext (#1927)

2022-11-06 09:24:34 +01:00

z_effect_soft_sprite_dlftbls.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_effect_soft_sprite_old_init.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_effect_soft_sprite.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_effect.c

Use PlayState instead of GlobalContext (#1927)

2022-11-06 09:24:34 +01:00

z_elf_message.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_en_a_keep.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_en_item00.c

Enemy rando cleanup (#6327)

2026-03-17 04:53:33 +00:00

z_face_reaction.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_fbdemo_circle.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_fbdemo_fade.c

[docs] Upstream updates 1 (#1955)

2022-11-30 00:28:57 +01:00

z_fbdemo_triforce.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_fbdemo_wipe1.c

Fix transition wipe not rendering properly (#4757)

2024-12-26 08:26:04 -07:00

z_fbdemo.c

Use Macro for __FILE__ & __LINE__ when possible (#559)

2022-07-05 19:29:34 -04:00

z_fcurve_data_skelanime.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_frame_advance.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_game_dlftbls.c

Use PlayState instead of GlobalContext (#1927)

2022-11-06 09:24:34 +01:00

z_game_over.c

Decomp import: rename timer-related functions and variables (#5896)

2026-01-08 18:56:01 +00:00

z_horse.c

Enemy rando cleanup (#6327)

2026-03-17 04:53:33 +00:00

z_inventory.c

Custom Item Icons in Textboxes (#6343)

2026-03-20 16:37:44 +00:00

z_jpeg.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_kaleido_manager.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_kaleido_scope_call.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_kaleido_setup.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_kanfont.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_kanji.c

NTSC Support (N64) (#4198)

2025-03-30 12:29:59 -04:00

z_kankyo.c

Port Scrolling Texture Interpolation over from 2Ship (#6224)

2026-02-26 13:36:55 +00:00

z_lib.c

Update SFX symbols from decomp (#4531)

2024-11-08 20:36:57 -07:00

z_lifemeter.c

Modularize Hurt Container mode hook (#5874)

2025-11-24 17:30:34 +00:00

z_lights.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_malloc.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_map_data.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_map_exp.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_map_mark.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_message_PAL.c

Custom Item Icons in Textboxes (#6343)

2026-03-20 16:37:44 +00:00

z_moji.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_msgevent.c

change OSMesg definition and fix memory corruptions

2022-06-04 10:09:50 -05:00

z_olib.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_onepointdemo_data.inc

[#1336] Fix issues with gFasterHeavyBlockLift (#1476)

2022-09-19 20:08:47 -04:00

z_onepointdemo.c

Add option to disable Link spinning with the Goron Pot (#6138)

2026-01-16 13:55:36 +00:00

z_parameter.c

Fix rendering double digit key count (#6371)

2026-03-19 01:39:46 +00:00

z_path.c

Use PlayState instead of GlobalContext (#1927)

2022-11-06 09:24:34 +01:00

z_play.c

Enemy rando cleanup (#6327)

2026-03-17 04:53:33 +00:00

z_player_call.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_player_lib.c

Fix RBA gauntlet colors to match console (#6359)

2026-03-17 17:40:08 +00:00

z_prenmi_buff.c

git subrepo clone https://github.com/HarbourMasters/soh.git

2022-03-22 02:51:23 +01:00

z_prenmi.c

[docs] Pull upstream updates: SetupDL (#2048)

2022-11-30 00:29:36 +01:00

z_quake.c

Use PlayState instead of GlobalContext (#1927)

2022-11-06 09:24:34 +01:00

z_rcp.c

Port Scrolling Texture Interpolation over from 2Ship (#6224)

2026-02-26 13:36:55 +00:00

z_room.c

Fix Entrance Rando Grotto Voidout Crash when voiding back to an area with a background image (#6379)

2026-03-20 03:40:35 +00:00

z_sample.c

[docs] Pull upstream updates: SetupDL (#2048)

2022-11-30 00:29:36 +01:00

z_scene_table.c

Add disable jabu wobble accessibility option (#6280)

2026-03-02 00:45:17 +00:00

z_scene.c

Fix Crash On Play Scene Inits (#5276)

2025-04-02 07:40:43 -04:00

z_skelanime.c

Fix custom tunics not updating on scene change (#6026)

2025-12-30 23:21:53 +00:00

z_skin_awb.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_skin_matrix.c

Use Macro for __FILE__ & __LINE__ when possible (#559)

2022-07-05 19:29:34 -04:00

z_skin.c

Use PlayState instead of GlobalContext (#1927)

2022-11-06 09:24:34 +01:00

z_sound_source.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_sram.c

Modularize Hurt Container mode hook (#5874)

2025-11-24 17:30:34 +00:00

z_ss_sram.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_view.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_vimode.c

Use Macro for __FILE__ & __LINE__ when possible (#559)

2022-07-05 19:29:34 -04:00

z_viscvg.c

Port over decomp updates for vis* and reimplement vismono fb (#4533)

2024-11-09 12:51:31 -05:00

z_vismono.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_viszbuf.c

Port over decomp updates for vis* and reimplement vismono fb (#4533)

2024-11-09 12:51:31 -05:00

z_vr_box_draw.c

Apply clang-format to files (#5273)

2025-04-01 22:33:38 -04:00

z_vr_box.c

[ADD] - 3D Scenes for pre-render areas (#5804)

2025-09-30 19:03:55 -07:00